From patchwork Wed Jul 14 09:13:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 477200 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D59AC07E9A for ; Wed, 14 Jul 2021 09:13:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C06C613AA for ; Wed, 14 Jul 2021 09:13:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238768AbhGNJQR (ORCPT ); Wed, 14 Jul 2021 05:16:17 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:57938 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238723AbhGNJQM (ORCPT ); Wed, 14 Jul 2021 05:16:12 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id AC24F205A1; Wed, 14 Jul 2021 09:13:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1626253997; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lAf4/ogYK8mPAuVj4Z35FdYEHZc00lKG2zOC5b1ViLU=; b=wmJyhZhvyf70NH025iZqb21mddQhnsaTOZFmpkT5Bjr9JARsPq0TEU69ESEHzrWGjNAxeo V9GlZQzpoCycRppUrZax6yOh2DEDgs41ZH0BZ+t/DTUQE/cEot6xRpIhu3S0kwacxsiMAM 5Zm16mJH8QznQrnLr+04S+fg7bkPqtk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1626253997; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lAf4/ogYK8mPAuVj4Z35FdYEHZc00lKG2zOC5b1ViLU=; b=dXE2+o7byiCDu3veS13MulTITutnAXZdV07c96XSSnMmPjpp2MbIRtjyWy6RIydosrn+eJ 5BW1u94tUGrSxbDg== Received: from localhost.localdomain (unknown [10.100.208.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 83F30A3B81; Wed, 14 Jul 2021 09:13:17 +0000 (UTC) From: Jiri Slaby To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Slaby Subject: [PATCH 11/11] amiserial: remove unused state from shutdown Date: Wed, 14 Jul 2021 11:13:14 +0200 Message-Id: <20210714091314.8292-11-jslaby@suse.cz> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210714091314.8292-1-jslaby@suse.cz> References: <20210714091314.8292-1-jslaby@suse.cz> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org 'state' variable is only set but never read in amiserial's shutdown. Drop it. It was like this since the driver was added to the tree as far as I can tell. Signed-off-by: Jiri Slaby --- drivers/tty/amiserial.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c index dffaff5a587a..7ad103e128ac 100644 --- a/drivers/tty/amiserial.c +++ b/drivers/tty/amiserial.c @@ -517,13 +517,10 @@ static int startup(struct tty_struct *tty, struct serial_state *info) static void shutdown(struct tty_struct *tty, struct serial_state *info) { unsigned long flags; - struct serial_state *state; if (!tty_port_initialized(&info->tport)) return; - state = info; - #ifdef SERIAL_DEBUG_OPEN printk("Shutting down serial port %d ....\n", info->line); #endif