diff mbox series

[v4,1/4] dt-bindings: serial: 8250: deprecate aspeed,sirq-polarity-sense

Message ID 20210402182724.20848-2-zev@bewilderbeest.net
State Superseded
Headers show
Series [v4,1/4] dt-bindings: serial: 8250: deprecate aspeed,sirq-polarity-sense | expand

Commit Message

Zev Weiss April 2, 2021, 6:27 p.m. UTC
This property ties SIRQ polarity to SCU register bits that don't
necessarily have any direct relationship to it; the only use of it
was removed in commit c82bf6e133d30e0f9172a20807814fa28aef0f67.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Reviewed-by: Joel Stanley <joel@jms.id.au>
---
 Documentation/devicetree/bindings/serial/8250.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Zev Weiss April 7, 2021, 4:56 p.m. UTC | #1
On Wed, Apr 07, 2021 at 10:18:31AM CDT, Greg Kroah-Hartman wrote:
>On Fri, Apr 02, 2021 at 01:27:21PM -0500, Zev Weiss wrote:

>> This property ties SIRQ polarity to SCU register bits that don't

>> necessarily have any direct relationship to it; the only use of it

>> was removed in commit c82bf6e133d30e0f9172a20807814fa28aef0f67.

>

>Please write that as:

>	c82bf6e133d3 ("ARM: aspeed: g5: Do not set sirq polarity")

>


Ack, will do.

>> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>

>> Reviewed-by: Joel Stanley <joel@jms.id.au>

>> ---

>>  Documentation/devicetree/bindings/serial/8250.yaml | 1 +

>>  1 file changed, 1 insertion(+)

>

>What changed from previous versions?  That always goes below the ---

>line.

>


I included an overview of that in the cover letter 
(https://lore.kernel.org/openbmc/20210402182724.20848-1-zev@bewilderbeest.net/); 
is it desirable to also have that duplicated in the individual patches 
in the series?


Zev
Zev
Zev Weiss April 7, 2021, 5:55 p.m. UTC | #2
On Wed, Apr 07, 2021 at 12:25:09PM CDT, Greg Kroah-Hartman wrote:
>On Wed, Apr 07, 2021 at 11:56:04AM -0500, Zev Weiss wrote:

>> On Wed, Apr 07, 2021 at 10:18:31AM CDT, Greg Kroah-Hartman wrote:

>> > On Fri, Apr 02, 2021 at 01:27:21PM -0500, Zev Weiss wrote:

>> > > This property ties SIRQ polarity to SCU register bits that don't

>> > > necessarily have any direct relationship to it; the only use of it

>> > > was removed in commit c82bf6e133d30e0f9172a20807814fa28aef0f67.

>> >

>> > Please write that as:

>> > 	c82bf6e133d3 ("ARM: aspeed: g5: Do not set sirq polarity")

>> >

>>

>> Ack, will do.

>>

>> > > Signed-off-by: Zev Weiss <zev@bewilderbeest.net>

>> > > Reviewed-by: Joel Stanley <joel@jms.id.au>

>> > > ---

>> > >  Documentation/devicetree/bindings/serial/8250.yaml | 1 +

>> > >  1 file changed, 1 insertion(+)

>> >

>> > What changed from previous versions?  That always goes below the ---

>> > line.

>> >

>>

>> I included an overview of that in the cover letter (https://lore.kernel.org/openbmc/20210402182724.20848-1-zev@bewilderbeest.net/);

>> is it desirable to also have that duplicated in the individual patches in

>> the series?

>

>Any reason why you didn't include all of the relevant people and mailing

>lists in that cover letter?  I've never seen it before :)

>


Ah -- is there a good rule of thumb (or git send-email trick) for that?  
Set-union of get_maintainer.pl over all the patches in the series?  


Zev
Greg KH April 8, 2021, 6:37 a.m. UTC | #3
On Wed, Apr 07, 2021 at 12:55:29PM -0500, Zev Weiss wrote:
> On Wed, Apr 07, 2021 at 12:25:09PM CDT, Greg Kroah-Hartman wrote:

> > On Wed, Apr 07, 2021 at 11:56:04AM -0500, Zev Weiss wrote:

> > > On Wed, Apr 07, 2021 at 10:18:31AM CDT, Greg Kroah-Hartman wrote:

> > > > On Fri, Apr 02, 2021 at 01:27:21PM -0500, Zev Weiss wrote:

> > > > > This property ties SIRQ polarity to SCU register bits that don't

> > > > > necessarily have any direct relationship to it; the only use of it

> > > > > was removed in commit c82bf6e133d30e0f9172a20807814fa28aef0f67.

> > > >

> > > > Please write that as:

> > > > 	c82bf6e133d3 ("ARM: aspeed: g5: Do not set sirq polarity")

> > > >

> > > 

> > > Ack, will do.

> > > 

> > > > > Signed-off-by: Zev Weiss <zev@bewilderbeest.net>

> > > > > Reviewed-by: Joel Stanley <joel@jms.id.au>

> > > > > ---

> > > > >  Documentation/devicetree/bindings/serial/8250.yaml | 1 +

> > > > >  1 file changed, 1 insertion(+)

> > > >

> > > > What changed from previous versions?  That always goes below the ---

> > > > line.

> > > >

> > > 

> > > I included an overview of that in the cover letter (https://lore.kernel.org/openbmc/20210402182724.20848-1-zev@bewilderbeest.net/);

> > > is it desirable to also have that duplicated in the individual patches in

> > > the series?

> > 

> > Any reason why you didn't include all of the relevant people and mailing

> > lists in that cover letter?  I've never seen it before :)

> > 

> 

> Ah -- is there a good rule of thumb (or git send-email trick) for that?

> Set-union of get_maintainer.pl over all the patches in the series?


There might be a git send-email trick, but I don't know it :(
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/serial/8250.yaml b/Documentation/devicetree/bindings/serial/8250.yaml
index f54cae9ff7b2..491b9297432d 100644
--- a/Documentation/devicetree/bindings/serial/8250.yaml
+++ b/Documentation/devicetree/bindings/serial/8250.yaml
@@ -188,6 +188,7 @@  properties:
       offset and bit number to identify how the SIRQ polarity should be
       configured. One possible data source is the LPC/eSPI mode bit. Only
       applicable to aspeed,ast2500-vuart.
+    deprecated: true
 
 required:
   - reg