diff mbox series

[32/44] tty: xtensa/iss, setup the timer statically

Message ID 20210302062214.29627-32-jslaby@suse.cz
State New
Headers show
Series [01/44] MAINTAINERS: orphan mxser | expand

Commit Message

Jiri Slaby March 2, 2021, 6:22 a.m. UTC 
Use DEFINE_TIMER and avoid runtime initialization of the serial_timer.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Chris Zankel <chris@zankel.net>
Cc: Max Filippov <jcmvbkbc@gmail.com>
Cc: linux-xtensa@linux-xtensa.org
---
 arch/xtensa/platforms/iss/console.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

Comments

Max Filippov March 2, 2021, 6:52 a.m. UTC | #1 
On Mon, Mar 1, 2021 at 10:22 PM Jiri Slaby <jslaby@suse.cz> wrote:
>

> Use DEFINE_TIMER and avoid runtime initialization of the serial_timer.

>

> Signed-off-by: Jiri Slaby <jslaby@suse.cz>

> Cc: Chris Zankel <chris@zankel.net>

> Cc: Max Filippov <jcmvbkbc@gmail.com>

> Cc: linux-xtensa@linux-xtensa.org

> ---

>  arch/xtensa/platforms/iss/console.c | 11 ++++-------

>  1 file changed, 4 insertions(+), 7 deletions(-)


Acked-by: Max Filippov <jcmvbkbc@gmail.com>


-- 
Thanks.
-- Max
diff mbox series

Patch

diff --git a/arch/xtensa/platforms/iss/console.c b/arch/xtensa/platforms/iss/console.c
index 3b89d9ceb06a..8ea261b8c022 100644
--- a/arch/xtensa/platforms/iss/console.c
+++ b/arch/xtensa/platforms/iss/console.c
@@ -31,21 +31,18 @@ 
 #define SERIAL_MAX_NUM_LINES 1
 #define SERIAL_TIMER_VALUE (HZ / 10)
 
+static void rs_poll(struct timer_list *);
+
 static struct tty_driver *serial_driver;
 static struct tty_port serial_port;
-static struct timer_list serial_timer;
-
+static DEFINE_TIMER(serial_timer, rs_poll);
 static DEFINE_SPINLOCK(timer_lock);
 
-static void rs_poll(struct timer_list *);
-
 static int rs_open(struct tty_struct *tty, struct file * filp)
 {
 	spin_lock_bh(&timer_lock);
-	if (tty->count == 1) {
-		timer_setup(&serial_timer, rs_poll, 0);
+	if (tty->count == 1)
 		mod_timer(&serial_timer, jiffies + SERIAL_TIMER_VALUE);
-	}
 	spin_unlock_bh(&timer_lock);
 
 	return 0;