From patchwork Sat Nov 7 03:29:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernard Zhao X-Patchwork-Id: 321822 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FC08C388F7 for ; Sat, 7 Nov 2020 03:39:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D2D920878 for ; Sat, 7 Nov 2020 03:39:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728178AbgKGDjK (ORCPT ); Fri, 6 Nov 2020 22:39:10 -0500 Received: from mail-m1271.qiye.163.com ([115.236.127.1]:56147 "EHLO mail-m1271.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728559AbgKGDjJ (ORCPT ); Fri, 6 Nov 2020 22:39:09 -0500 Received: from ubuntu.localdomain (unknown [58.213.83.157]) by mail-m1271.qiye.163.com (Hmail) with ESMTPA id 2D476581FA9; Sat, 7 Nov 2020 11:29:41 +0800 (CST) From: Bernard Zhao To: Greg Kroah-Hartman , Jiri Slaby , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: opensource.kernel@vivo.com, Bernard Zhao Subject: [PATCH 1/2] tty/serial: delete break after return Date: Fri, 6 Nov 2020 19:29:23 -0800 Message-Id: <20201107032924.25044-2-bernard@vivo.com> X-Mailer: git-send-email 2.29.0 In-Reply-To: <20201107032924.25044-1-bernard@vivo.com> References: <20201107032924.25044-1-bernard@vivo.com> MIME-Version: 1.0 X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZS1VLWVdZKFlBSE83V1ktWUFJV1kPCR oVCBIfWUFZHxgYGhofSE1KHktDVkpNS09MSkJMQ0pPQ0hVEwETFhoSFyQUDg9ZV1kWGg8SFR0UWU FZT0tIVUpKS09ISFVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PCI6GQw6KD8YMxwoT0oaTTQw OR4KCVFVSlVKTUtPTEpCTENKQ09JVTMWGhIXVRkeCRUaCR87DRINFFUYFBZFWVdZEgtZQVlOQ1VJ SkhVQ0hVSk5MWVdZCAFZQUlOTEM3Bg++ X-HM-Tid: 0a75a0c0a60798b6kuuu2d476581fa9 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Delete break after return, which will never run. Signed-off-by: Bernard Zhao --- drivers/tty/serial/imx.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 1731d9728865..09703079db7b 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -320,7 +320,6 @@ static u32 imx_uart_readl(struct imx_port *sport, u32 offset) switch (offset) { case UCR1: return sport->ucr1; - break; case UCR2: /* * UCR2_SRST is the only bit in the cached registers that might @@ -331,16 +330,12 @@ static u32 imx_uart_readl(struct imx_port *sport, u32 offset) if (!(sport->ucr2 & UCR2_SRST)) sport->ucr2 = readl(sport->port.membase + offset); return sport->ucr2; - break; case UCR3: return sport->ucr3; - break; case UCR4: return sport->ucr4; - break; case UFCR: return sport->ufcr; - break; default: return readl(sport->port.membase + offset); }