From patchwork Wed Nov 4 19:35:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320575 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp5698869ilc; Wed, 4 Nov 2020 11:37:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJxzhALhyO8lOwAXkUS2QN/z2PJIG9aFi5gtkyWD5/aX7icGr29donDvhJZKdTMvpYcxEt3L X-Received: by 2002:a05:6402:16d5:: with SMTP id r21mr18811458edx.358.1604518652759; Wed, 04 Nov 2020 11:37:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604518652; cv=none; d=google.com; s=arc-20160816; b=xQw2FZTi6HC1AOnwWyXLC6GLbyO1979WSnCSisI2otK2JBio3sJ9FwaMySbEpa5qbc 1E/kKX1XSazU/8QkX96nR+CFHLvm2xHgZkFGPXCj4pouFYO4XX9VeBPVA/oW8uxZSUTJ KVDUAYq57KqFLqDz6hhiDJsKrjRpqJzN1Xd/8KX9+gdFzAdhfjqcIulENFIvKjy7RvIB b/X25O2KtaeP0krfpJQU/OnrsRKCaHTt5Pdo73IlNrRTu2kFbTlFK3DyepjADiKBQLNH SRa+XcKpLPaYtj1vhsbMk2fJjqNQwmbtqbaBxygjp89+5wEoIOtpzALX2Yr475h61NMc dpvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6fgb1IEzfMnPc6nqs8QP0jEqoyFf5EkN3W0LREp5eok=; b=S1JpghaDq/WTq3XzqC6SEtuWJFW8/Ti7p50x4yyulox49xCFkf9J6GNd6QdskZSlUy E68sqSCKbWQfaoYGH64T4DS+y/ZEYVU+6cRzQMoewOQTLBFss0u7PxYr2CwyTrCk/7ED BLnX13RKmoTtMgofKBH+eqQFsa0Co3eehJ0JjIj5wUZapnfWOltzscAoWKQioMPd1erS tYq5C3Eglx62XIsBNgpqX8IDb6mFcCXPLWxWkKkbtXwuz4i3PbmiKadJuByLGjloZhU/ 9fvi5OyBzwMJRKJv0AboTD+2nnuArgrDXY8H0im8Bx18VUNeDLxmJVd2FyzL0DS94woN Si3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dUki5RoA; spf=pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g17si2410125ejr.134.2020.11.04.11.37.32; Wed, 04 Nov 2020 11:37:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dUki5RoA; spf=pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731481AbgKDThX (ORCPT + 2 others); Wed, 4 Nov 2020 14:37:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731540AbgKDTgm (ORCPT ); Wed, 4 Nov 2020 14:36:42 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A41FC040203 for ; Wed, 4 Nov 2020 11:36:42 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id k18so3415721wmj.5 for ; Wed, 04 Nov 2020 11:36:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6fgb1IEzfMnPc6nqs8QP0jEqoyFf5EkN3W0LREp5eok=; b=dUki5RoAgEUXeV68RfVBsjZNTcSI5/Puy7ll183zFMy88MFmsFDu++Lc+6nX6nS1AC f6R+u9/0cYkz9bE0iRfGya8+/e0t/t2FEmXyplh3cPVhWClmNbJpgnBPsGpWvSuWsKlb 9Yjo3MWCHUzlFjclnW2Ag4ZTN/eP2MEPGJsQzi/Rmk6b89US8uJYtsMHbpNTdNur/rAP +xugpeZt1Bzs2DaMfrknk/bKiy6as07x7eJzKM9o7RHXNN6rROFE0jYf/ylkFx6iPDa4 v2Sk+Vi/vHzMQHT2B8Xe+lbVvu8fbvl5bBn2n8yakmZw6QAO8IY8177O8vpbx9rtvWtk SEng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6fgb1IEzfMnPc6nqs8QP0jEqoyFf5EkN3W0LREp5eok=; b=ebTubSIM7aI5UfVBjwmj/6KRSN2uCZm5N3vuy5+4E/8Ayik+zE06jkNZ5jcjxiLIlr U8mvpv+WrHaX48XA2k3Ud6UNwAV/fhoe7PazP2Va8daVjDj8WWI7jhGChltYHPj7uUZB K7wNJqhbrx9pXREYvs0uRZBqqiLRIypx8WioBETuk4KH9tCpYZbL//Bn6qD3hr7kR6kB 7rttg308fBm/Yk30QAfaBv8HL48h7waxXTinGcb6vIUvvnQXVKX6X/Az5yZomyV6pbLm Pb4Ga35QaYcK0sYd/D8k+kNcGmV7kWn9QnJOC4VIx1lmO4C5OBh9gvnD2o8z4s0u6ZW8 BiBw== X-Gm-Message-State: AOAM530lPeoMthJ0hJlgA4w7f3WQgjULZWfBaihsTTVzLheH19t3JCs6 UwHlvz4yUuVZXSXcRRyWSukzpK5w9TfxzVuf X-Received: by 2002:a1c:1d51:: with SMTP id d78mr6192642wmd.60.1604518600809; Wed, 04 Nov 2020 11:36:40 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id x10sm4034444wrp.62.2020.11.04.11.36.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 11:36:40 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Maxime Coquelin , Alexandre Torgue , Gerald Baeza , linux-serial@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH 28/36] tty: serial: stm32-usart: Remove set but unused 'cookie' variables Date: Wed, 4 Nov 2020 19:35:41 +0000 Message-Id: <20201104193549.4026187-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104193549.4026187-1-lee.jones@linaro.org> References: <20201104193549.4026187-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/tty/serial/stm32-usart.c: In function ‘stm32_transmit_chars_dma’: drivers/tty/serial/stm32-usart.c:353:15: warning: variable ‘cookie’ set but not used [-Wunused-but-set-variable] drivers/tty/serial/stm32-usart.c: In function ‘stm32_of_dma_rx_probe’: drivers/tty/serial/stm32-usart.c:1090:15: warning: variable ‘cookie’ set but not used [-Wunused-but-set-variable] Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Maxime Coquelin Cc: Alexandre Torgue Cc: Gerald Baeza Cc: linux-serial@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Signed-off-by: Lee Jones --- drivers/tty/serial/stm32-usart.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.25.1 diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c index ee6c7762d3559..f4de32d3f2afe 100644 --- a/drivers/tty/serial/stm32-usart.c +++ b/drivers/tty/serial/stm32-usart.c @@ -350,7 +350,6 @@ static void stm32_transmit_chars_dma(struct uart_port *port) struct stm32_usart_offsets *ofs = &stm32port->info->ofs; struct circ_buf *xmit = &port->state->xmit; struct dma_async_tx_descriptor *desc = NULL; - dma_cookie_t cookie; unsigned int count, i; if (stm32port->tx_dma_busy) @@ -394,7 +393,7 @@ static void stm32_transmit_chars_dma(struct uart_port *port) desc->callback_param = port; /* Push current DMA TX transaction in the pending queue */ - cookie = dmaengine_submit(desc); + dmaengine_submit(desc); /* Issue pending DMA TX requests */ dma_async_issue_pending(stm32port->tx_ch); @@ -1087,7 +1086,6 @@ static int stm32_of_dma_rx_probe(struct stm32_port *stm32port, struct device *dev = &pdev->dev; struct dma_slave_config config; struct dma_async_tx_descriptor *desc = NULL; - dma_cookie_t cookie; int ret; /* Request DMA RX channel */ @@ -1132,7 +1130,7 @@ static int stm32_of_dma_rx_probe(struct stm32_port *stm32port, desc->callback_param = NULL; /* Push current DMA transaction in the pending queue */ - cookie = dmaengine_submit(desc); + dmaengine_submit(desc); /* Issue pending DMA requests */ dma_async_issue_pending(stm32port->rx_ch);