From patchwork Thu Nov 2 11:34:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 117798 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp2046970qgn; Thu, 2 Nov 2017 04:35:55 -0700 (PDT) X-Google-Smtp-Source: ABhQp+TuRryj8ALvlCucEkYJ59+VHKvIlD1lHMTiaRBMLJvdbPyZ/D6uXgPvFhs/ofEMrBXnGHzX X-Received: by 10.99.63.199 with SMTP id m190mr3222207pga.187.1509622555752; Thu, 02 Nov 2017 04:35:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509622555; cv=none; d=google.com; s=arc-20160816; b=kjE8jiolu0OAWCe5AsNBs/H5AnY6hsjbBcMvmcvg6yZiQ8agn8+43KXXiFupVyO40x hKTiWMu55X0j23+ULTsTaJhV/GR+t7en9NiNg7SWZBxYTX1mR7IummMTRNmZM6I+YYNS AWDvYYYsR1kGjrMeBhv/1tvr8wIHHjpjHLkH1qQ+oipvAFzAbFsHQeOPmnaPjSyAtpqr YacaILlfzXRvFreNgn6c6AEC2m2g6OIpd9BvrIRgp44rH6LMiaxXa0uRhsw3xmoHQqSn gfmJJ1dQDaBeNUeuZu75PXZKvxNEHAEF6zJlvS2u550qnDmSS/eafwgt02eZ0K4RBtd0 Nogg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=BPHLG4Q9oOgx/bxFq3qPSxoGaUEuYBQhkcKsHxRySOE=; b=tdqSdU6Se7BlmxbU13fNB6pkhcfCS3BKJSLL5pTYjqlN+qHxrT96RUfZ9UY5YiGH/0 NbC6IonjqGf1WjZaMnZJW3Z4CE5JIxywAmoG4ltMRA+KmFXjR6Hx3gfonE8EA1UtLXWY A0CMboBn5OPr0AlithysT8lFKD/aRmkvafrz3O9rmdv5aD8S0TOwpUTVMUT/2P5WajGb yGvHVYyN23oDUS3BBh8IHvVPiTSpTtSFSSCI4KULoLj9Rdzx36L4tCEcCG5vRPpzHheI vI/tU1H8kX7NKXvvKG9z3tKMHglhKqPhMqWA/3/DQHdZAyWyOeGPo0HZA6M/5InyEcRn A84w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-serial-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p4si3349060pga.269.2017.11.02.04.35.55; Thu, 02 Nov 2017 04:35:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-serial-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-serial-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751098AbdKBLfy (ORCPT + 2 others); Thu, 2 Nov 2017 07:35:54 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:51478 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbdKBLfy (ORCPT ); Thu, 2 Nov 2017 07:35:54 -0400 Received: from wuerfel.lan ([109.193.157.232]) by mrelayeu.kundenserver.de (mreue004 [212.227.15.129]) with ESMTPA (Nemesis) id 0M1kaM-1dGt1l2qXC-00toGi; Thu, 02 Nov 2017 12:34:43 +0100 From: Arnd Bergmann To: Greg Kroah-Hartman , Jiri Slaby Cc: Arnd Bergmann , Miquel Raynal , Gregory CLEMENT , Allen Yan , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] serial: mvebu-uart: drop incorrect memset Date: Thu, 2 Nov 2017 12:34:24 +0100 Message-Id: <20171102113441.781447-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:UTJKianxvLGDOAgRQbq+A4MdPJqbLB1Spor4mjukrBfHQ1Rc2Lf qM5Mg04+/pnyz0P2NhCqkxEEeDgqMh2KpsMVmatd7LnrtzN/e6LC6dUCgpqA73xUrzACVnO 6mbpSUdecBsJl2U1VHG4bQRkj/auZQmj4nnf71TKiNvVcXD9M3330L0Z49uX6GZllXvsik9 WGAuoTwdKQORdbImjtIww== X-UI-Out-Filterresults: notjunk:1; V01:K0:j4SYjk/nL5k=:2kO2jliep/oAqlhjqLnW9N ru5Pk3Pp9S0bD64nnA2YQ5l3ZzpJapTc2jUVgX8+aGedQWtOBrxcofTYqqtf5OV8qwHpj8gom JlJ+brioJkE5sbtii8JKEHRLKFXQfhOc7/UOir46AEci2lwgw97V2XmRIS4P90B7tQ/CMQ/hN bPmulhtQGdfQ6chfJMQcTxbcGhCwGOoYIeCOIQauAee3hEcA9bmWF9Qevo/ksjP4fcYe3x5By YK63RZCj/UBx5c/qy+2Um9TycqZ+3hSHzsZEoHwXRTfPyE5WlM2MiKXGsoZvN7OlTNacBkKhi EvQ9OBLHyBBLL24R0LHdpp1/NH6SWKDhdZFljeP9d9fKbEvFiy95prDDmh7mmuqo1IjvmtXre MKs7Uf7h/KBI9UtGUgCXbnAXX6FxKYpSWjpdCtPyZpYS3JuoDQ2YSvtjMiQNSmXIpM+o+ldEU v9HWo2rAWufKQxbrR9+B9LzupsgrlyWR2rkDnfXgXC/36YM6cLdwz+uRscGrlOiBu81NyQk+o wKn4jCh335bgj5iXEtHkY0Z85IvUOVRVXagi8KM6cKStrfyUO+Vc+n24SVpX1D2KKjrTwdzI+ UsAnOz8LFx4cXQ6w2YpojgqKcoKLFdOJsXZmBJSZWGXrd8VQPuxQF7Jt+5CbmOryJYVNQQHBo OX3JwXo5mlB3WSZ1Nfsmn6tf3UYwaSrVVG9DkBPgP1bG5IAznAm6CFqValwWEqqNojPxHavC3 qmny9uInal7rVl9a/Mm6ijKmQ+6ZSg8cu4YZfQ== Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org gcc points out that the length passed into memset here is wrong: drivers/tty/serial/mvebu-uart.c: In function 'mvebu_uart_probe': arch/x86/include/asm/string_32.h:324:29: error: 'memset' used with length equal to number of elements without multiplication by element size [-Werror=memset-elt-size] Moreover, the structure was allocated with kzalloc a few lines earlier, so that memset is also unnecessary. Let's drop it to shut up the compiler warning. Fixes: 95f787685a22 ("serial: mvebu-uart: dissociate RX and TX interrupts") Signed-off-by: Arnd Bergmann --- drivers/tty/serial/mvebu-uart.c | 1 - 1 file changed, 1 deletion(-) -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c index 16b0a5aa14e2..85eb5c86d177 100644 --- a/drivers/tty/serial/mvebu-uart.c +++ b/drivers/tty/serial/mvebu-uart.c @@ -817,7 +817,6 @@ static int mvebu_uart_probe(struct platform_device *pdev) } /* Manage interrupts */ - memset(mvuart->irq, 0, UART_IRQ_COUNT); if (platform_irq_count(pdev) == 1) { /* Old bindings: no name on the single unamed UART0 IRQ */ irq = platform_get_irq(pdev, 0);