From patchwork Tue Mar 1 11:22:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 63302 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp1760409lbc; Tue, 1 Mar 2016 03:23:10 -0800 (PST) X-Received: by 10.98.34.205 with SMTP id p74mr6058513pfj.93.1456831390672; Tue, 01 Mar 2016 03:23:10 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id rt5si11162513pab.98.2016.03.01.03.23.10; Tue, 01 Mar 2016 03:23:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-serial-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-serial-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752548AbcCALXJ (ORCPT + 1 other); Tue, 1 Mar 2016 06:23:09 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:36903 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751984AbcCALXI (ORCPT ); Tue, 1 Mar 2016 06:23:08 -0500 Received: by mail-wm0-f42.google.com with SMTP id p65so28805082wmp.0 for ; Tue, 01 Mar 2016 03:23:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uG+ko7AH83lxyPocrL7whB79esRl4JMULFGRnyhvmRs=; b=GDvWkyD1j3yDLRub2VdVyEITKVK9WUd/ITl10Y/lGMo4rocd+iwQt+212rcYsdlTzD W5vcu9oT1TQWMAVF4wS8Smy41hC/XqZ9rJEWPQkvNipswFLH4hBJdVgm9W9+64WudWXA JUS302B69WHvuHjOijD4NlMVRBvBKdfjjC4SA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uG+ko7AH83lxyPocrL7whB79esRl4JMULFGRnyhvmRs=; b=bR+lG4+9n6rSqM0p/zFT0aSo7AJzbphPhMU16z+ZXARYFAu8YyIEw6jzEQA9vNJezD I9Vyh92z13citcOoINk0mjeJoJj08xPu2ZegdlDCbO5uolr0uP8Zsiu9ewXX2G2wjvI9 FSAO9JoXiUPjFgE7yRD9Plfu8TZ0Pzm5W4r44dfB/cx/XfRJCjQLN7p8Cpp5m+MDRjwd apyjM2KLHTDICPjHsnd/vRh0zc2607w/NGhIPSZ4xKJTqSNTLxd85y/gmEqC7OuVdJ84 QnxxxoQzHhR8WO4uXSiW6TZ160tsFnzGCPq28oEU/x3/oOnO//TNQzOqTMIbVGBst41/ uH8Q== X-Gm-Message-State: AD7BkJITZj+iNC1g2jNOkOngI77C3FsAYIzHUVgGiWPUl1ZTLN9fj9s3c7JztJ7xUfl9fYAq X-Received: by 10.28.68.86 with SMTP id r83mr3254822wma.73.1456831386696; Tue, 01 Mar 2016 03:23:06 -0800 (PST) Received: from localhost.localdomain (host-92-17-247-99.as13285.net. [92.17.247.99]) by smtp.gmail.com with ESMTPSA id j10sm30400485wjb.46.2016.03.01.03.23.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 01 Mar 2016 03:23:05 -0800 (PST) From: Srinivas Kandagatla To: Andy Gross , Stephen Boyd Cc: David Brown , Greg Kroah-Hartman , Jiri Slaby , linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH] tty: msm_serial: remove static clk rate setting in probe Date: Tue, 1 Mar 2016 11:22:53 +0000 Message-Id: <1456831373-14839-1-git-send-email-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org The issue with setting up a fixed clock rate at probe is that it would overwrite the console rate set by the bootloader for its console device. This would result in serial out corruption or missing log when we system is booted with earlycon. This is not a issue if we boot system without earlycon. This setup is ateast not required with the mainline driver. Originally the issue was noticed on DB410c which is based on APQ8016 chipset. Without this patch the console log with earlycon would look like: ... [ 0.000000] RCU: Adjusting geometry for rcu_fanout_leaf=64, nr_cpu_ids=1 [ 0.000000] NR_IRQS:64 nr_irqs:64 0 ����+HH��0.699378] console [ttyMSM0] enabled [ 0.699378] console [ttyMSM0] enabled [ 0.702003] bootconsole [uart0] disabled [ 0.702003] bootconsole [uart0] disabled ... with this patch I can see all the skipped lines on the console Signed-off-by: Srinivas Kandagatla --- drivers/tty/serial/msm_serial.c | 1 - 1 file changed, 1 deletion(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index dcde955..0a31b3e 100644 --- a/drivers/tty/serial/msm_serial.c +++ b/drivers/tty/serial/msm_serial.c @@ -1580,7 +1580,6 @@ static int msm_serial_probe(struct platform_device *pdev) if (IS_ERR(msm_port->pclk)) return PTR_ERR(msm_port->pclk); - clk_set_rate(msm_port->clk, 1843200); } port->uartclk = clk_get_rate(msm_port->clk);