From patchwork Tue Sep 16 22:16:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 37471 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f197.google.com (mail-lb0-f197.google.com [209.85.217.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9382120549 for ; Tue, 16 Sep 2014 22:17:08 +0000 (UTC) Received: by mail-lb0-f197.google.com with SMTP id p9sf288856lbv.8 for ; Tue, 16 Sep 2014 15:17:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=Hg6sWRFT6C5puMOakutOEKNLGnXu1uHDpy849tx0Ddg=; b=Wo2AHGAOLyKupNKepFSAvnx0sJnP7FkNN8prccOEJGupu4zq0TTD0U4l87LEYq72pI aMPRaWHf21mWnVewFQNgK3/r8j0f6km7xvG4BsAxiS6tpDjvv0mmkNxgLy/bAWUWJP9v Teya3pyYWz4kavS1t5jl0aOqKKSAjry94qqHCCpXCaveOYnfQ3sKW53DvdwbgKXlBl5J IrwRPqsNcarQA9CG+ESQyzgYDnsbiO3OnMcoAxmlDDLfggkzGIBjxXOWKlO59irdwvM1 VgwIu/fnhRM3vwgWsjVECYcHryFEDUVTZpECjQfWaU6/eThUY1KWfeivSznX1q0jwMM0 kUgg== X-Gm-Message-State: ALoCoQnXNkeYtbRzrt/FgbR2UammOgfoNH9OERtX2ncYYWvNzshFi5Y9DkZHzC6xqo1yn9NnMyTc X-Received: by 10.180.8.1 with SMTP id n1mr7165868wia.1.1410905827125; Tue, 16 Sep 2014 15:17:07 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.22.130 with SMTP id d2ls43185laf.98.gmail; Tue, 16 Sep 2014 15:17:06 -0700 (PDT) X-Received: by 10.152.23.69 with SMTP id k5mr20797280laf.70.1410905826879; Tue, 16 Sep 2014 15:17:06 -0700 (PDT) Received: from mail-lb0-f170.google.com (mail-lb0-f170.google.com [209.85.217.170]) by mx.google.com with ESMTPS id yr15si3616292lbb.62.2014.09.16.15.17.06 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 16 Sep 2014 15:17:06 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.170 as permitted sender) client-ip=209.85.217.170; Received: by mail-lb0-f170.google.com with SMTP id c11so721410lbj.29 for ; Tue, 16 Sep 2014 15:17:06 -0700 (PDT) X-Received: by 10.152.246.6 with SMTP id xs6mr40059639lac.56.1410905826427; Tue, 16 Sep 2014 15:17:06 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.130.169 with SMTP id of9csp480900lbb; Tue, 16 Sep 2014 15:17:05 -0700 (PDT) X-Received: by 10.70.135.40 with SMTP id pp8mr32498082pdb.116.1410905824900; Tue, 16 Sep 2014 15:17:04 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id tl10si9257257pac.46.2014.09.16.15.17.04 for ; Tue, 16 Sep 2014 15:17:04 -0700 (PDT) Received-SPF: none (google.com: linux-serial-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752905AbaIPWRD (ORCPT + 1 other); Tue, 16 Sep 2014 18:17:03 -0400 Received: from mail-pd0-f177.google.com ([209.85.192.177]:48773 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752842AbaIPWRC (ORCPT ); Tue, 16 Sep 2014 18:17:02 -0400 Received: by mail-pd0-f177.google.com with SMTP id y10so683320pdj.22 for ; Tue, 16 Sep 2014 15:17:01 -0700 (PDT) X-Received: by 10.67.1.195 with SMTP id bi3mr53367108pad.74.1410905821754; Tue, 16 Sep 2014 15:17:01 -0700 (PDT) Received: from localhost.localdomain.com (70-35-38-154.static.wiline.com. [70.35.38.154]) by mx.google.com with ESMTPSA id o4sm15033678pdh.56.2014.09.16.15.17.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Sep 2014 15:17:01 -0700 (PDT) From: Linus Walleij To: linux-serial@vger.kernel.org, Greg Kroah-Hartman Cc: Linus Walleij Subject: [PATCH] tty: sc16is7xx: remove retval from gpiochip_remove() Date: Tue, 16 Sep 2014 15:16:55 -0700 Message-Id: <1410905815-22970-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.9.3 Sender: linux-serial-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-serial@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linus.walleij@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.170 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , We are trying to smoke out the use of the return value from gpiochip_remove() from the kernel, this has been missed. Signed-off-by: Linus Walleij Acked-by: Greg Kroah-Hartman --- Greg, can you ACK this so I can merge it into the GPIO tree along with the removal of the actual return value. --- drivers/tty/serial/sc16is7xx.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 3284c31085a7..b534396b9568 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -1157,7 +1157,7 @@ static int sc16is7xx_probe(struct device *dev, #ifdef CONFIG_GPIOLIB if (devtype->nr_gpio) - WARN_ON(gpiochip_remove(&s->gpio)); + gpiochip_remove(&s->gpio); out_uart: #endif @@ -1176,11 +1176,8 @@ static int sc16is7xx_remove(struct device *dev) int i, ret = 0; #ifdef CONFIG_GPIOLIB - if (s->devtype->nr_gpio) { - ret = gpiochip_remove(&s->gpio); - if (ret) - return ret; - } + if (s->devtype->nr_gpio) + gpiochip_remove(&s->gpio); #endif for (i = 0; i < s->uart.nr; i++) {