From patchwork Wed Sep 5 05:00:11 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 11180 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 49AFB23E41 for ; Wed, 5 Sep 2012 05:03:00 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id C45F8A187CD for ; Wed, 5 Sep 2012 05:02:07 +0000 (UTC) Received: by mail-iy0-f180.google.com with SMTP id j25so169719iaf.11 for ; Tue, 04 Sep 2012 22:02:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=mFe70qptAEi04yxaCVqlt7Df2H9CaoxSLPKC9LM4MGc=; b=CSkq94OmUjJCeaNQ7hlBik+YbPyv0JCK7OOZaDq4VDqQ3/gcvd77vGDu9PncMYk0Ff IqabuR3zVrPjGnNFELxamyQ7cVHxmrA8jQWnuvClIoM1Trukz4ybYA6B1ih0imPdnamp vfOHCT+KhIfVNW1GKk9FJgvTtZo8+peH2GUrTXGVlK0lZIexPPkf2M72MC+ICY4ep4hx 0Iw9EOjchhPi8UjkyJeQrKCIr6FwCqKPRctfBWZfAKJc1ucRZ2Y0OlVKXER20Uo09HB/ lz76NAjcP6q+sFcN+6CGGndrDIXcebun2H4nxGmJjh7ENsQbq7/HT0SYypMwMRSB0cXm xUvw== Received: by 10.50.242.3 with SMTP id wm3mr4729464igc.0.1346821379668; Tue, 04 Sep 2012 22:02:59 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp231694igc; Tue, 4 Sep 2012 22:02:59 -0700 (PDT) Received: by 10.66.76.165 with SMTP id l5mr45959880paw.79.1346821378840; Tue, 04 Sep 2012 22:02:58 -0700 (PDT) Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com [209.85.160.50]) by mx.google.com with ESMTPS id px5si994815pbb.52.2012.09.04.22.02.58 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 04 Sep 2012 22:02:58 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pb0-f50.google.com with SMTP id md12so348984pbc.37 for ; Tue, 04 Sep 2012 22:02:58 -0700 (PDT) Received: by 10.68.229.73 with SMTP id so9mr52044864pbc.66.1346821378417; Tue, 04 Sep 2012 22:02:58 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id th6sm607991pbc.0.2012.09.04.22.02.55 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 04 Sep 2012 22:02:57 -0700 (PDT) From: Sachin Kamat To: linux-serial@vger.kernel.org Cc: alan@linux.intel.com, gregkh@linuxfoundation.org, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 2/2] serial: Samsung: Silence some checkpatch errors and warnings Date: Wed, 5 Sep 2012 10:30:11 +0530 Message-Id: <1346821211-23478-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1346821211-23478-1-git-send-email-sachin.kamat@linaro.org> References: <1346821211-23478-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQlvOuXoQwtJhfZ2ihC88wJO2GJNyKE0sFagT+ds+8HeqcMYBNgPJ6BxKlMggKUNsfWEsha5 Fixes the following errors and warnings: ERROR: trailing whitespace ERROR: return is not a function, parentheses are not required WARNING: suspect code indent for conditional statements (32, 36) Signed-off-by: Sachin Kamat --- drivers/tty/serial/samsung.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c index 8749a07..bdaa06f 100644 --- a/drivers/tty/serial/samsung.c +++ b/drivers/tty/serial/samsung.c @@ -82,7 +82,7 @@ static inline const char *s3c24xx_serial_portname(struct uart_port *port) static int s3c24xx_serial_txempty_nofifo(struct uart_port *port) { - return (rd_regl(port, S3C2410_UTRSTAT) & S3C2410_UTRSTAT_TXE); + return rd_regl(port, S3C2410_UTRSTAT) & S3C2410_UTRSTAT_TXE; } /* @@ -268,7 +268,7 @@ s3c24xx_serial_rx_chars(int irq, void *dev_id) dbg("break!\n"); port->icount.brk++; if (uart_handle_break(port)) - goto ignore_char; + goto ignore_char; } if (uerstat & S3C2410_UERSTAT_FRAME) @@ -1129,7 +1129,7 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, ourport->rx_irq = ret; ourport->tx_irq = ret + 1; } - + ret = platform_get_irq(platdev, 1); if (ret > 0) ourport->tx_irq = ret;