From patchwork Wed Sep 5 05:00:10 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 11179 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 7EDD923E41 for ; Wed, 5 Sep 2012 05:02:57 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id 096F5A187CB for ; Wed, 5 Sep 2012 05:02:04 +0000 (UTC) Received: by iafj25 with SMTP id j25so169719iaf.11 for ; Tue, 04 Sep 2012 22:02:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:x-gm-message-state; bh=//l0w8y96PhDKdPu9mSRBQAJwZzG/+nvR3b1YNXKCeI=; b=CGQfqblbgRK+PrlItED1rN4h7sYUQVS8/LJ/0dwUt5HvyQtrOQbjxC31zkR1Jm1WHt OVd2GwdHjOQG4gy9Gj+Q+64ZI/j07LDl9/HOI/a1WrB6+ElgwXCrVF7FrGXpnk5mmjoK A4oJHIUTqJ2Q4RhykSV4TC84cxQuIUPrHyknNxv91LiVqh5zrjr2B/x1rf21E1fqTLbU tdYpFgZB5YYAuY/Qi9semuNudb6jRL13R0TGvK2kumRmume/8pu/QSeEZajW0X2I3s6W GNKZBStCgWGAaN88pCtGYWL/uQnDmjGYP80xG16NjgztKhdckmgE/DKkdWXURWriscDX aexQ== Received: by 10.42.109.194 with SMTP id m2mr19746442icp.48.1346821376578; Tue, 04 Sep 2012 22:02:56 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp231692igc; Tue, 4 Sep 2012 22:02:56 -0700 (PDT) Received: by 10.66.77.40 with SMTP id p8mr46059750paw.78.1346821375786; Tue, 04 Sep 2012 22:02:55 -0700 (PDT) Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com [209.85.160.50]) by mx.google.com with ESMTPS id px5si994815pbb.52.2012.09.04.22.02.55 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 04 Sep 2012 22:02:55 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by pbcmd12 with SMTP id md12so348984pbc.37 for ; Tue, 04 Sep 2012 22:02:55 -0700 (PDT) Received: by 10.68.193.194 with SMTP id hq2mr51863371pbc.93.1346821375402; Tue, 04 Sep 2012 22:02:55 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id th6sm607991pbc.0.2012.09.04.22.02.52 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 04 Sep 2012 22:02:54 -0700 (PDT) From: Sachin Kamat To: linux-serial@vger.kernel.org Cc: alan@linux.intel.com, gregkh@linuxfoundation.org, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/2] serial: Samsung: Replace printk with dev_* functions Date: Wed, 5 Sep 2012 10:30:10 +0530 Message-Id: <1346821211-23478-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQm1igW9qJLgd6gTOku09wEq5c10XDYvJX3vCEBwbE75lI/VQJokW0ys/Mbr4XqZTuuDViu3 Silences checkpatch warnings regarding use of printks. Signed-off-by: Sachin Kamat --- drivers/tty/serial/samsung.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c index 5c5e7e0..8749a07 100644 --- a/drivers/tty/serial/samsung.c +++ b/drivers/tty/serial/samsung.c @@ -459,7 +459,7 @@ static int s3c24xx_serial_startup(struct uart_port *port) s3c24xx_serial_portname(port), ourport); if (ret != 0) { - printk(KERN_ERR "cannot get irq %d\n", ourport->rx_irq); + dev_err(port->dev, "cannot get irq %d\n", ourport->rx_irq); return ret; } @@ -473,7 +473,7 @@ static int s3c24xx_serial_startup(struct uart_port *port) s3c24xx_serial_portname(port), ourport); if (ret) { - printk(KERN_ERR "cannot get irq %d\n", ourport->tx_irq); + dev_err(port->dev, "cannot get irq %d\n", ourport->tx_irq); goto err; } @@ -502,7 +502,7 @@ static int s3c64xx_serial_startup(struct uart_port *port) ret = request_irq(port->irq, s3c64xx_serial_handle_irq, IRQF_SHARED, s3c24xx_serial_portname(port), ourport); if (ret) { - printk(KERN_ERR "cannot get irq %d\n", port->irq); + dev_err(port->dev, "cannot get irq %d\n", port->irq); return ret; } @@ -543,7 +543,7 @@ static void s3c24xx_serial_pm(struct uart_port *port, unsigned int level, break; default: - printk(KERN_ERR "s3c24xx_serial: unknown pm %d\n", level); + dev_err(port->dev, "s3c24xx_serial: unknown pm %d\n", level); } } @@ -1038,7 +1038,7 @@ static int s3c24xx_serial_cpufreq_transition(struct notifier_block *nb, termios = &tty->termios; if (termios == NULL) { - printk(KERN_WARNING "%s: no termios?\n", __func__); + dev_warn(uport->dev, "%s: no termios?\n", __func__); goto exit; } @@ -1113,7 +1113,7 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, res = platform_get_resource(platdev, IORESOURCE_MEM, 0); if (res == NULL) { - printk(KERN_ERR "failed to find memory resource for uart\n"); + dev_err(port->dev, "failed to find memory resource for uart\n"); return -EINVAL; } @@ -1683,7 +1683,7 @@ static int __init s3c24xx_serial_modinit(void) ret = uart_register_driver(&s3c24xx_uart_drv); if (ret < 0) { - printk(KERN_ERR "failed to register UART driver\n"); + pr_err("Failed to register Samsung UART driver\n"); return -1; }