| Message ID | 20250226-printk-renaming-v1-0-0b878577f2e6@suse.com |
|---|---|
| Headers | show |
| Series | printk: renaming some suspend/resume functions and one fix for unblanking | expand |
On 2025-02-26, Marcos Paulo de Souza <mpdesouza@suse.com> wrote: > Hello, I've being working on some patches that help to clarify the suspend/resume > of printk machinery. The last patch on this patchset address one issue regarding > suspended consoles and blanking. > > This is a part one patchset that I would like to see merged before I send more patches > that will rework the suspend flag (a global suspend flag istead of per console) and > the removal of CON_ENABLED flag later on (I've created a function that will forcibly) > register the console instead of using this flag. > > Please review! > > Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> The series looks good (adding the spellchecking that Jiri mentioned). Thanks! Reviewed-by: John Ogness <john.ogness@linutronix.de> I think it is worth mentioning that the series was motivated by this [0] discussion. And since I just mentioned it, that is probably mention enough. ;-) John Ogness [0] https://lore.kernel.org/lkml/ZyoNZfLT6tlVAWjO@pathway.suse.cz
On Tue 2025-03-11 11:38:00, Petr Mladek wrote: > On Wed 2025-02-26 16:59:00, Marcos Paulo de Souza wrote: > > Hello, I've being working on some patches that help to clarify the suspend/resume > > of printk machinery. The last patch on this patchset address one issue regarding > > suspended consoles and blanking. > > > > This is a part one patchset that I would like to see merged before I send more patches > > that will rework the suspend flag (a global suspend flag istead of per console) and > > the removal of CON_ENABLED flag later on (I've created a function that will forcibly) > > register the console instead of using this flag. > > > > Please review! > > > > Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> > > Looks good to me. I could fix the typos when pushing. > > Well, there is one more thing. It seems that the simple graphic logger > was merged for 6.14-rc1. And the console_stop()/console_start() API > is used also in drivers/gpu/drm/clients/drm_log.c. > > It is actually the code which motivated this rename, as already > pointed out by John, see > https://lore.kernel.org/lkml/ZyoNZfLT6tlVAWjO@pathway.suse.cz/ > > Well, I am going to update these two locations when pushing this > as well. Let's just get this change done. And I did as mentioned above. JFYI, the patcheset has been committed into printk/linux.git, branch for-6.15-console-suspend-api-cleanup. Best Regards, Petr
Hello, I've being working on some patches that help to clarify the suspend/resume of printk machinery. The last patch on this patchset address one issue regarding suspended consoles and blanking. This is a part one patchset that I would like to see merged before I send more patches that will rework the suspend flag (a global suspend flag istead of per console) and the removal of CON_ENABLED flag later on (I've created a function that will forcibly) register the console instead of using this flag. Please review! Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> --- Marcos Paulo de Souza (5): printk: Rename suspend_console to console_suspend_all printk: Rename resume_console to console_resume_all printk: Rename console_stop to console_suspend printk: Rename console_start to console_resume printk: Check CON_SUSPEND when unblanking a console drivers/tty/serial/serial_core.c | 6 ++--- include/linux/console.h | 8 +++--- kernel/kexec_core.c | 4 +-- kernel/power/hibernate.c | 16 ++++++------ kernel/power/suspend.c | 8 +++--- kernel/printk/printk.c | 30 ++++++++++++++-------- .../pm-graph/config/custom-timeline-functions.cfg | 4 +-- tools/power/pm-graph/sleepgraph.py | 6 ++--- 8 files changed, 46 insertions(+), 36 deletions(-) --- base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04 change-id: 20250225-printk-renaming-126c1a11ad7a Best regards,