mbox series

[v3,0/4] Add initial support for Rockchip RK3528 SoC

Message ID 20240814155014.18097-1-ziyao@disroot.org
Headers show
Series Add initial support for Rockchip RK3528 SoC | expand

Message

Yao Zi Aug. 14, 2024, 3:50 p.m. UTC 
Rockchip RK3528 is a quad-core ARM Cortex-A53 SoC designed for
multimedia application. This series add a basic device tree with CPU,
interrupts and UART nodes for it and is able to boot into a kernel with
only UART console.

Has been tested on Radxa E20C board[1] with vendor U-boot, successfully
booted into initramfs with this log[2].

[1]: https://docs.radxa.com/en/e/e20c
[2]: https://gist.github.com/ziyao233/b74523a1e3e8bf36286a572e008ca319

Changed from v2:
- fix fixed-clock nodename
https://lore.kernel.org/all/20240811140725.64866-1-ziyao@disroot.org/

Changed from v1:
- fix stdout-path
- style improvements
https://lore.kernel.org/all/20240803125510.4699-2-ziyao@disroot.org/

Yao Zi (4):
  dt-bindings: serial: snps-dw-apb-uart: Document Rockchip RK3528
  dt-bindings: arm: rockchip: Add Radxa E20C board
  arm64: dts: rockchip: Add base DT for rk3528 SoC
  arm64: dts: rockchip: Add Radxa e20c board

 .../devicetree/bindings/arm/rockchip.yaml     |   5 +
 .../bindings/serial/snps-dw-apb-uart.yaml     |   1 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3528-radxa-e20c.dts   |  22 +++
 arch/arm64/boot/dts/rockchip/rk3528.dtsi      | 182 ++++++++++++++++++
 5 files changed, 211 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3528.dtsi

Comments

Heiko Stuebner Aug. 16, 2024, 6:45 a.m. UTC | #1 
Am Freitag, 16. August 2024, 08:39:38 CEST schrieb Yao Zi:
> On Thu, Aug 15, 2024 at 06:43:20PM +0200, Heiko Stübner wrote:
> > Hi,
> > 
> > Am Mittwoch, 14. August 2024, 17:50:13 CEST schrieb Yao Zi:
> > > This initial device tree describes CPU, interrupts and UART on the chip
> > > and is able to boot into basic kernel with only UART. Cache information
> > > is omitted for now as there is no precise documentation. Support for
> > > other features will be added later.
> > > 
> > > Signed-off-by: Yao Zi <ziyao@disroot.org>
> > 
> > not sure if you have seen Krzysztof's comment yesterday, that he found
> > the soc node getting documented in 2019 [0].
> 
> Oops, I don't read that before sending the series.

no worries, I think both mails (the linked on and your v3) happened at 
nearly the same time on wednesday.


> > I guess that counts as a strong suggestion. Not sure how you're feeling
> > about that, but I guess we could move to that scheme for new socs.
> > 
> > So would you be willing to move the mmio-devices to a soc node?
> > (stuff with mmio addresses in the node name)
> 
> I'm willing to, there will be patch v4.

thanks a lot :-)

Heiko