From patchwork Thu Jan 18 15:21:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugo Villeneuve X-Patchwork-Id: 765093 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E59228DA0; Thu, 18 Jan 2024 15:22:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=162.243.120.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705591344; cv=none; b=G99R5mM3c5v7N/yXu8kkgsqUokXUKSXqp+sjzfb8M/Ozf4ox0SbU5646zULD7K7g1wt11IMawe/6EkmjKq9/zKbmW1I1bub3/qtPuChoILXapt3izaQAZME3levYod4C578UbrY8WNeZH6sK7601bx7o60tFPsB6ErUf1kgDxj8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705591344; c=relaxed/simple; bh=XrMh+efgRmXscdLLtXKdvP3SscB/ZReuo5yJtjd17UE=; h=DKIM-Signature:Received:From:To:Cc:Date:Message-Id:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding: X-SA-Exim-Connect-IP:X-SA-Exim-Mail-From:X-Spam-Checker-Version: X-Spam-Level:X-Spam-Report:X-Spam-Status:Subject:X-SA-Exim-Version: X-SA-Exim-Scanned; b=FkpwfIupNju3AklNbLhgLd3W32oVp8EgPz5/xS+UQU8BB4Fr7F97vE+jztyPyNtYIFeqHAcdHDzCRDXpyRz9ZNeK6KiLSUkdlyNgR/z4VXWIo8CdJncH2mmBgaui2nThq60JHuejr2LAlZTWChUVzbh31RnP9s6PQuBon3EzFpk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=hugovil.com; spf=pass smtp.mailfrom=hugovil.com; dkim=pass (1024-bit key) header.d=hugovil.com header.i=@hugovil.com header.b=ibyFs1er; arc=none smtp.client-ip=162.243.120.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=hugovil.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hugovil.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=hugovil.com header.i=@hugovil.com header.b="ibyFs1er" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Cc:To :From:subject:date:message-id:reply-to; bh=er1H90D5sP8lfkMr5k8Dh47duGczbyoDoZ6NN0eRzRU=; b=ibyFs1erUbd0OMdmtdHBEhyT+Z jTASvyYqXUZ0KGEs2kNnyNr2TuR9GNFKqs7cK46IJN5Gq9pWodUigfKYwEdNhnh6+G/HMKRmwzzHy +eh2C1tpLnqvtVyoImPbds9lCasalU4cbBLBhshk6QZZq5b5QJK3oWrzMZYe+wgw/luk=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:57058 helo=pettiford.lan) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1rQUDh-0002lf-31; Thu, 18 Jan 2024 10:22:17 -0500 From: Hugo Villeneuve To: gregkh@linuxfoundation.org, jirislaby@kernel.org, cosmin.tanislav@analog.com, andy.shevchenko@gmail.com, shc_work@mail.ru Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, hugo@hugovil.com, Hugo Villeneuve Date: Thu, 18 Jan 2024 10:21:56 -0500 Message-Id: <20240118152213.2644269-1-hugo@hugovil.com> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Level: X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * -0.0 T_SCC_BODY_TEXT_LINE No description available. Subject: [PATCH v2 00/17] serial: max310x: cleanups and improvements X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) From: Hugo Villeneuve Hello, this patch series brings a few clean-ups and improvements to the max310x driver. Some of these changes are based on suggestions for the sc16is7xx driver by Andy Shevchenko following this discussion: Link: https://lore.kernel.org/all/CAHp75VebCZckUrNraYQj9k=Mrn2kbYs1Lx26f5-8rKJ3RXeh-w@mail.gmail.com/ The changes have been tested on a custom board using a max14830 in SPI mode, with an external oscillator (not crystal). Tests included a simple communication test with a GPS connected to UART0. They also have been tested by using i2c-stub to simulate the four ports on a virtual I2C max14830 device, but with obvious limitations as this cannot simulate all the hardware functions. Thank you. Link: [v1] https://lore.kernel.org/all/20240117223856.2303475-1-hugo@hugovil.com Changes for V2: - Drop patch "serial: max310x: replace ENOTSUPP with preferred EOPNOTSUPP (checkpatch)" - Fix cover letter typo - Add Andy Shevchenko Suggested-by and Reviewed-by tags for selected patches Hugo Villeneuve (17): serial: max310x: fix NULL pointer dereference in I2C instantiation serial: max310x: add I2C device table for instantiation from userspace serial: max310x: use i2c_get_match_data() serial: max310x: use spi_get_device_match_data() serial: max310x: fix syntax error in IRQ error message serial: max310x: remove holes in struct max310x_devtype serial: max310x: add macro for max number of ports serial: max310x: use separate regmap name for each port serial: max310x: simplify probe() and remove() error handling serial: max310x: add explicit return for some switch default cases serial: max310x: use dev_err_probe() instead of dev_err() serial: max310x: replace hardcoded masks with preferred GENMASK() serial: max310x: use common detect function for all variants serial: max310x: use common power function for all variants serial: max310x: replace bare use of 'unsigned' with 'unsigned int' (checkpatch) serial: max310x: reformat and improve comments serial: max310x: fix indentation drivers/tty/serial/max310x.c | 327 ++++++++++++++++++----------------- 1 file changed, 164 insertions(+), 163 deletions(-) base-commit: 0c84bea0cabc4e2b98a3de88eeb4ff798931f056