From patchwork Sat Dec 9 12:58:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lino Sanfilippo X-Patchwork-Id: 752455 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=kunbus.com header.i=@kunbus.com header.b="L1aHeqHs" Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2043.outbound.protection.outlook.com [40.107.7.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61AD610D0; Sat, 9 Dec 2023 04:59:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P2ATX3KvYqafdrFZ8hAPo7RhIXR01Ael7YSTgBz/iAnYTrkPC+LSAJ24efq0I4dDlGdD42uXxlmPBkYOvSm2Kg71SIv0EpVbkcD2/HbuvcuaIyUgd9UdmPhrsHltMMkK4UVn13NVwcGKoxd/U6Vh7P2Me78Ci/sq3IR00oNeXw1KzXw0NyOh+sD00n31wgHRzkg41OlX9SU89Hxcjk51fR+m1xgNt9awJsZ3pvYX7LKb2kmWNB+m+UkBJtSq76fhbXCVIpK3iVqOAYqQOzyvA1urKhmElKTHjmUpjh1EG8u/PJ/j+FL26gHi0eeIYji0Xy97ePizdvsWV/MnrNYvdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/19jT5xjHvyfQoWOMyzF+oUc7qc5rYYEI2f2qQd3w3Y=; b=naxSZGDjjo1WubhnAXyEwNJ2lFSmvyNaSQbw2y3cLakaeNra+x0NI2wSTKdDjnuT9AHnZlEWBICGTDIhghr3uyIbd9wQhOJCAi6k7xHK2xe0ZDEc/71pSeKZwSKZgB0X9bE7E9YppKaus4PuTLQJDYMvS0tCcSJJwkGWChMSGrHPbaJx5S/gGuOTfqzXgEjeF0Uv7E90NKP//yhWA2EIGt5X1AcVehkQ695FLvPHPpNpbleFVuI80itxfizm9TvE5z0CMMEP/rMVizByguqVA9+5rVkq/hzvQVBcJ2/IExGQyquPJScrRQZZkFdJISTSLjA758No51gj7AbAjckrTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kunbus.com; dmarc=pass action=none header.from=kunbus.com; dkim=pass header.d=kunbus.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kunbus.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/19jT5xjHvyfQoWOMyzF+oUc7qc5rYYEI2f2qQd3w3Y=; b=L1aHeqHszH8rcv6xq9c8cbCcXwwL2e8Tuv5varUilNWDK7uZ0cPd2lzxgVElIaPZEjlr1rizXG14zRriAHgt3OsATR5DNJq1jfIwF5hmldhdE6eUnTiCb2sAgyFh97U2akJi8TWPPyKJxnFoqDK3f4XjPLtinEd6Iu7Uf3mhDSY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kunbus.com; Received: from VI1P193MB0413.EURP193.PROD.OUTLOOK.COM (2603:10a6:803:4e::14) by PR3P193MB0555.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:31::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.29; Sat, 9 Dec 2023 12:59:16 +0000 Received: from VI1P193MB0413.EURP193.PROD.OUTLOOK.COM ([fe80::653f:d0f3:e7f6:8c06]) by VI1P193MB0413.EURP193.PROD.OUTLOOK.COM ([fe80::653f:d0f3:e7f6:8c06%5]) with mapi id 15.20.7068.029; Sat, 9 Dec 2023 12:59:16 +0000 From: Lino Sanfilippo To: gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com Cc: u.kleine-koenig@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, cniedermaier@dh-electronics.com, hugo@hugovil.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, LinoSanfilippo@gmx.de, lukas@wunner.de, p.rosenberger@kunbus.com, Lino Sanfilippo Subject: [PATCH v5 0/7] Fixes and improvements for RS485 Date: Sat, 9 Dec 2023 13:58:29 +0100 Message-ID: <20231209125836.16294-1-l.sanfilippo@kunbus.com> X-Mailer: git-send-email 2.42.0 X-ClientProxiedBy: FR3P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::22) To VI1P193MB0413.EURP193.PROD.OUTLOOK.COM (2603:10a6:803:4e::14) Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1P193MB0413:EE_|PR3P193MB0555:EE_ X-MS-Office365-Filtering-Correlation-Id: 105869ad-628a-40c6-787e-08dbf8b6a622 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iFxsNEPVgTmWCAjfnLESy2HdSTkltn/SX3Cf5WwjXag5kqwtNdRf3iKboeyHeQSDLi0aV7L1A7S09I9NgZOAJoSzOKRvZZyxPfz26ZNg8mTVXW8NTheqHDeispmfl+vnk6C+XMnlXL4aB8ZLJc5iwziZdEPO58t0kdrc4fK/oMuQFIqIHtEV65MmMaVUMDpLo86ZdKtBdEwciZR9P2WyQYMFmn+MbmrUN863IJTUhf1M78zAuTxtiY0CgmYUDlhbvY5U2+0qIBkUlnk0bdbJhTi0pficSDNXAR2vvexQeONKYgBfJSJk529yd0e0URCX+u45g3g/+CLs5YId6sf3neBcuFnofcCj10jmdIGBIsIJY86dlzlhrRLiH3kuT5LOu3/JlBeL1CL9kk0o/xPDJveSczrLrP1+1QIZHfpuKBXzXtxjXN3/oFn/1DsKfN+XocA+4TcRnFMB5NTHa8heVwx35G5yp31CdMCv0vaTj4vK4s0esBE9BCssvvwbUslSyHIudO35hEPjzWqIIcDbz2msA6vEfL+mpEQq7R5hx17fcyzfWyA+JiyHoiSXyeWa X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1P193MB0413.EURP193.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(39830400003)(366004)(376002)(396003)(346002)(136003)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(2616005)(107886003)(1076003)(478600001)(6506007)(6666004)(52116002)(6512007)(41300700001)(83380400001)(5660300002)(2906002)(4326008)(8676002)(8936002)(7416002)(6486002)(66946007)(316002)(66476007)(66556008)(38100700002)(86362001)(36756003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?vU5aTOf3qMWfktodbxbOaQY8hJPc?= =?utf-8?q?7E0ukDYWtehhyZ2pNJb3o2J216ELU2INdQfZDKLqL2yKdN3slxcRX1kS8AN7bFW0Y?= =?utf-8?q?PvqAG695zmCAeE9ndkpXleDNSFRzg67OexvX5iju6cJhGtL2RIroW8tzeZbk54NWK?= =?utf-8?q?1I/uyNnF7HKSo3653UD0kcRhaVO1ArLPj/I87YjyAK/qs+Wh7Ai/cNqlhzujRIVos?= =?utf-8?q?bbwsKu6lI6eRHIUU8NRpSbaNdDvz5wN4yrT4Ep2a55Hn5c58bCQ7mPb07L6ydrwcf?= =?utf-8?q?UpbfuI7as+enYR6A0/euOi4JlEgFyvOit1C9JTxVwnrWj6U0A3bJxfS9F2+m8SJPs?= =?utf-8?q?mn0p/3NQSWuJlqkWtUhwWh+/TLS0yp3BGoOIXqdwkhOaR1M1L2RRrU03quOqBMGtB?= =?utf-8?q?9MBgPH12R7yURyjiddQJtMst+G+fLYF3Rmv80e83ZlDO8Fe7mJTeNKSPsi580ShmN?= =?utf-8?q?VaBpRXJQpargin8rwcs8r0X2EvkxADKYiUBnJOtOFvUpYlI1OmKeBwoASU+GenxE8?= =?utf-8?q?qJ6Ra925VgR1X/xSt+8jDsgE2oqwyKUiFBQQh6YhAs3vzN95ACKvCsJxMy56bnO/l?= =?utf-8?q?Z8jb5cdpcGAJGKurib8VCvuu7rpNWnWjrGraRAY8SFVKqmk5fbOrvqbyNJD6LePkL?= =?utf-8?q?WECxVnapmNhzYqLttnwuPyI7lslswFxghFvTZt/Lhz8oCNo0ERTr4Fsz3YAo6reo/?= =?utf-8?q?z6FD2Y1RI8HA+JU8iuJX1TfBL880BA3g22w6uQoC9q9DVP855rFfztEedX2bseu5l?= =?utf-8?q?GEPcuEpCqnPsUtGPKdylIQi47Bt+u7T6dITblX+6Bzjkst+weKgJkxkygZBbaU8Ih?= =?utf-8?q?6GQXzLGOa9IvY7ipz7Tj/Hy2Wa7LZe/xA9EddR+6qMl7wPVGjNV5Wvr8lfEoA6Zcy?= =?utf-8?q?dTJgEGlGKaXF0lBO4zoIGNXsn7mYKAMdprpmTF0hVr7mm5xAa2q3y+gzZnfPSxnjW?= =?utf-8?q?RNuGmxyBxcJbNcVSVmukHAwI346PN406gh7erHfC8mjdGiSuS79nI498sYWHe0y8N?= =?utf-8?q?5e3bg+S8s2rFuzpDFXFlD6fPovBF6KC9hGuKF4hzyLeiYyeUpGgXtWSQU0ft4KlwZ?= =?utf-8?q?x821Iq4+6eBfJR5vV3GLlXxVuLz9x8NijVa1zneeBw7AtpI47eo73RhG8bG1BgbzF?= =?utf-8?q?JaBHnSi9UJwWVfhr7R0k38z+303j1mAu0BHEhW7Q10SS0ukqZ5YmiARHmpum55HTV?= =?utf-8?q?zSp5yxZHFv1WrOJbpxV3mS0gTmr4PlvOQwpOzuipEAOKv2RElCWnEgBnrWaoZwAQn?= =?utf-8?q?YLr+rGEDWUdsg9eX1GOjsRtZ/eWd7wjxr23aFPPNxwQvrDDHrtH/SWP1/xJbappN/?= =?utf-8?q?tcObsUsIRclnFS8P99w4+BUC919LVWzTrF403shxDJuudzXHn+b+lwfYVCOQjiy2E?= =?utf-8?q?tEMvkSux9BxMFMC+K0gZ3aZEi+4xUK1KJ2h/9XkiTyJm+7Booyw7wTv8gdSvXfTAO?= =?utf-8?q?BweqtYJEcpYk2MaieU70u6fiSS53QGWqSM81UDxRyT/gR6ZioDB4Ik3yVF1/p4JzQ?= =?utf-8?q?ZIN5A1teOh2gC+g3AKqRS9buKFDSo8fIj/7RlK3xX/m9iCqiem9+zeeb3ZYfiefHz?= =?utf-8?q?6zC9vi4X9cl?= X-OriginatorOrg: kunbus.com X-MS-Exchange-CrossTenant-Network-Message-Id: 105869ad-628a-40c6-787e-08dbf8b6a622 X-MS-Exchange-CrossTenant-AuthSource: VI1P193MB0413.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2023 12:59:16.0334 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: aaa4d814-e659-4b0a-9698-1c671f11520b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZtXSs9145kxchKQ4hZzor4p0ZmwgZq64zrI0ppw7Lx9hRZrj4Db7SOlDSb/Ea5y7pxABNafV/+134+MHBo4H5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P193MB0555 The following series includes some fixes and improvements around RS485 in the serial core and UART drivers: Patch 1: Do not hold the port lock when setting rx-during-tx GPIO Patch 2: set missing supported flag for RX during TX GPIO Patch 3: fix sanitizing check for RTS settings Patch 4: make sure RS485 is cannot be enabled when it is not supported Patch 5: imx: do not set RS485 enabled if it is not supported Patch 6: omap: do not override settings for rs485 support Patch 7: exar: set missing RS485 supported flag Changes in v5: - do not combine the functions that the RS484 GPIOs (as Hugo originally suggested) Changes in v4: - add comment for function uart_set_rs485_gpios after hint from Hugo - correct commit message as pointed out by Hugo - rephrase commit messages - add patch 7 after discussion with Ilpo Changes in v3 - Drop patch "Get rid of useless wrapper pl011_get_rs485_mode()" as requested by Greg Changes in v2: - add missing 'Fixes' tags as requested by Greg - corrected a typo as pointed out by Hugo - fix issue in imx driver in the serial core as suggested by Uwe - partly rephrase some commit messages - add patch 7 Lino Sanfilippo (7): serial: Do not hold the port lock when setting rx-during-tx GPIO serial: core: set missing supported flag for RX during TX GPIO serial: core: fix sanitizing check for RTS settings serial: core: make sure RS485 cannot be enabled when it is not supported serial: core, imx: do not set RS485 enabled if it is not supported serial: omap: do not override settings for RS485 support serial: 8250_exar: Set missing rs485_supported flag drivers/tty/serial/8250/8250_exar.c | 5 +-- drivers/tty/serial/imx.c | 8 ----- drivers/tty/serial/omap-serial.c | 8 ++--- drivers/tty/serial/serial_core.c | 50 ++++++++++++++++++++++------- drivers/tty/serial/stm32-usart.c | 5 +-- 5 files changed, 47 insertions(+), 29 deletions(-) base-commit: 33cc938e65a98f1d29d0a18403dbbee050dcad9a Reviewed-by: Hugo Villeneuve