mbox series

[v2,0/1] Add Sifive uart suspend and resume

Message ID 20230809135042.2443350-1-nick.hu@sifive.com
Headers show
Series Add Sifive uart suspend and resume | expand

Message

Nick Hu Aug. 9, 2023, 1:50 p.m. UTC 
Add Sifive uart suspend and resume functions for system suspend.

Changes in v2:
- Change Signed-off-by: Ben Dooks to Reviewed-by: Ben Dooks
- Remove the unnecessary check

Nick Hu (1):
  serial: sifive: Add suspend and resume operations

 drivers/tty/serial/sifive.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Comments

Greg Kroah-Hartman Aug. 11, 2023, 7:11 p.m. UTC | #1 
On Wed, Aug 09, 2023 at 09:50:41PM +0800, Nick Hu wrote:
> Add Sifive uart suspend and resume functions for system suspend.
> 
> Changes in v2:
> - Change Signed-off-by: Ben Dooks to Reviewed-by: Ben Dooks
> - Remove the unnecessary check
> 
> Nick Hu (1):
>   serial: sifive: Add suspend and resume operations
> 
>  drivers/tty/serial/sifive.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> -- 
> 2.34.1
> 

Does not apply to my tree :(
Nick Hu Aug. 14, 2023, 5:55 a.m. UTC | #2 
Hi Greg

On Sat, Aug 12, 2023 at 3:11 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Wed, Aug 09, 2023 at 09:50:41PM +0800, Nick Hu wrote:
> > Add Sifive uart suspend and resume functions for system suspend.
> >
> > Changes in v2:
> > - Change Signed-off-by: Ben Dooks to Reviewed-by: Ben Dooks
> > - Remove the unnecessary check
> >
> > Nick Hu (1):
> >   serial: sifive: Add suspend and resume operations
> >
> >  drivers/tty/serial/sifive.c | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >
> > --
> > 2.34.1
> >
>
> Does not apply to my tree :(
Is there any reason that it doesn't apply to your tree?
Which tree should I go?
Greg Kroah-Hartman Aug. 14, 2023, 6:02 a.m. UTC | #3 
On Mon, Aug 14, 2023 at 01:55:58PM +0800, Nick Hu wrote:
> Hi Greg
> 
> On Sat, Aug 12, 2023 at 3:11 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Aug 09, 2023 at 09:50:41PM +0800, Nick Hu wrote:
> > > Add Sifive uart suspend and resume functions for system suspend.
> > >
> > > Changes in v2:
> > > - Change Signed-off-by: Ben Dooks to Reviewed-by: Ben Dooks
> > > - Remove the unnecessary check
> > >
> > > Nick Hu (1):
> > >   serial: sifive: Add suspend and resume operations
> > >
> > >  drivers/tty/serial/sifive.c | 18 ++++++++++++++++++
> > >  1 file changed, 18 insertions(+)
> > >
> > > --
> > > 2.34.1
> > >
> >
> > Does not apply to my tree :(
> Is there any reason that it doesn't apply to your tree?
> Which tree should I go?

Which tree did you make it against?  It doesn't apply due to conflicts.
Perhaps either regenerate it against the tty-next branch of the tty.git
tree, or linux-next?

thanks,

greg k-h
Nick Hu Aug. 14, 2023, 8:12 a.m. UTC | #4 
Hi Greg

On Mon, Aug 14, 2023 at 2:02 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Mon, Aug 14, 2023 at 01:55:58PM +0800, Nick Hu wrote:
> > Hi Greg
> >
> > On Sat, Aug 12, 2023 at 3:11 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Wed, Aug 09, 2023 at 09:50:41PM +0800, Nick Hu wrote:
> > > > Add Sifive uart suspend and resume functions for system suspend.
> > > >
> > > > Changes in v2:
> > > > - Change Signed-off-by: Ben Dooks to Reviewed-by: Ben Dooks
> > > > - Remove the unnecessary check
> > > >
> > > > Nick Hu (1):
> > > >   serial: sifive: Add suspend and resume operations
> > > >
> > > >  drivers/tty/serial/sifive.c | 18 ++++++++++++++++++
> > > >  1 file changed, 18 insertions(+)
> > > >
> > > > --
> > > > 2.34.1
> > > >
> > >
> > > Does not apply to my tree :(
> > Is there any reason that it doesn't apply to your tree?
> > Which tree should I go?
>
> Which tree did you make it against?  It doesn't apply due to conflicts.
> Perhaps either regenerate it against the tty-next branch of the tty.git
> tree, or linux-next?
>
> thanks,
>
> greg k-h
I'm using the mainline linux kernel.
Thanks for the information.
I can reproduce it in tty-next branch of the tty.git!
I'll fix it in v3.

Regards,
Nick