From patchwork Tue Jul 25 05:42:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 706540 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA028C00528 for ; Tue, 25 Jul 2023 05:42:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229483AbjGYFma (ORCPT ); Tue, 25 Jul 2023 01:42:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229562AbjGYFm3 (ORCPT ); Tue, 25 Jul 2023 01:42:29 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3095B1990; Mon, 24 Jul 2023 22:42:27 -0700 (PDT) Received: from hillo.muru.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTP id AA5E98176; Tue, 25 Jul 2023 05:42:25 +0000 (UTC) From: Tony Lindgren To: Greg Kroah-Hartman , Jiri Slaby Cc: Andy Shevchenko , Dhruva Gole , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: [PATCH v5 0/3] Serial core controller port device name fixes Date: Tue, 25 Jul 2023 08:42:09 +0300 Message-ID: <20230725054216.45696-1-tony@atomide.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org A few issues have been found with device naming for the serial core controller port device. These issues currently mostly affect the output for /sys/bus/serial-base/devices, but need to be also fixed to avoid port addressing issues later on. Changes since v4: - Make the sysfs device names nicer with DEVNAME:0.0 naming, the "ctrl" and "port" prefixes are not needed with the controller id in the name - Fix Andy's Reviewed-by as noted by Andy - Generate patches with --patience to make the last patch more readable Changes since v3: - Drop unnecessary else on the return path in serial_base_device_init() as noted by Andy - Add Andy's Reviewed-by - Update patch description for port_id instead of port port_id for the first patch Changes since v2: - Fix my email script as it had started to drop linux-serial as noted by Greg - Explain why we're changing ctrl_id as requested by Greg Changes since v1: - Port id cannot be negative as noted by Jiri - Controller id cannot be negative as noted by Andy - Port name is missing the controller instance as noted by Andy Tony Lindgren (3): serial: core: Controller id cannot be negative serial: core: Fix serial core port id to not use port->line serial: core: Fix serial core controller port name to show controller id drivers/tty/serial/8250/8250_core.c | 2 ++ drivers/tty/serial/serial_base_bus.c | 32 +++++++++++++++++----------- include/linux/serial_core.h | 3 ++- 3 files changed, 24 insertions(+), 13 deletions(-) Acked-by: Andy Shevchenko