| Message ID | 20230724050709.17544-1-tony@atomide.com |
|---|---|
| Headers | show |
| Series | Serial core controller port device name fixes | expand |
On Mon, Jul 24, 2023 at 11:52:39AM +0300, Andy Shevchenko wrote: > On Mon, Jul 24, 2023 at 08:07:03AM +0300, Tony Lindgren wrote: > > The controller id cannot be negative. Let's fix the ctrl_id in preparation > > for adding port_id to fix the device name. > > > > Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM") > > Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > ??? > Missing Reviewed-by: I suppose? Seems like it wen in all patches... :-(
On 24. 07. 23, 10:55, Andy Shevchenko wrote: > On Mon, Jul 24, 2023 at 08:07:05AM +0300, Tony Lindgren wrote: >> We are missing the serial core controller id for the serial core port >> name. Let's fix the issue for sane /sys/bus/serial-core/devices, and to >> avoid issues addressing serial ports later on. > > ... > >> - return dev_set_name(dev, "%s.%s.%d", type->name, dev_name(port->dev), id); >> -} >> + if (type == &serial_ctrl_type) > > ... > >> +} > > While at it, have you tried to use --patience when forming patches? Does it > make any (better) difference? Or moving "struct device_type"s to one place in a separate patch might do the desired trick too ;).
A few issues have been found with device naming for the serial core controller port device. These issues currently mostly affect the output for /sys/bus/serial-base/devices, but need to be also fixed to avoid port addressing issues later on. Changes since v3: - Drop unnecessary else on the return path in serial_base_device_init() as noted by Andy - Add Andy's Reviewed-by - Update first patch description for port_id instead of port port_id for the first patch Changes since v2: - Fix my email script as it had started to drop linux-serial as noted by Greg - Explain why we're changing ctrl_id as requested by Greg Changes since v1: - Port id cannot be negative as noted by Jiri - Controller id cannot be negative as noted by Andy - Port name is missing the controller instance as noted by Andy Tony Lindgren (3): serial: core: Controller id cannot be negative serial: core: Fix serial core port id to not use port->line serial: core: Fix serial core controller port name to show controller id drivers/tty/serial/8250/8250_core.c | 2 ++ drivers/tty/serial/serial_base_bus.c | 34 ++++++++++++++++++---------- include/linux/serial_core.h | 3 ++- 3 files changed, 26 insertions(+), 13 deletions(-)