| Message ID | 20230329154235.615349-1-brenda.streiff@ni.com |
|---|---|
| Headers | show |
| Series | serial: Add driver for National Instruments UARTs | expand |
On Wed, 29 Mar 2023 10:42:34 -0500, Brenda Streiff wrote: > Add bindings for the NI 16550 UART. > > Signed-off-by: Brenda Streiff <brenda.streiff@ni.com> > Cc: Gratian Crisan <gratian.crisan@ni.com> > Cc: Jason Smith <jason.smith@ni.com> > --- > .../bindings/serial/ni,ni16550.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/serial/ni,ni16550.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/ni,ni16550.example.dtb: serial@80000000: compatible: ['ni,ni16550', 'ns16550a'] is too long From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/ni,ni16550.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/ni,ni16550.example.dtb: serial@80000000: Unevaluated properties are not allowed ('compatible' was unexpected) From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/ni,ni16550.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/ni,ni16550.example.dtb: serial@80000000: compatible: 'oneOf' conditional failed, one must be fixed: ['ni,ni16550', 'ns16550a'] is too long ['ni,ni16550', 'ns16550a'] is too short 'ns8250' was expected 'ns16450' was expected 'ns16550' was expected 'ns16550a' was expected 'ns16850' was expected 'aspeed,ast2400-vuart' was expected 'aspeed,ast2500-vuart' was expected 'intel,xscale-uart' was expected 'mrvl,pxa-uart' was expected 'nuvoton,wpcm450-uart' was expected 'nuvoton,npcm750-uart' was expected 'nvidia,tegra20-uart' was expected 'nxp,lpc3220-uart' was expected 'ni,ni16550' is not one of ['exar,xr16l2552', 'exar,xr16l2551', 'exar,xr16l2550'] 'ni,ni16550' is not one of ['altr,16550-FIFO32', 'altr,16550-FIFO64', 'altr,16550-FIFO128', 'fsl,16550-FIFO64', 'fsl,ns16550', 'andestech,uart16550', 'nxp,lpc1850-uart', 'opencores,uart16550-rtlsvn105', 'ti,da830-uart'] 'ni,ni16550' is not one of ['ns16750', 'cavium,octeon-3860-uart', 'xlnx,xps-uart16550-2.00.b', 'ralink,rt2880-uart'] 'ni,ni16550' is not one of ['nuvoton,npcm845-uart'] 'ni,ni16550' is not one of ['ralink,mt7620a-uart', 'ralink,rt3052-uart', 'ralink,rt3883-uart'] 'ni,ni16550' is not one of ['mediatek,mt7622-btif', 'mediatek,mt7623-btif'] 'mrvl,mmp-uart' was expected 'ni,ni16550' is not one of ['nvidia,tegra30-uart', 'nvidia,tegra114-uart', 'nvidia,tegra124-uart', 'nvidia,tegra210-uart', 'nvidia,tegra186-uart', 'nvidia,tegra194-uart', 'nvidia,tegra234-uart'] 'ralink,rt2880-uart' was expected 'mediatek,mtk-btif' was expected From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/8250.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/ni,ni16550.example.dtb: serial@80000000: Unevaluated properties are not allowed ('compatible', 'transceiver' were unexpected) From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/8250.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230329154235.615349-2-brenda.streiff@ni.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
This patch series adds a driver for the 16550-like UARTs on National
Instruments (NI) embedded controller hardware.
These UARTs have an interface that is compatble with the TL16C550C (for
which we build on top of 8250_core) but also has extra registers for
the embedded RS-232/RS-485 tranceiver control circuitry.
Changes from v1 -> v2:
- Schema fixes:
- Fix schema to now pass "make DT_CHECKER_FLAGS=-m dt_binding_check"
- Rename unprefixed "transceiver" to "ni,serial-port-mode" with a
description. Describing this as a "mode" rather than a "transceiver"
seems more semantically correct in comparison to other DTs; other
schemas with a "transceiver" property (isp1301, lpc32xx-udc) have
phandle values, which is not the case here.
- Driver fixes:
- replace C99 integer types with kernel types
- reverse christmas tree
- stuff PMR mode/cap masks into locals to avoid repetition
- wrap ACPI match table in #ifdef CONFIG_ACPI to avoid build error on
non-ACPI platforms
- NI 16550s are only on x86 and Zynq-7000 NI devices, so constrain the
Kconfig "depends" to only present it as an option to users on those
architectures, to prevent it from being needlessly built on platforms
that would not possibly have them.
- document module name
- add check for "ni,serial-port-mode" property; "transceiver" remains
for sake of compatibility with _DSD ACPI objects for NI controller
BIOSes currently in-field (but also DSD-properties-rules.rst says
that _DSD properties don't have to be identical to DT bindings.)
Brenda Streiff (2):
dt-bindings: serial: ni,ni16650: add bindings
serial: 8250: add driver for NI UARTs
.../bindings/serial/ni,ni16550.yaml | 51 ++
MAINTAINERS | 7 +
drivers/tty/serial/8250/8250_ni.c | 454 ++++++++++++++++++
drivers/tty/serial/8250/Kconfig | 13 +
drivers/tty/serial/8250/Makefile | 1 +
5 files changed, 526 insertions(+)
create mode 100644 Documentation/devicetree/bindings/serial/ni,ni16550.yaml
create mode 100644 drivers/tty/serial/8250/8250_ni.c