| Message ID | 20210518075833.3736038-1-narmstrong@baylibre.com |
|---|---|
| Headers | show |
| Series | tty: serial: meson: add amlogic,uart-fifosize property | expand |
On Tue, 18 May 2021 09:58:31 +0200, Neil Armstrong wrote: > On most of the Amlogic SoCs, the first UART controller in the "Everything-Else" > power domain has 128bytes of RX & TX FIFO, so add an optional property to describe > a different FIFO size from the other ports (64bytes). > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
Hi Greg, On 18/05/2021 09:58, Neil Armstrong wrote: > On most of the Amlogic SoCs, the first UART controller in the "Everything-Else" > power domain has 128bytes of RX & TX FIFO, so add an optional property to describe > a different FIFO size from the other ports (64bytes). > > This adds a property in the bindings, reads the property from the driver and updates > the DT with the new property. > > Changes since v2: > - removed spurious blank line from bindings > > Changes since v1: > - switched to a more generic "fifo-size" > > Neil Armstrong (3): > dt-bindings: serial: amlogic,meson-uart: add fifo-size property > tty: serial: meson: retrieve port FIFO size from DT > arm64: dts: meson: set 128bytes FIFO size on uart A > > .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 5 +++++ > arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 1 + > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 1 + > arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 1 + > drivers/tty/serial/meson_uart.c | 5 ++++- > 5 files changed, 12 insertions(+), 1 deletion(-) > Could you apply patches 1 & 2 ? Thanks, Neil
On Thu, May 20, 2021 at 03:55:35PM +0200, Neil Armstrong wrote: > Hi Greg, > > On 18/05/2021 09:58, Neil Armstrong wrote: > > On most of the Amlogic SoCs, the first UART controller in the "Everything-Else" > > power domain has 128bytes of RX & TX FIFO, so add an optional property to describe > > a different FIFO size from the other ports (64bytes). > > > > This adds a property in the bindings, reads the property from the driver and updates > > the DT with the new property. > > > > Changes since v2: > > - removed spurious blank line from bindings > > > > Changes since v1: > > - switched to a more generic "fifo-size" > > > > Neil Armstrong (3): > > dt-bindings: serial: amlogic,meson-uart: add fifo-size property > > tty: serial: meson: retrieve port FIFO size from DT > > arm64: dts: meson: set 128bytes FIFO size on uart A > > > > .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 5 +++++ > > arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 1 + > > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 1 + > > arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 1 + > > drivers/tty/serial/meson_uart.c | 5 ++++- > > 5 files changed, 12 insertions(+), 1 deletion(-) > > > > Could you apply patches 1 & 2 ? Sure, will go do so now...
On 20/05/2021 16:10, Greg KH wrote: > On Thu, May 20, 2021 at 03:55:35PM +0200, Neil Armstrong wrote: >> Hi Greg, >> >> On 18/05/2021 09:58, Neil Armstrong wrote: >>> On most of the Amlogic SoCs, the first UART controller in the "Everything-Else" >>> power domain has 128bytes of RX & TX FIFO, so add an optional property to describe >>> a different FIFO size from the other ports (64bytes). >>> >>> This adds a property in the bindings, reads the property from the driver and updates >>> the DT with the new property. >>> >>> Changes since v2: >>> - removed spurious blank line from bindings >>> >>> Changes since v1: >>> - switched to a more generic "fifo-size" >>> >>> Neil Armstrong (3): >>> dt-bindings: serial: amlogic,meson-uart: add fifo-size property >>> tty: serial: meson: retrieve port FIFO size from DT >>> arm64: dts: meson: set 128bytes FIFO size on uart A >>> >>> .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 5 +++++ >>> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 1 + >>> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 1 + >>> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 1 + >>> drivers/tty/serial/meson_uart.c | 5 ++++- >>> 5 files changed, 12 insertions(+), 1 deletion(-) >>> >> >> Could you apply patches 1 & 2 ? > > Sure, will go do so now... > thanks ! Neil
Hi, On Tue, 18 May 2021 09:58:30 +0200, Neil Armstrong wrote: > On most of the Amlogic SoCs, the first UART controller in the "Everything-Else" > power domain has 128bytes of RX & TX FIFO, so add an optional property to describe > a different FIFO size from the other ports (64bytes). > > This adds a property in the bindings, reads the property from the driver and updates > the DT with the new property. > > [...] Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v5.14/dt64) [3/3] arm64: dts: meson: set 128bytes FIFO size on uart A https://git.kernel.org/amlogic/c/a270a2b24de5 -- Neil