From patchwork Tue Feb 8 15:18:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chesnokov Gleb X-Patchwork-Id: 541039 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF7DFC433F5 for ; Tue, 8 Feb 2022 15:19:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379910AbiBHPTy (ORCPT ); Tue, 8 Feb 2022 10:19:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379804AbiBHPTu (ORCPT ); Tue, 8 Feb 2022 10:19:50 -0500 X-Greylist: delayed 62 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 08 Feb 2022 07:19:46 PST Received: from smtp.digdes.com (smtp.digdes.com [85.114.5.13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 887D9C0612BA for ; Tue, 8 Feb 2022 07:19:46 -0800 (PST) Received: from DDSM-MAIL01.digdes.com (172.16.100.67) by relay.digdes.com (172.16.96.24) with Microsoft SMTP Server (TLS) id 14.3.498.0; Tue, 8 Feb 2022 18:18:41 +0300 Received: from DDSM-MAIL01.digdes.com (172.16.100.67) by DDSM-MAIL01.digdes.com (172.16.100.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.12; Tue, 8 Feb 2022 18:18:41 +0300 Received: from DDSM-EXED02.digdes.com (172.16.96.56) by DDSM-MAIL01.digdes.com (172.16.100.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2375.12 via Frontend Transport; Tue, 8 Feb 2022 18:18:41 +0300 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (104.47.10.57) by relay2.digdes.com (172.16.96.56) with Microsoft SMTP Server (TLS) id 14.3.498.0; Tue, 8 Feb 2022 18:18:40 +0300 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=knHjtX+l1TnDlwSsBeLaZpJpd7LYP63vICHvgjJWSb7f60/Dvd0pdk6Kjw09raL6ffPJehk7ogSQQVgr04pgkKFYzVrxFicAOfPdowYYUadp1kek2LtPE0gSX2TITQ79UzObsI0YJNPUXRCvhMjlDKKbe/JrKTyHS0lZYO/kd8gsEc1Zvr0/Lct+QdqNlAZcsI52JH2d0sSBjOeGN0DntZ+WIBTD/IwuHlW9nfYfddovbvTj51C+mPtQyVyiFrJxwOKZfT/7VdE3Dak1tqhuHP21GA7CID3uMJBpyZNj3ta47o1WLrZOIo5zoMpBVsclzjanB7fHVUtoy/bnFBjvEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bl+ArISK1xfBTOkNEHOzMDUs9/p7x3D/l779KIA2NoE=; b=S8d66UdgY92jR/3R5ULnp6n/G616NYSu0Nf7St/gnax40QVGDgOLNBH2wJMX2sTqBWVOA1NQXybsZQITbOcn4ZSOg9AKlp/kBwlKGbroxm+NnvowGUjRurJZxsWr+lWBn5xmvduuk018NkcoldJjVikr3cacuXrAEzY51V+VC407Wh/GRLB7ascIYiLFtQr3SxBvssFzjbkH+ysjO1h0P15m4P86TNCDV5/TQeNXw2qv9lqqlWHnCkfeCbizjvtnleDim9545A9uWjcac8hiiVz4DcvROwL6XBgMK9io6FHTyUWMOxOoHl9BKqe8/lfbCXp/plMwfCNSP+lXo5ir2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=digdes.onmicrosoft.com; s=selector2-digdes-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bl+ArISK1xfBTOkNEHOzMDUs9/p7x3D/l779KIA2NoE=; b=oegviUqKaRz/kRsNZX4gyqfNN7hw9iRjpTrR0ElHy2aASoEQXHNiSrepJOuBskR/J/k+TUpYNrIU/uPBAK9FPrGtrREOye3WcVH8HpsbGKPt1gYnNjkhGDU1ffIF3oobmIWwyNq86vOzVKwyVTGthaDRAlr/lsa78h2Nphf35cU= Received: from AS8PR10MB4952.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:403::6) by HE1PR1001MB1211.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:3:75::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Tue, 8 Feb 2022 15:18:38 +0000 Received: from AS8PR10MB4952.EURPRD10.PROD.OUTLOOK.COM ([fe80::4878:86c5:8899:f1c5]) by AS8PR10MB4952.EURPRD10.PROD.OUTLOOK.COM ([fe80::4878:86c5:8899:f1c5%7]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022 15:18:38 +0000 From: Chesnokov Gleb To: "linux-scsi@vger.kernel.org" Subject: [PATCH 1/1] qla2xxx: Remove unused qla_sess_op_cmd_list from scsi_qla_host_t Thread-Topic: [PATCH 1/1] qla2xxx: Remove unused qla_sess_op_cmd_list from scsi_qla_host_t Thread-Index: AQHYHP6uTkVvKKm8B0+U8wwXn2ISBA== Date: Tue, 8 Feb 2022 15:18:38 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: 9c0ffd88-db9a-a874-7b69-c9ce9e8b2bff authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=raidix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 275be1bb-6007-4d98-2f00-08d9eb164827 x-ms-traffictypediagnostic: HE1PR1001MB1211:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:328; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gSeKvb7hyDtUbOGYgoDF+wvLohHitJHhlSD3qNPXjcJ99a6idVP+Sq3N9uqqVuODgwcVvhPCwjui0q4ovbucWJAnoHeVE3yzoVjtUspF4FhB/akwRuDFucl4BBX9aWwy6pasxRrAnw9iydS6veRkI+7Gqq6TAx534SElHls3Xe/SGWyQ1d7vfcZxe3KTCJKzdfqsuwEMNguiaJMSXpAmf1xLtEwmw4h2hfeoovjlqFWI4QSJe4X49gUwtc0FP0Xr0hgNElda6uqGYzG+3zkuIyzBrCkiVAFnbH9oZs/TqCxzA8Q26N7Ku1DAdRMnmpccHuceuklLOVZ1C7bp88OzKweYsOvHtQZKY9AEh7ZWsXsn9082q6qyvD/EqOtJKH1n8qbcNC+9HrApSYURaFMcST71SRXT49MKOs6c8tZUXY82TyULriApISHzwxoucZHMVgKfx/Jrglk5rNB6sGZYWJHzhZmIDhkW53hf31VgHu+M9SYjXrpfCR42ls4NhFzR4h2jVulMyOrTcR7UxZo/MUtIhxm79+w12ar9nG3IHU4ESaFnQc4Sdu+GyKzH2NnRrWZZv8KEsFsnylwDS9FwSXW4DUAC/vlM/PaekSbDl8QDv58Aj8FPxC4h7HQYE4QmbuSZloELMmWTo07+mTk8RMp+JmGQb4gga/NvPKSYCHQQkMd7kcE9ZIuWXspbKp7dWJWtyhaRoCWjdeZ3wzahNg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR10MB4952.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(316002)(38100700002)(86362001)(6506007)(122000001)(38070700005)(71200400001)(6916009)(55016003)(2906002)(7696005)(9686003)(186003)(66446008)(66476007)(76116006)(66946007)(66556008)(8936002)(8676002)(64756008)(91956017)(52536014)(26005)(5660300002)(508600001)(83380400001)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?+gcUaLkIdQX+aVFACJcelXV?= =?iso-8859-1?q?N8H5Exdzox/cdErW8TTAmhHjjuLIfgpglb7WBTpo/rW6ZrCGL18JJqr9KBkK?= =?iso-8859-1?q?kcm56087pD8QqJZMp/LjmGohUQMSfnayA40G17d6IsuHXv+OMDeDHf8iDAK5?= =?iso-8859-1?q?HqJGgknjfFfMPqKh9QoeYyIsIqPdtS1LUmh44kE2cc9NnsS2k4CIepKEQd71?= =?iso-8859-1?q?PhQd/uqTbu0Xq1mYwlQf4xkjAm1/OtDZKSuL7+9x/H6g/pJkuiNo5a12pUSg?= =?iso-8859-1?q?Vfv1cWaBlJQcW3aWgaQApFda+N2wPohNvdMD+NHtJuZFreiQTf55ILjK9afj?= =?iso-8859-1?q?sGDEKgEYLhJdV58DFMkXBRl5PE46bPOzTsCNFa0IJHUqCjpawf2ChtivN9GC?= =?iso-8859-1?q?rJQPMAuLGXj8/T+9y96iqiqE8/NgZhCIw+f/RGToazIhhbzLI2DQ4dsVbrcB?= =?iso-8859-1?q?x9LITDEHZoAXmskRBzIcOx9CFYOIwvZr6ioAW9EaNeuTEeftUa3sQgo6xOev?= =?iso-8859-1?q?K9AmDztqnl8R6F6H/H4zJubZri8I7IsaZxblijx0yv5t1ouNbrPtYSjZfvH5?= =?iso-8859-1?q?I2+NYnZRDp5J8QuAEUZb0GYB49/wYyEej8YnwcUTM2qknCyHJfUfGp+i4WYs?= =?iso-8859-1?q?o68wCuD8o8O149r0yoKbTclhSP/LwpQoEvLvw2zzLncod6xHDV16iAnCnIS+?= =?iso-8859-1?q?qnxwlOZv9W5E5MQS6M9aYoYd/IiffjtR2E3T17a6LFE20Pq3TmkbkzjGW+bZ?= =?iso-8859-1?q?u7sfhoJYCeEXiJD1tNkcXzCi4uchtnDTWumqxKzDtUATzgB+kVhHs66WB7Ho?= =?iso-8859-1?q?xg29L1FDag7HpwILllEBfrabfE51uY75By+1wBjMGa2SOT+sCWxjw3ycgbGu?= =?iso-8859-1?q?ABwYurHsikBpMGV8MnbOYaC/mC04o2qbZN0p/cXlnefTdfnPGMrNmS0GcqNq?= =?iso-8859-1?q?3T7PORTIepWMMke8ErrytD/jAcb6AW4lSdR/HM1z+M9eqxc6AnhDk3YJRRih?= =?iso-8859-1?q?v95jr2XEzXQCgzmqAc+h3bgFGfgoxAPmb3faaG/ovDZaidGbxq7rs9zhc8sN?= =?iso-8859-1?q?gnNwDqoN4tRmKK5HRcO3OQdCX8cOsS+7Xr9UlIZdBLRby9e3NrgfuIpVMJ9f?= =?iso-8859-1?q?zJdpeo29cWUYUjJPOUYH8EzWxkPYZCfvFGm4pb5RK1wB7Tp1LplgSr2QsAEi?= =?iso-8859-1?q?Y79ki85Ca/+QSFDeq9m112lzI51l+LiJcKMcNeN7tPKXU/Dm4RtoxfhZeqDp?= =?iso-8859-1?q?kn0ERJwkDnn65ZO+98+litVaXnQK5LOOI3Q8ns3QhBTLXlKLKPGGAI06TsV/?= =?iso-8859-1?q?gnppB3L4GuO5dwFNbwKjqXxxzF1ZFZ0IW897O3Oyo709mE5mMR8s25fEPS/6?= =?iso-8859-1?q?lvbHnUJjy8zfMWXaGCQaBV/OCK9At6Qyv4PvW32uNVIoBeTgojZBlRu80Arf?= =?iso-8859-1?q?wga42K8pgvUN1wJAd2PJKRmBC+Er2jbVMr2V1IfJUdQeSezRrKzFK6U6QOE8?= =?iso-8859-1?q?7fLfDMBhoZN6HptiW9X2VxUjashqVmhzpqPkE2ni0HLsnaHP+Lch1RTQaiJx?= =?iso-8859-1?q?uFqTzuhbynjfO80UE13e6GKkxt8HMvgfNkKwRmGCWEpC0WDLy6zjwfVT3jci?= =?iso-8859-1?q?Z6yKMr4aM4m4fx9oyrOp/UPDEaYpxhxWLxDZTLA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR10MB4952.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 275be1bb-6007-4d98-2f00-08d9eb164827 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 15:18:38.1346 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70c55e28-9cd7-4753-937e-c751128a9d38 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y40KChMRNwEV60GCu8Dnmguvd1fqceRze+oaIDtNYoE7vJrmudWVyKoITuy0QOBLg/nnLT3CHPh0v8IejUbwbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR1001MB1211 X-OriginatorOrg: raidix.com Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org The qla_sess_op_cmd_list was introduced in 8b2f5ff3d05c ("qla2xxx: cleanup cmd in qla workqueue before processing TMR"). Then the usage of this list was dropped in fb35265b12bb ("scsi: qla2xxx: Remove session creation redundant code"). Thus, remove this list since it is no longer used. Signed-off-by: Gleb Chesnokov Reviewed-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 - drivers/scsi/qla2xxx/qla_os.c | 1 - drivers/scsi/qla2xxx/qla_target.c | 20 -------------------- 3 files changed, 22 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h index 9ebf4a234d9a..7d8ebabb7b40 100644 --- a/drivers/scsi/qla2xxx/qla_def.h +++ b/drivers/scsi/qla2xxx/qla_def.h @@ -4906,7 +4906,6 @@ typedef struct scsi_qla_host { /* list of commands waiting on workqueue */ struct list_head qla_cmd_list; - struct list_head qla_sess_op_cmd_list; struct list_head unknown_atio_list; spinlock_t cmd_list_lock; struct delayed_work unknown_atio_work; diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index abcd30917263..579379a3c554 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -4949,7 +4949,6 @@ struct scsi_qla_host *qla2x00_create_host(struct scsi_host_template *sht, INIT_LIST_HEAD(&vha->work_list); INIT_LIST_HEAD(&vha->list); INIT_LIST_HEAD(&vha->qla_cmd_list); - INIT_LIST_HEAD(&vha->qla_sess_op_cmd_list); INIT_LIST_HEAD(&vha->logo_list); INIT_LIST_HEAD(&vha->plogi_ack_list); INIT_LIST_HEAD(&vha->qp_list); diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 8993d438e0b7..d5dad6e6d4cc 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -2026,17 +2026,6 @@ static void abort_cmds_for_lun(struct scsi_qla_host *vha, u64 lun, be_id_t s_id) key = sid_to_key(s_id); spin_lock_irqsave(&vha->cmd_list_lock, flags); - list_for_each_entry(op, &vha->qla_sess_op_cmd_list, cmd_list) { - uint32_t op_key; - u64 op_lun; - - op_key = sid_to_key(op->atio.u.isp24.fcp_hdr.s_id); - op_lun = scsilun_to_int( - (struct scsi_lun *)&op->atio.u.isp24.fcp_cmnd.lun); - if (op_key == key && op_lun == lun) - op->aborted = true; - } - list_for_each_entry(op, &vha->unknown_atio_list, cmd_list) { uint32_t op_key; u64 op_lun; @@ -4727,15 +4716,6 @@ static int abort_cmds_for_s_id(struct scsi_qla_host *vha, port_id_t *s_id) ((u32)s_id->b.al_pa)); spin_lock_irqsave(&vha->cmd_list_lock, flags); - list_for_each_entry(op, &vha->qla_sess_op_cmd_list, cmd_list) { - uint32_t op_key = sid_to_key(op->atio.u.isp24.fcp_hdr.s_id); - - if (op_key == key) { - op->aborted = true; - count++; - } - } - list_for_each_entry(op, &vha->unknown_atio_list, cmd_list) { uint32_t op_key = sid_to_key(op->atio.u.isp24.fcp_hdr.s_id);