From patchwork Fri Jun 6 15:29:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 894749 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9A4376026 for ; Fri, 6 Jun 2025 15:29:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749223796; cv=none; b=ObbPvAVfzFFN8XAzvwekOHH1yrb+VFa0WDyQEmgYTAWvAUpGEt2pN/K3otsTcNnmP+QzCNts3aO6y3IOfPN+AhhUD1xZaCx77CGMQtFsoZXFAgCn9NdA1XMjZ2GSR35/5BlsPN22+SgcbW88aCrc3zIthoK4FIXBNG1zHgfnD+4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749223796; c=relaxed/simple; bh=v7Au4C4CPsHEk+3y2XJCnvtIlU+mBidFXKTov4cpvRU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=AqLhMc5LVios4NwfiyWxaz4xsnVlrcvbK86pf5rmzq15qO5TCibzGpV5QYKelvOC9KGALXCOow9PS67zQhHvqYLaxw5kMXcFgKxitSwHcp7OKh+IS0s236KBokA7i8wan7UrcR9Xg0cTRHJSXKnIJY682m5b+4RbXqLKm4Xqf2s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=pbmecGN1; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pbmecGN1" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-adb5fd85996so427297666b.2 for ; Fri, 06 Jun 2025 08:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749223792; x=1749828592; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=pHKg9aReCBIhycPzMljP890R0nKClsGn0j0TZZruLEs=; b=pbmecGN1OqgEPpflLsZ6dogyEF3lkXEgtGQaxQLFjznGg7x3l/xQPaFD7/z6uaPZHa RlVxeE0SbmVxT8ACQ+xtW3FvCZQE8+YntL3kCqoBmtGcqg5pb51BSS0RNpEsarjnAGVK mLCDx3HjHR2QrM+NAKgq6JrGMWeJsylP13ZwGbpzWZow0/cP/9pVqZnyI07L/aPlU/Bx IWXvTJDPKkLo+s4fXRqNIMyUTzyF7EwcyG7moiM4NrZy+BXcqJmKpX4z9qYgDHlsHcvo /ik0BQ3ArHKyWkBqepM79Nv54AxgyZJbe4sa8ZXzrj4d0X8348ld/Ddn7v5ujqMO84Fg RY2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749223792; x=1749828592; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pHKg9aReCBIhycPzMljP890R0nKClsGn0j0TZZruLEs=; b=oUgBjprNAwwIzFrA2hp2kJiVmqrIyUdeOc632jAvDWKprse+PD9I64kuby1V21GJa5 C6dgQFnwKUV42OAMaWYuJxbt0XDxJTPIw85k1MR5B4BJG8HVgalcVD6tpa0CDX0zR8DU h1UydGnhUyE02GQ3cW7Oh36tYD85hgNi9Y+QptnrG4eX0ZOjaAJwSO1vPZ+5lbEGI6P0 vlVaH4ink1tzAUP9pZ+cB1mhW9JikiWBsdG2uPfktUhzouyNada/CbtUDvzHkhF00vjU la77mfu7PFxwqkyYsbybUbr6rJnyFnmSJS0Y+6vai7ZML5ChhMS2BIKTWpYeoSzM0xS3 2vgg== X-Forwarded-Encrypted: i=1; AJvYcCWzyQkPehZhozkUqlsYtTbOOnYYC5Sjv4LfTgWCiKtRt7Wj+e1zS8FshPzaR+6DGIY/StDiaIn7nqb1@vger.kernel.org X-Gm-Message-State: AOJu0YyTCMwpLXxiS29KAwnI/8bG27tAB/sQ3/E/Ncx7CcRCSiZIlsXy U83CJ3DyfCXQgGWxUTCq2tABMcmL5Ai8uBkzATtvEiXgrzMkLT8K4iQ4WyNIUpK7mWA= X-Gm-Gg: ASbGncucOWsW4wN/ijuNjv2PnttrDl7icCYPuq0cu+bb6zYReFEMNVcVaq9wzQn7NmY e86Dds317zcNVnDpHJkh1v8R4nVe5JlM3Vudm2gNBvm9le500C0QfsOCJ+QYrP3CCDbnepQAnZh jRXAUYjfgB6FtJJZJ6jNAuynEO7vBYSlsC/fNBXq6RK8FzZjLzUDEStxaKTvOGPuymRpL0luSN/ ryqWokeJ1blO/KqbChyoeNzhbI9KGl83ZIuIRTk1lI4VHFlaj57JRLv+wECOkFhL05dq9hAqlTV R2V14Xgss2GHXEKB8PKib47w8BDTl0tpYFQXwlbQsek9MiBmOWYbO+bt3DivgL0fMiIO80PBhAN kJGMJEHrAG1AJ4dwbBDBKTU2+moewRJJ2ETCDOyuzidebVw== X-Google-Smtp-Source: AGHT+IFIbqOwQmbDQEe3E/wlxCxAjm4JmZX9I8K8ar5M7fYX/U4wmJP0R3iG9BUeJ0Tu3p9r9nBSjg== X-Received: by 2002:a17:906:9fc7:b0:ade:8df:5b4d with SMTP id a640c23a62f3a-ade1a9329dcmr347910366b.15.1749223792241; Fri, 06 Jun 2025 08:29:52 -0700 (PDT) Received: from puffmais.c.googlers.com (140.20.91.34.bc.googleusercontent.com. [34.91.20.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ade1d754913sm130801166b.4.2025.06.06.08.29.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 08:29:51 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 06 Jun 2025 16:29:43 +0100 Subject: [PATCH] scsi: mpt3sas: drop unused variable in mpt3sas_send_mctp_passthru_req() Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250606-mpt3sas-v1-1-906ffe49fb6b@linaro.org> X-B4-Tracking: v=1; b=H4sIAGYJQ2gC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDI1MDMwMz3dyCEuPixGJdQ1NTM2MLA8s0cwNTJaDqgqLUtMwKsEnRsbW1AGY q/l5ZAAAA X-Change-ID: 20250606-mpt3sas-15563809f705 To: Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , "James E.J. Bottomley" , "Martin K. Petersen" , Shivasharan S Cc: Peter Griffin , Tudor Ambarus , MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 With W=1, gcc complains correctly: mpt3sas_ctl.c: In function ‘mpt3sas_send_mctp_passthru_req’: mpt3sas_ctl.c:2917:29: error: variable ‘mpi_reply’ set but not used [-Werror=unused-but-set-variable] 2917 | MPI2DefaultReply_t *mpi_reply; | ^~~~~~~~~ Drop the unused assignment and variable. Fixes: c72be4b5bb7c ("scsi: mpt3sas: Add support for MCTP Passthrough commands") Cc: stable@vger.kernel.org Signed-off-by: André Draszik --- drivers/scsi/mpt3sas/mpt3sas_ctl.c | 3 --- 1 file changed, 3 deletions(-) --- base-commit: a0bea9e39035edc56a994630e6048c8a191a99d8 change-id: 20250606-mpt3sas-15563809f705 Best regards, diff --git a/drivers/scsi/mpt3sas/mpt3sas_ctl.c b/drivers/scsi/mpt3sas/mpt3sas_ctl.c index 02fc204b9bf7b276115bf6db52746155381799fd..3b951589feeb6c13094ea44b494ca3050a309b15 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_ctl.c +++ b/drivers/scsi/mpt3sas/mpt3sas_ctl.c @@ -2914,7 +2914,6 @@ int mpt3sas_send_mctp_passthru_req(struct mpt3_passthru_command *command) { struct MPT3SAS_ADAPTER *ioc; MPI2RequestHeader_t *mpi_request = NULL, *request; - MPI2DefaultReply_t *mpi_reply; Mpi26MctpPassthroughRequest_t *mctp_passthru_req; u16 smid; unsigned long timeout; @@ -3022,8 +3021,6 @@ int mpt3sas_send_mctp_passthru_req(struct mpt3_passthru_command *command) goto issue_host_reset; } - mpi_reply = ioc->ctl_cmds.reply; - /* copy out xdata to user */ if (data_in_sz) memcpy(command->data_in_buf_ptr, data_in, data_in_sz);