From patchwork Wed Jun 26 18:00:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Cassel X-Patchwork-Id: 808068 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EEA219004C; Wed, 26 Jun 2024 18:01:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719424860; cv=none; b=tOkLX9wwDesJKG9Ily5J9s8KcEaps0tQih+qTXLdACW8OQkLUJaLvOgWS4gNK5jwxrfGNwAZ3O7U6JXFARLizu5Ot4Il3aMrLN2b5Fi6lR0PatcpOJm3zDijMovqv2bK8fartXIbk6bilZdK0zSLeUi3c9k66x/M/SftUq6ivQM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719424860; c=relaxed/simple; bh=jZWsIbqDMulmqEcgw1nml3QjMymfnv611xCdyYVDH4s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mkD0ANe6Wr/OTDUwvaPgOC5h70zTnxyokgQk9gfITUBb2QcuIo8laX7sq8DR2PficBUq5TrN5a/fdWxdiIS7fnYUQVvhk4pejGJlAX+LOKwszJmbduEqsZshlySqcIlQ+nGDRgsyjk6K8bqlDafJnBscwdv0utCYtOlDBA8OyS8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uEA9sFdY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uEA9sFdY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB4D1C4AF09; Wed, 26 Jun 2024 18:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719424860; bh=jZWsIbqDMulmqEcgw1nml3QjMymfnv611xCdyYVDH4s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uEA9sFdYBmRaE5d8r3Ud0/u0m58zdNMafqHaGqOj3ltOrtkgY3Tr2wiJ8LuNJFTbQ cV7Z/Y8AHNvtbP5+BNf8BXvtgCJAvKNN12VurpoqZeQXqR4w4w9c5Bh6HCyzIIiGFW 4ZDuNor8hSgrNfRbQ5p5I0oMh99310ScVvv9hotxoIavE11OfTe96G/ubSuDGPPERX ljdWwOZ2kvbx/Cr5yJMHTFkV8FSXPeG9xFScnxyO96d7HZfDhkVnP8OAseg9r02hUY Zx4NruTg2SHVKqHTTxnhU35Ih8dGr7FCq4yEdIdvTmKm/LILDEnhwulNL6BH65ihRB abvlXeytGNGTw== From: Niklas Cassel To: Damien Le Moal , Niklas Cassel , Tejun Heo , Jeff Garzik Cc: linux-scsi@vger.kernel.org, John Garry , Jason Yan , "Martin K. Petersen" , "James E.J. Bottomley" , stable@vger.kernel.org, linux-ide@vger.kernel.org Subject: [PATCH v2 01/13] ata: libata-core: Fix null pointer dereference on error Date: Wed, 26 Jun 2024 20:00:31 +0200 Message-ID: <20240626180031.4050226-16-cassel@kernel.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240626180031.4050226-15-cassel@kernel.org> References: <20240626180031.4050226-15-cassel@kernel.org> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2558; i=cassel@kernel.org; h=from:subject; bh=jZWsIbqDMulmqEcgw1nml3QjMymfnv611xCdyYVDH4s=; b=owGbwMvMwCV2MsVw8cxjvkWMp9WSGNJqwu2/Hw1pCrS6JLc5RL50rdiCI1L827cufHeh1G9t4 XyhZh+djlIWBjEuBlkxRRbfHy77i7vdpxxXvGMDM4eVCWQIAxenAEzEvIWRYapRj3eu25Ws80sn 8a9es1yl/lCLT4BsHcPXiXNb1+TJn2dkuMl69lleAcupM/wiR6Pt2wQ81VmUO69dVTxw9PSrWRO zmQE= X-Developer-Key: i=cassel@kernel.org; a=openpgp; fpr=5ADE635C0E631CBBD5BE065A352FE6582ED9B5DA If the ata_port_alloc() call in ata_host_alloc() fails, ata_host_release() will get called. However, the code in ata_host_release() tries to free ata_port struct members unconditionally, which can lead to the following: BUG: unable to handle page fault for address: 0000000000003990 PGD 0 P4D 0 Oops: Oops: 0000 [#1] PREEMPT SMP NOPTI CPU: 10 PID: 594 Comm: (udev-worker) Not tainted 6.10.0-rc5 #44 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-2.fc40 04/01/2014 RIP: 0010:ata_host_release.cold+0x2f/0x6e [libata] Code: e4 4d 63 f4 44 89 e2 48 c7 c6 90 ad 32 c0 48 c7 c7 d0 70 33 c0 49 83 c6 0e 41 RSP: 0018:ffffc90000ebb968 EFLAGS: 00010246 RAX: 0000000000000041 RBX: ffff88810fb52e78 RCX: 0000000000000000 RDX: 0000000000000000 RSI: ffff88813b3218c0 RDI: ffff88813b3218c0 RBP: ffff88810fb52e40 R08: 0000000000000000 R09: 6c65725f74736f68 R10: ffffc90000ebb738 R11: 73692033203a746e R12: 0000000000000004 R13: 0000000000000000 R14: 0000000000000011 R15: 0000000000000006 FS: 00007f6cc55b9980(0000) GS:ffff88813b300000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000003990 CR3: 00000001122a2000 CR4: 0000000000750ef0 PKRU: 55555554 Call Trace: ? __die_body.cold+0x19/0x27 ? page_fault_oops+0x15a/0x2f0 ? exc_page_fault+0x7e/0x180 ? asm_exc_page_fault+0x26/0x30 ? ata_host_release.cold+0x2f/0x6e [libata] ? ata_host_release.cold+0x2f/0x6e [libata] release_nodes+0x35/0xb0 devres_release_group+0x113/0x140 ata_host_alloc+0xed/0x120 [libata] ata_host_alloc_pinfo+0x14/0xa0 [libata] ahci_init_one+0x6c9/0xd20 [ahci] Do not access ata_port struct members unconditionally. Fixes: 633273a3ed1c ("libata-pmp: hook PMP support and enable it") Cc: stable@vger.kernel.org Signed-off-by: Niklas Cassel Reviewed-by: Damien Le Moal Reviewed-by: Hannes Reinecke --- drivers/ata/libata-core.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index e1bf8a19b3c8..88e32f638f33 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -5518,10 +5518,12 @@ static void ata_host_release(struct kref *kref) for (i = 0; i < host->n_ports; i++) { struct ata_port *ap = host->ports[i]; - kfree(ap->pmp_link); - kfree(ap->slave_link); - kfree(ap->ncq_sense_buf); - kfree(ap); + if (ap) { + kfree(ap->pmp_link); + kfree(ap->slave_link); + kfree(ap->ncq_sense_buf); + kfree(ap); + } host->ports[i] = NULL; } kfree(host);