| Message ID | 20240202073104.2418230-13-dlemoal@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | Zone write plugging | expand |
On 2/2/24 15:30, Damien Le Moal wrote: > With zone write plugging enabled at the block layer level, any zone > device can only ever see at most a single write operation per zone. > There is thus no need to request a block scheduler with strick per-zone > sequential write ordering control through the ELEVATOR_F_ZBD_SEQ_WRITE > feature. Removing this allows using a zoned ublk device with any > scheduler, including "none". > > Signed-off-by: Damien Le Moal <dlemoal@kernel.org> > --- > drivers/block/ublk_drv.c | 2 -- > 1 file changed, 2 deletions(-) > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c index 1dfb2e77898b..35fb9cc739eb 100644 --- a/drivers/block/ublk_drv.c +++ b/drivers/block/ublk_drv.c @@ -252,8 +252,6 @@ static int ublk_dev_param_zoned_apply(struct ublk_device *ub) disk_set_zoned(ub->ub_disk); blk_queue_flag_set(QUEUE_FLAG_ZONE_RESETALL, ub->ub_disk->queue); - blk_queue_required_elevator_features(ub->ub_disk->queue, - ELEVATOR_F_ZBD_SEQ_WRITE); disk_set_max_active_zones(ub->ub_disk, p->max_active_zones); disk_set_max_open_zones(ub->ub_disk, p->max_open_zones); blk_queue_max_zone_append_sectors(ub->ub_disk->queue, p->max_zone_append_sectors);
With zone write plugging enabled at the block layer level, any zone device can only ever see at most a single write operation per zone. There is thus no need to request a block scheduler with strick per-zone sequential write ordering control through the ELEVATOR_F_ZBD_SEQ_WRITE feature. Removing this allows using a zoned ublk device with any scheduler, including "none". Signed-off-by: Damien Le Moal <dlemoal@kernel.org> --- drivers/block/ublk_drv.c | 2 -- 1 file changed, 2 deletions(-)