From patchwork Mon Jan 22 17:24:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 766781 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34999612D3 for ; Mon, 22 Jan 2024 17:24:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705944284; cv=none; b=W2I2Hlbdq+Zcc/icKFTRN8pF9B8OqlNdxzsFKS/mNR2vWSZ6Fgw9mhzdiK8io1BqiJvjLinsA0GpZAZEgHr6/o1JesVuKEJrdHYwNEspg/eeuEnyxwr3xo5V8HmuIcx/OYNjCXemJbMwOHrkFd4D9SE9RC0bC8PkSfcaf/Q5ETU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705944284; c=relaxed/simple; bh=zKxNl6WkG8B4Eq9wfZgbuUODUlpOt/Exm0CtlwBwjts=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nBvye//Ij11BE/OksXWafbs/XgKzDnDcYYKtckpXmRtzROIPGqslwWOKr5rbPfbFqz0grd8Yx4NHYWFsMccuczFn+C/H23Mfds+4pHozolw5AcFzq8sC+mKzQOpXOztfsQ+MUerWPLm9fUtP40Ea46xp3EeZ3NGad6cOifciHHY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EqlVXzgg; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EqlVXzgg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705944282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n3rKjJ1dBHRScMpZN00CyaIUSPfncYm2oVF6llIbVjU=; b=EqlVXzggzmFFZmB0TS0wfEDMfCfHIBNjZa6vQ/9ok++DHIxe3zbumbyALfsmdCy8d/fqYE fWa/IewbeM+ON5wqOF3h2lNzT2rQEYlokIPUdl3/aCnARMm+gx+/iyJdesPnHcjHGub5Yq IdJiPKqYHKaqwVd2hOzwNbA4JAV/et8= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-314-M5FvvKwIOWyQ2Z0ClzMr0A-1; Mon, 22 Jan 2024 12:24:41 -0500 X-MC-Unique: M5FvvKwIOWyQ2Z0ClzMr0A-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-429d186ef21so58056541cf.0 for ; Mon, 22 Jan 2024 09:24:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705944279; x=1706549079; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n3rKjJ1dBHRScMpZN00CyaIUSPfncYm2oVF6llIbVjU=; b=igJXsoZyLkazVtsdNCDPY92JeIsuZ8lVCdh3zIQdarY5jnA27kSZ+3Nh8+CZpjJ51v 5x3AG/yG8QloevUy/xP8rpIvDZWlFZnsTJqNqz/wG4jFHC5zHfzjA7Q5wLJL0o2cPNzm EBkiSFfcffOwEPhgR0Af+9oIS1QbrF4zox2lto/UbgUxQk01mEFldEVqaIB1chzaRGjH pZ8NardUL3whKyKuH4xDjpLlD3ItLLlgVVNiu2s2k/zoIOqT0fvnRyMyU+yXYjqXM1+t 88kfcOe0ecfeSAazojUqSmd+N2XZ7YNBRGNzB1BG+G521kjiXw4X2Z29KKquk20INUj2 VOmQ== X-Gm-Message-State: AOJu0YwheRmpgklCR3bCDg7fOkcTnDl7vIPkUDClDD7aMb5CBpjw53e5 LWTkzSDiU5ctfXvjzvQ7wIbZQAMbylv2dzOdD4B3FqIVcW/u89lm+KIiYrTenkzmJrJxKzt828b IOTRY+QPdSnem7Q5KBa4OF/enjStBu2lY1qNe41WdRSx+UVpMgMDJ+++kibI= X-Received: by 2002:a05:622a:1347:b0:42a:48e6:3d1d with SMTP id w7-20020a05622a134700b0042a48e63d1dmr681139qtk.8.1705944279388; Mon, 22 Jan 2024 09:24:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IEuY55kVsfL50Q7J3H8/c0F80dF+lr4iA1MexthqCvJRSr5PWyDSdjwYzVA9BBQ9jMpLW4EtA== X-Received: by 2002:a05:622a:1347:b0:42a:48e6:3d1d with SMTP id w7-20020a05622a134700b0042a48e63d1dmr681119qtk.8.1705944279021; Mon, 22 Jan 2024 09:24:39 -0800 (PST) Received: from fedora.redhat.com ([2600:1700:1ff0:d0e0::37]) by smtp.gmail.com with ESMTPSA id c7-20020a05620a200700b00781ae860c31sm2280992qka.70.2024.01.22.09.24.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 09:24:38 -0800 (PST) From: Andrew Halaney To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Hannes Reinecke , Janek Kotas , Alim Akhtar , Avri Altman , Bart Van Assche , Can Guo Cc: Andrew Halaney , Will Deacon , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH RFC v4 07/11] scsi: ufs: core: Perform read back after writing UTP_TASK_REQ_LIST_BASE_H Date: Mon, 22 Jan 2024 11:24:03 -0600 Message-ID: <20240122-ufs-reset-ensure-effect-before-delay-v4-7-90a54c832508@redhat.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122-ufs-reset-ensure-effect-before-delay-v4-0-90a54c832508@redhat.com> References: <20240122-ufs-reset-ensure-effect-before-delay-v4-0-90a54c832508@redhat.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mailer: b4 0.12.3 Currently, the UTP_TASK_REQ_LIST_BASE_L/UTP_TASK_REQ_LIST_BASE_H regs are written to and then completed with an mb(). mb() ensure that the write completes, but completion doesn't mean that it isn't stored in a buffer somewhere. The recommendation for ensuring these bits have taken effect on the device is to perform a read back to force it to make it all the way to the device. This is documented in device-io.rst and a talk by Will Deacon on this can be seen over here: https://youtu.be/i6DayghhA8Q?si=MiyxB5cKJXSaoc01&t=1678 Let's do that to ensure the bits hit the device. Because the mb()'s purpose wasn't to add extra ordering (on top of the ordering guaranteed by writel()/readl()), it can safely be removed. Fixes: 88441a8d355d ("scsi: ufs: core: Add hibernation callbacks") Reviewed-by: Manivannan Sadhasivam Reviewed-by: Bart Van Assche Reviewed-by: Can Guo Signed-off-by: Andrew Halaney --- drivers/ufs/core/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index 029d017fc1b6..e2e6002fe46a 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -10347,7 +10347,7 @@ int ufshcd_system_restore(struct device *dev) * are updated with the latest queue addresses. Only after * updating these addresses, we can queue the new commands. */ - mb(); + ufshcd_readl(hba, REG_UTP_TASK_REQ_LIST_BASE_H); /* Resuming from hibernate, assume that link was OFF */ ufshcd_set_link_off(hba);