From patchwork Wed Sep 27 14:18:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 726992 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12012E80AB3 for ; Wed, 27 Sep 2023 14:19:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232230AbjI0OTq (ORCPT ); Wed, 27 Sep 2023 10:19:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232129AbjI0OTC (ORCPT ); Wed, 27 Sep 2023 10:19:02 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D862F9; Wed, 27 Sep 2023 07:19:02 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6409DC433C7; Wed, 27 Sep 2023 14:19:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695824341; bh=qrUl5SH+B8SP/ZoBFwIfkCLObB6aWz8x19i2XQMuplw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c4NAURG+a151LZ51OuLGoOM1Pgr0A/PNTOrCRzcfx6rIY/3BtNgtfaXV1LYoi6KCq Au7wv3pLouCSwnj6OgSckceTcgGq2BEXGO6pHrNxOI2aKT9wAKq5lwAUKl/Tf5plEF eIuvJzRnRKEx0BchFF6H/NHy+qBYYQ4nrx9cmynPrnNM/Hm7TpOL8P/TGDkwwGdZ/6 nbDE69sq26VZ1Jg+bWOC1A1hfkRRUVx6uF1LhxqDLrMyQH4KVQPVwJyxeX2XWZcacL pbOo6genuUSBklAHdVFwF4Uyq6zI76GUZjtF4TE0HqR9ZYdawKC2vX0wDj/MsG1d8g LfnRc3ABUkoxQ== From: Damien Le Moal To: linux-ide@vger.kernel.org Cc: linux-scsi@vger.kernel.org, "Martin K . Petersen" , John Garry , Rodrigo Vivi , Paul Ausbeck , Kai-Heng Feng , Joe Breuer , Geert Uytterhoeven , Chia-Lin Kao Subject: [PATCH v8 18/23] ata: libata-core: Do not poweroff runtime suspended ports Date: Wed, 27 Sep 2023 23:18:23 +0900 Message-ID: <20230927141828.90288-19-dlemoal@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230927141828.90288-1-dlemoal@kernel.org> References: <20230927141828.90288-1-dlemoal@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org When powering off, there is no need to suspend a port that has already been runtime suspended. Skip the EH PM request in ata_port_pm_poweroff() in this case. Signed-off-by: Damien Le Moal Reviewed-by: Hannes Reinecke Tested-by: Chia-Lin Kao (AceLan) Tested-by: Geert Uytterhoeven Reviewed-by: Martin K. Petersen --- drivers/ata/libata-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 6773a1e52dad..df6ed386e6fc 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -5215,7 +5215,8 @@ static int ata_port_pm_freeze(struct device *dev) static int ata_port_pm_poweroff(struct device *dev) { - ata_port_suspend(to_ata_port(dev), PMSG_HIBERNATE, false); + if (!pm_runtime_suspended(dev)) + ata_port_suspend(to_ata_port(dev), PMSG_HIBERNATE, false); return 0; }