From patchwork Fri Sep 15 08:14:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 724118 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E766EE6446 for ; Fri, 15 Sep 2023 08:23:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232972AbjIOIXp (ORCPT ); Fri, 15 Sep 2023 04:23:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232922AbjIOIXo (ORCPT ); Fri, 15 Sep 2023 04:23:44 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65CB13C25; Fri, 15 Sep 2023 01:22:39 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A171C433B6; Fri, 15 Sep 2023 08:15:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694765737; bh=sIlHLfDcuVxZg7ZHLLtnzVuQhXg3ngq0RMU0PqQTYA4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kz4I8HwXD1YPt7hHIJaEJM5YDSsxMkEeCZWp960rezHbwVOWYK01Ybp9HIWjLPZVJ wipO07vZFmpzZYbytBQkUE63xTV2+CTN3YypRjHvWOU0SfOnwNfBryFQgTctq25p4l HQcm5fXBP4n7yfgTgXHpOVwF19H9lG6UyxLOxHAQ661JIGieoXjCtEtA/6SfGqFgGz wS8kQOoEFLN1lbAIslJx6M0oaJ9PJxuylYcePQWDuJT2VrVdjHWc0Z0KqeYTrchKSM fVRyp4/+SffyAqXaKx9J6qmtn37J214Lrnq+bBTHwGEq3UK0Ri3OLgzFlUEbZlkQNU ZfjDRhX15a1yw== From: Damien Le Moal To: linux-ide@vger.kernel.org Cc: linux-scsi@vger.kernel.org, "Martin K . Petersen" , John Garry , Rodrigo Vivi , Paul Ausbeck , Kai-Heng Feng , Joe Breuer , Geert Uytterhoeven , Chia-Lin Kao Subject: [PATCH v3 15/23] ata: libata-core: Detach a port devices on shutdown Date: Fri, 15 Sep 2023 17:14:59 +0900 Message-ID: <20230915081507.761711-16-dlemoal@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230915081507.761711-1-dlemoal@kernel.org> References: <20230915081507.761711-1-dlemoal@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Modify ata_pci_shutdown_one() to schedule EH to unload a port devices before freezing and thawing the port. This ensures that drives are cleanly disabled and transitioned to standby power mode when a PCI adapter is removed or the system is powered off. Signed-off-by: Damien Le Moal Reviewed-by: Hannes Reinecke Tested-by: Chia-Lin Kao (AceLan) --- drivers/ata/libata-core.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 9f05ad187c9e..7d110e5454bf 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -6168,10 +6168,24 @@ EXPORT_SYMBOL_GPL(ata_pci_remove_one); void ata_pci_shutdown_one(struct pci_dev *pdev) { struct ata_host *host = pci_get_drvdata(pdev); + struct ata_port *ap; + unsigned long flags; int i; + /* Tell EH to disable all devices */ for (i = 0; i < host->n_ports; i++) { - struct ata_port *ap = host->ports[i]; + ap = host->ports[i]; + spin_lock_irqsave(ap->lock, flags); + ap->pflags |= ATA_PFLAG_UNLOADING; + ata_port_schedule_eh(ap); + spin_unlock_irqrestore(ap->lock, flags); + } + + for (i = 0; i < host->n_ports; i++) { + ap = host->ports[i]; + + /* Wait for EH to complete before freezing the port */ + ata_port_wait_eh(ap); ap->pflags |= ATA_PFLAG_FROZEN;