diff mbox series

[2/2] pm80xx: Avoid leaking tags when processing OPC_INB_SET_CONTROLLER_CONFIG command

Message ID 20230911170340.699533-2-mge@meta.com
State Superseded
Headers show
Series [1/2] pm80xx: Use phy specific sas address when sending PHY_START command | expand

Commit Message

Michal Grzedzicki Sept. 11, 2023, 5:03 p.m. UTC 
Tags allocated for OPC_INB_SET_CONTROLLER_CONFIG command need to be freed
when we receive the response.

Signed-off-by: Michal Grzedzicki <mge@meta.com>
---
 drivers/scsi/pm8001/pm80xx_hwi.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jinpu Wang Sept. 13, 2023, 1:42 p.m. UTC | #1 
On Mon, Sep 11, 2023 at 7:03 PM Michal Grzedzicki <mge@meta.com> wrote:
>
> Tags allocated for OPC_INB_SET_CONTROLLER_CONFIG command need to be freed
> when we receive the response.
>
> Signed-off-by: Michal Grzedzicki <mge@meta.com>
can you please add the fixes tag, so stable can pick it accordingly?
Acked-by: Jack Wang <jinpu.wang@ionos.com>
> ---
>  drivers/scsi/pm8001/pm80xx_hwi.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
> index 1b2c40b1381c..3afd9443c425 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
> @@ -3671,10 +3671,12 @@ static int mpi_set_controller_config_resp(struct pm8001_hba_info *pm8001_ha,
>                         (struct set_ctrl_cfg_resp *)(piomb + 4);
>         u32 status = le32_to_cpu(pPayload->status);
>         u32 err_qlfr_pgcd = le32_to_cpu(pPayload->err_qlfr_pgcd);
> +       u32 tag = le32_to_cpu(pPayload->tag);
>
>         pm8001_dbg(pm8001_ha, MSG,
>                    "SET CONTROLLER RESP: status 0x%x qlfr_pgcd 0x%x\n",
>                    status, err_qlfr_pgcd);
> +       pm8001_tag_free(pm8001_ha, tag);
>
>         return 0;
>  }
> --
> 2.34.1
>
diff mbox series

Patch

diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
index 1b2c40b1381c..3afd9443c425 100644
--- a/drivers/scsi/pm8001/pm80xx_hwi.c
+++ b/drivers/scsi/pm8001/pm80xx_hwi.c
@@ -3671,10 +3671,12 @@  static int mpi_set_controller_config_resp(struct pm8001_hba_info *pm8001_ha,
 			(struct set_ctrl_cfg_resp *)(piomb + 4);
 	u32 status = le32_to_cpu(pPayload->status);
 	u32 err_qlfr_pgcd = le32_to_cpu(pPayload->err_qlfr_pgcd);
+	u32 tag = le32_to_cpu(pPayload->tag);
 
 	pm8001_dbg(pm8001_ha, MSG,
 		   "SET CONTROLLER RESP: status 0x%x qlfr_pgcd 0x%x\n",
 		   status, err_qlfr_pgcd);
+	pm8001_tag_free(pm8001_ha, tag);
 
 	return 0;
 }