[v2,7/8] ata: sata_sx4: drop already completed TODO

Message ID	20230720004257.307031-8-nks@flawful.org
State	Superseded
Headers	show Return-Path: <linux-scsi-owner@vger.kernel.org> From: Niklas Cassel <nks@flawful.org> To: Damien Le Moal <dlemoal@kernel.org> Cc: Hannes Reinecke <hare@suse.com>, John Garry <john.g.garry@oracle.com>, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, Niklas Cassel <niklas.cassel@wdc.com> Subject: [PATCH v2 7/8] ata: sata_sx4: drop already completed TODO Date: Thu, 20 Jul 2023 02:42:48 +0200 Message-ID: <20230720004257.307031-8-nks@flawful.org> In-Reply-To: <20230720004257.307031-1-nks@flawful.org> References: <20230720004257.307031-1-nks@flawful.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	libata: remove references to 'old' error handler \| expand [v2,0/8] libata: remove references to 'old' error handler [v2,1/8] ata: remove reference to non-existing error_handler() [v2,2/8] ata,scsi: remove ata_sas_port_{start,stop} callbacks [v2,3/8] ata,scsi: remove ata_sas_port_destroy() [v2,4/8] ata: remove ata_sas_sync_probe() [v2,5/8] ata: inline ata_port_probe() [v2,6/8] ata,scsi: cleanup ata_port_probe() [v2,7/8] ata: sata_sx4: drop already completed TODO [v2,8/8] ata: remove ata_bus_probe()

Message ID

20230720004257.307031-8-nks@flawful.org

State

Superseded

Headers

From: Niklas Cassel <nks@flawful.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Hannes Reinecke <hare@suse.com>,
        John Garry <john.g.garry@oracle.com>,
        linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
        Niklas Cassel <niklas.cassel@wdc.com>
Subject: [PATCH v2 7/8] ata: sata_sx4: drop already completed TODO
Date: Thu, 20 Jul 2023 02:42:48 +0200
Message-ID: <20230720004257.307031-8-nks@flawful.org>
In-Reply-To: <20230720004257.307031-1-nks@flawful.org>
References: <20230720004257.307031-1-nks@flawful.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

libata: remove references to 'old' error handler | expand

Commit Message

Niklas Cassel July 20, 2023, 12:42 a.m. UTC

From: Niklas Cassel <niklas.cassel@wdc.com>

The TODO claims that the pdc_20621_ops should set the .inherits
function pointer to &ata_base_port_ops after it has been converted
to use the new EH.

However, the driver was converted to use the new EH a long time ago,
in commit 67651ee5710c ("[libata] sata_sx4: convert to new exception
handling methods"), which also did set .inherits function pointer to
&ata_sff_port_ops (and ata_sff_port_ops itself has .inherits set to
&ata_base_port_ops).

Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
---
 drivers/ata/sata_sx4.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/ata/sata_sx4.c b/drivers/ata/sata_sx4.c
index ccc016072637..b51d7a9d0d90 100644
--- a/drivers/ata/sata_sx4.c
+++ b/drivers/ata/sata_sx4.c
@@ -232,7 +232,6 @@  static const struct scsi_host_template pdc_sata_sht = {
 	.dma_boundary		= ATA_DMA_BOUNDARY,
 };
 
-/* TODO: inherit from base port_ops after converting to new EH */
 static struct ata_port_operations pdc_20621_ops = {
 	.inherits		= &ata_sff_port_ops,

[v2,7/8] ata: sata_sx4: drop already completed TODO

Commit Message

Patch