From patchwork Sun Feb 20 03:17:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 544368 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26F4AC433EF for ; Sun, 20 Feb 2022 03:18:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243381AbiBTDTE (ORCPT ); Sat, 19 Feb 2022 22:19:04 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:48364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242505AbiBTDS6 (ORCPT ); Sat, 19 Feb 2022 22:18:58 -0500 Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A09B340D3 for ; Sat, 19 Feb 2022 19:18:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1645327117; x=1676863117; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nyw6ZF9z51vXsM5UOyHqddSYZgT8VVrFBo/jONyktvU=; b=D2MvuhWcCWDQfB21xVRX2Okrd5kckVO0dqEKA5FDIoT01O1L8jFh1p5+ 2nB7cO3h4J2AAAsZ2qdf+N93lbyzv382/N+6M5JD0+VduE9nrfde451Mz uSpJoQlRJJHgnJUwtprZiZ3C+ZlLXhLdMIrqz2j3GYjskc8rBkVklWzY8 VGoN6j/pHggkLo6b9E9lob9I98GOTiLGY3Icy59uulYp8Pq5Qz4F0seV1 8EJNPJ9CTh4QI/fje6wkRWCuV/qVfpV/HK/tb3pD3S0YYnCimOUUjuJjO ciMDTwRiEnGbublSo4yLaKVX0hGgXJ4WbjsOLhcSRMhhG6kjsoMtC7VSh w==; X-IronPort-AV: E=Sophos;i="5.88,382,1635177600"; d="scan'208";a="193405779" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 20 Feb 2022 11:18:37 +0800 IronPort-SDR: eb1XbJQ2T6CKDlszDtOMe6RXcWwBihXhulTXlK4RIMi6FPH3PbozVzM7JCxk5q8zOAkq8+7S9V f5LL4HTV+Hcl6CATd2gZDA40RKIvWb6HwSuM//pAcTBhyHu9R1mZtuIWlPR3n50MR0PsQDr043 aBHCxkMqq+o+PCWOaPsiUvW7dwJ3YowcA8PqvDqLFMnpiyTwy5V0SQIbijLhieBvceLnSLhdUx dPuEpndcyf1o26zx4Y4sokOErW63vuFIYbuD4o3E5E+oy83QcV3dViyrB4FC7agBDV0ON+qrQC v6BRlmN0O67w2VAiP6mgQ3Up Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2022 18:50:13 -0800 IronPort-SDR: gT2cKM3C4BAc5qTDkgqVJVmnqdfiQw0q/EqJ6J4LlUgUL23r4W0GLjOGxsEc/K/RPcjsnt57/I 5mMgsH2d4LR/0GKpDXgUK5U9Y4Yro1ck5Kg6kmcOICOC1FeEHfQpsowlcoswR41EWdQPusg3Xl AN4smYfawRlv0xJEUBZ6KYe77bMqp8QqtLKcy9cGosu2s7HGTcGNb+A1hBjp8vPM3qnOGt2bT+ PvamqfV/ck6TzXPMM3Yg7YUY8erIbvSPODuEt0/GvsFwHmui3o7XrABOIZxxp8ftccRWiK+y/R 2iQ= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2022 19:18:38 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4K1Vy55rz5z1SVp3 for ; Sat, 19 Feb 2022 19:18:37 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:mime-version :references:in-reply-to:x-mailer:message-id:date:subject:to :from; s=dkim; t=1645327117; x=1647919118; bh=nyw6ZF9z51vXsM5UOy HqddSYZgT8VVrFBo/jONyktvU=; b=krv7gxHcc+bqBh8TwR2pRU4uHkxhUdO/ZN 6+U61mKp5wIwY8xtYt8o5kJrtCgMFkPM4j7UMkO7tlGQPNBW9pFLPK+/ViaHg07u 3VBPPqz5sDiHJpBiPk62+LdPRbQH6qmWJVOHHGFvH3QaBfaxyKf/fJvgqxmCsYQN RpX0eQDa7zQfiBUTVlcj/v4SU9k/97BbuvMAnaJpR0aWUAyVhsXH9EADkUENStj1 5NUflcZD83FPBZuU2F5kxQaSNRINwJu5GbUDCj7tf9AVbbd0aFQs/OsCaa4XXcum hEitbd86jK7xFeXrPCkDmjo69seNFFjio6IIVdTq7Rkd7A+c4Xkg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id C0a6-NK6M6lZ for ; Sat, 19 Feb 2022 19:18:37 -0800 (PST) Received: from washi.fujisawa.hgst.com (washi.fujisawa.hgst.com [10.149.53.254]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4K1Vy40lt9z1Rvlx; Sat, 19 Feb 2022 19:18:35 -0800 (PST) From: Damien Le Moal To: linux-scsi@vger.kernel.org, "Martin K . Petersen" , Jack Wang , John Garry Cc: Xiang Chen , Jason Yan , Luo Jiaxing Subject: [PATCH v6 16/31] scsi: pm8001: Fix abort all task initialization Date: Sun, 20 Feb 2022 12:17:55 +0900 Message-Id: <20220220031810.738362-17-damien.lemoal@opensource.wdc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220220031810.738362-1-damien.lemoal@opensource.wdc.com> References: <20220220031810.738362-1-damien.lemoal@opensource.wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org In pm80xx_send_abort_all(), the n_elem field of the ccb used is not initialized to 0. This missing initialization sometimes lead to the task completion path seeing the ccb with a non-zero n_elem resulting in the execution of invalid dma_unmap_sg() calls in pm8001_ccb_task_free(), causing a crash such as: [ 197.676341] RIP: 0010:iommu_dma_unmap_sg+0x6d/0x280 [ 197.700204] RSP: 0018:ffff889bbcf89c88 EFLAGS: 00010012 [ 197.705485] RAX: dffffc0000000000 RBX: 0000000000000000 RCX: ffffffff83d0bda0 [ 197.712687] RDX: 0000000000000002 RSI: 0000000000000000 RDI: ffff88810dffc0d0 [ 197.719887] RBP: 0000000000000000 R08: 0000000000000000 R09: ffff8881c790098b [ 197.727089] R10: ffffed1038f20131 R11: 0000000000000001 R12: 0000000000000000 [ 197.734296] R13: ffff88810dffc0d0 R14: 0000000000000010 R15: 0000000000000000 [ 197.741493] FS: 0000000000000000(0000) GS:ffff889bbcf80000(0000) knlGS:0000000000000000 [ 197.749659] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 197.755459] CR2: 00007f16c1b42734 CR3: 0000000004814000 CR4: 0000000000350ee0 [ 197.762656] Call Trace: [ 197.765127] [ 197.767162] pm8001_ccb_task_free+0x5f1/0x820 [pm80xx] [ 197.772364] ? do_raw_spin_unlock+0x54/0x220 [ 197.776680] pm8001_mpi_task_abort_resp+0x2ce/0x4f0 [pm80xx] [ 197.782406] process_oq+0xe85/0x7890 [pm80xx] [ 197.786817] ? lock_acquire+0x194/0x490 [ 197.790697] ? handle_irq_event+0x10e/0x1b0 [ 197.794920] ? mpi_sata_completion+0x2d70/0x2d70 [pm80xx] [ 197.800378] ? __wake_up_bit+0x100/0x100 [ 197.804340] ? lock_is_held_type+0x98/0x110 [ 197.808565] pm80xx_chip_isr+0x94/0x130 [pm80xx] [ 197.813243] tasklet_action_common.constprop.0+0x24b/0x2f0 [ 197.818785] __do_softirq+0x1b5/0x82d [ 197.822485] ? do_raw_spin_unlock+0x54/0x220 [ 197.826799] __irq_exit_rcu+0x17e/0x1e0 [ 197.830678] irq_exit_rcu+0xa/0x20 [ 197.834114] common_interrupt+0x78/0x90 [ 197.840051] [ 197.844236] [ 197.848397] asm_common_interrupt+0x1e/0x40 Avoid this issue by always initializing the ccb n_elem field to 0 in pm8001_send_abort_all(), pm8001_send_read_log() and pm80xx_send_abort_all(). Fixes: c6b9ef5779c3 ("[SCSI] pm80xx: NCQ error handling changes") Signed-off-by: Damien Le Moal Reviewed-by: Jack Wang --- drivers/scsi/pm8001/pm8001_hwi.c | 2 ++ drivers/scsi/pm8001/pm80xx_hwi.c | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c index 35eda16a2743..cfeefdf26f5d 100644 --- a/drivers/scsi/pm8001/pm8001_hwi.c +++ b/drivers/scsi/pm8001/pm8001_hwi.c @@ -1787,6 +1787,7 @@ static void pm8001_send_abort_all(struct pm8001_hba_info *pm8001_ha, ccb->device = pm8001_ha_dev; ccb->ccb_tag = ccb_tag; ccb->task = task; + ccb->n_elem = 0; circularQ = &pm8001_ha->inbnd_q_tbl[0]; @@ -1848,6 +1849,7 @@ static void pm8001_send_read_log(struct pm8001_hba_info *pm8001_ha, ccb->device = pm8001_ha_dev; ccb->ccb_tag = ccb_tag; ccb->task = task; + ccb->n_elem = 0; pm8001_ha_dev->id |= NCQ_READ_LOG_FLAG; pm8001_ha_dev->id |= NCQ_2ND_RLE_FLAG; diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c index ac2178a13e4c..8fd38e54f07c 100644 --- a/drivers/scsi/pm8001/pm80xx_hwi.c +++ b/drivers/scsi/pm8001/pm80xx_hwi.c @@ -1800,6 +1800,7 @@ static void pm80xx_send_abort_all(struct pm8001_hba_info *pm8001_ha, ccb->device = pm8001_ha_dev; ccb->ccb_tag = ccb_tag; ccb->task = task; + ccb->n_elem = 0; circularQ = &pm8001_ha->inbnd_q_tbl[0];