diff mbox series

[07/14] qla2xxx: fix port type info

Message ID 20210805102005.20183-8-njavali@marvell.com
State Superseded
Headers show
Series [01/14] qla2xxx: Add host attribute to trigger MPI hang | expand

Commit Message

Nilesh Javali Aug. 5, 2021, 10:19 a.m. UTC 
From: Quinn Tran <qutran@marvell.com>

Over time, fcport->port_type became flag field. The flags within this field
were not defined properly. This caused external tools to read wrong info.

Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
---
 drivers/scsi/qla2xxx/qla_def.h | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

Comments

Himanshu Madhani Aug. 5, 2021, 3:34 p.m. UTC | #1 
> On Aug 5, 2021, at 5:19 AM, Nilesh Javali <njavali@marvell.com> wrote:
> 
> From: Quinn Tran <qutran@marvell.com>
> 
> Over time, fcport->port_type became flag field. The flags within this field
> were not defined properly. This caused external tools to read wrong info.
> 
> Signed-off-by: Quinn Tran <qutran@marvell.com>
> Signed-off-by: Nilesh Javali <njavali@marvell.com>
> ---
> drivers/scsi/qla2xxx/qla_def.h | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
> index c081bf1c7578..60702d066ed9 100644
> --- a/drivers/scsi/qla2xxx/qla_def.h
> +++ b/drivers/scsi/qla2xxx/qla_def.h
> @@ -2428,11 +2428,9 @@ struct mbx_24xx_entry {
>  */
> typedef enum {
> 	FCT_UNKNOWN,
> -	FCT_RSCN,
> -	FCT_SWITCH,
> -	FCT_BROADCAST,
> -	FCT_INITIATOR,
> -	FCT_TARGET,
> +	FCT_BROADCAST = 0x01,
> +	FCT_INITIATOR = 0x02,
> +	FCT_TARGET    = 0x04,
> 	FCT_NVME_INITIATOR = 0x10,
> 	FCT_NVME_TARGET = 0x20,
> 	FCT_NVME_DISCOVERY = 0x40,
> -- 
> 2.19.0.rc0
> 

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering
diff mbox series

Patch

diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
index c081bf1c7578..60702d066ed9 100644
--- a/drivers/scsi/qla2xxx/qla_def.h
+++ b/drivers/scsi/qla2xxx/qla_def.h
@@ -2428,11 +2428,9 @@  struct mbx_24xx_entry {
  */
 typedef enum {
 	FCT_UNKNOWN,
-	FCT_RSCN,
-	FCT_SWITCH,
-	FCT_BROADCAST,
-	FCT_INITIATOR,
-	FCT_TARGET,
+	FCT_BROADCAST = 0x01,
+	FCT_INITIATOR = 0x02,
+	FCT_TARGET    = 0x04,
 	FCT_NVME_INITIATOR = 0x10,
 	FCT_NVME_TARGET = 0x20,
 	FCT_NVME_DISCOVERY = 0x40,