From patchwork Wed Jun 16 06:37:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461364 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp312996jae; Tue, 15 Jun 2021 23:38:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJYRQ679UcDkyZZSVbyTO8MrPg7UknP1NTgcr1JHFG3jbxf75APu1CbEkRq1OiMPXkQXZa X-Received: by 2002:a05:6402:702:: with SMTP id w2mr2249180edx.189.1623825487789; Tue, 15 Jun 2021 23:38:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825487; cv=none; d=google.com; s=arc-20160816; b=wWWr+Zj4K14Z4yvoTRB92Uy+oeBFmewTWQuFVTB4YseRNzUMte19fOH6SW065YBl4l dmmqs3TOI0dXudB8kjz+I5E9SpJw8ypucO+g+/UHgtpEC3WZNAE84U0f7KZkg9s4fwR/ Qieby1Z7GdlX4OYXWGMsPLQlCb0E+yUAuBPpvf4ZBX9Y3+ScPTRh7eEV8Cbjd5IS7h+S cFfKMMnO1UnnIXDexvfh5NMEyvhXBIDOOhOBeEDiWvPEuDJIHw7N/2vKxB7f/HTaGOKI alZzNFgVGpcumS19VDWDDodlfQ4EjUseXAaXES4kqYbQaCayHAmFXkTlt/XPQbNKwZAK gFtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=/wlRl3TBaoSLV54r1hZCailEG/H/XszSkTSPdg31hH4=; b=wslsd2MywtqQmlhGZr42UM+A9m14g64GZUq0IlI3l5V0RoNSfbs9e5fCbULacqk86C cxU0e1gqrSejAIabaQ4MMevER+MHtA8s+7YJKyCQy6OJFiYvzVBZIdjG9oqS+jo/otQJ uoPEgkjzqYDxdpKmvDdjMUismMFGWWbRgE6dz22wL0EpSBqs0nxwXKZZDxSSVYwU4gkd fRN/cdk7JkLstkVjZcUmun3HLnrC31mqL04QNk9hD9PtSlDyyQ646k/+CmI2J3NFOw0S ptjIjLTqe6qy7bFJUNHxn387QrvZObZKmzrqT/omoqh9nEKD/FAV4kp5xfvqllPPttmI Cryw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.38.07 for ; Tue, 15 Jun 2021 23:38:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231593AbhFPGkL (ORCPT ); Wed, 16 Jun 2021 02:40:11 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:7324 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231489AbhFPGkG (ORCPT ); Wed, 16 Jun 2021 02:40:06 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4G4b4T1crCz6y7X; Wed, 16 Jun 2021 14:34:01 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:00 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:59 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 12/20] scsi: ipr: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:37:06 +0800 Message-ID: <20210616063714.778-13-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/ipr.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c index 30c30a1db5b1aa0..b99f55e9897af1b 100644 --- a/drivers/scsi/ipr.c +++ b/drivers/scsi/ipr.c @@ -4364,11 +4364,8 @@ static int ipr_alloc_dump(struct ipr_ioa_cfg *ioa_cfg) unsigned long lock_flags = 0; dump = kzalloc(sizeof(struct ipr_dump), GFP_KERNEL); - - if (!dump) { - ipr_err("Dump memory allocation failed\n"); + if (!dump) return -ENOMEM; - } if (ioa_cfg->sis64) ioa_data = vmalloc(array_size(IPR_FMT3_MAX_NUM_DUMP_PAGES,