| Message ID | 20210616063714.778-12-thunder.leizhen@huawei.com |
|---|---|
| State | New |
| Headers | show
Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp312977jae; Tue, 15 Jun 2021 23:38:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzc3YjwxrUQzIMo3czUedkVQPNudyQjFj0VDflA9unCUk24ZKGxZyHGl6VxSrs4fq8D0fg X-Received: by 2002:aa7:c04d:: with SMTP id k13mr2278135edo.122.1623825486750; Tue, 15 Jun 2021 23:38:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825486; cv=none; d=google.com; s=arc-20160816; b=gBURYpcqXHSp31m/+lIuOjmGAbhHoSwwNexGX/irn0kRtfrUJbmpDoD5M6zFzOWv0O 0C4dtKwuncyS8rTzl2NMNs4ihr0JFC7T5p02+6zEJ9ypCBxvhBcj3AUqjMyU+r4IsAlI JsXfHROwrTnqqm9/6yfMOe/3kcVKLekHD0i9xKAvu8Kua02oYM5JCbjltczF1p/BzLO3 MT2yUjkQwylpkRnli45g2wIRm4Mcsw3NT4kIX8C7w6YtKIOkcFOGbMTQouoi8kericZw snl1+8p+WkIFZE/Oqn7ChAd1+f/cX9VJUSeIYIUcobTQK2H24jVdbwASS1xWMC0EnTeO rNdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=2M7iuCd6gFThOmDY2FWzvdki4Jwct0c/bU97sCAKNfM=; b=OXGiY9fRFloTKvjdHEYASu86hbIGZacrx2sLUSJabcOlwgxUZZsXDeWu8AjV+jrZra Seapcg603D3WYgpQ5QOYanYhD7CCiCYa8nm8QZz0nLq9VJYnkBwgfmVpmbWXrqqOARVd my+QOXtcXSSB0gIS862HrXWmYoaMqGkBFom41KEt49PodJNdvVGnLzHzFiOwYc/klKv4 uWvYaVx577Itf8wiDXMKKXOuxu3wzuXAWsQ2yg89ElBEEww1N+ZN8hXO0tvZse83TzCc 4JD7k7gF2CKfsMfqW1zVJ8MjX7reWRE2muMVre2ubx1FArVtDJRGg//Q6UqTmHxU/OKM 6gVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: <linux-scsi-owner@vger.kernel.org> Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.38.06 for <patch@linaro.org>; Tue, 15 Jun 2021 23:38:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231484AbhFPGkK (ORCPT <rfc822;patch@linaro.org>); Wed, 16 Jun 2021 02:40:10 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:4796 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231453AbhFPGkF (ORCPT <rfc822; linux-scsi@vger.kernel.org>); Wed, 16 Jun 2021 02:40:05 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4G4b3G1kfvzWt4m; Wed, 16 Jun 2021 14:32:58 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:59 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:58 +0800 From: Zhen Lei <thunder.leizhen@huawei.com> To: Vishal Bhakta <vbhakta@vmware.com>, VMware PV-Drivers <pv-drivers@vmware.com>, Karan Tilak Kumar <kartilak@cisco.com>, "Sesidhar Baddela" <sebaddel@cisco.com>, Nilesh Javali <njavali@marvell.com>, GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>, "Adaptec OEM Raid Solutions" <aacraid@microsemi.com>, Brian King <brking@us.ibm.com>, Satish Kharat <satishkh@cisco.com>, Hannes Reinecke <hare@suse.de>, "Manish Rangankar" <mrangankar@marvell.com>, Adam Radford <aradford@gmail.com>, "James E . J . Bottomley" <jejb@linux.ibm.com>, "Martin K . Petersen" <martin.petersen@oracle.com>, linux-scsi <linux-scsi@vger.kernel.org> CC: Zhen Lei <thunder.leizhen@huawei.com> Subject: [PATCH v2 11/20] scsi: ips: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:37:05 +0800 Message-ID: <20210616063714.778-12-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: <linux-scsi.vger.kernel.org> X-Mailing-List: linux-scsi@vger.kernel.org |
| Series |
scsi: remove unnecessary oom message
|
expand
|
diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c index bc33d54a40112a1..5a242247b8b52d7 100644 --- a/drivers/scsi/ips.c +++ b/drivers/scsi/ips.c @@ -1685,10 +1685,8 @@ ips_flash_copperhead(ips_ha_t * ha, ips_passthru_t * pt, ips_scb_t * scb) pt->CoppCP.cmd.flashfw.count; ha->flash_data = dma_alloc_coherent(&ha->pcidev->dev, datasize, &ha->flash_busaddr, GFP_KERNEL); - if (!ha->flash_data){ - printk(KERN_WARNING "Unable to allocate a flash buffer\n"); + if (!ha->flash_data) return IPS_FAILURE; - } ha->flash_datasize = 0; ha->flash_len = datasize; } else
Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- drivers/scsi/ips.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.26.0.106.g9fadedd