From patchwork Sun Apr 11 06:27:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Avri Altman X-Patchwork-Id: 419419 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97DC1C433ED for ; Sun, 11 Apr 2021 06:28:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71D4B6101B for ; Sun, 11 Apr 2021 06:28:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235185AbhDKG2l (ORCPT ); Sun, 11 Apr 2021 02:28:41 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:37436 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235017AbhDKG2k (ORCPT ); Sun, 11 Apr 2021 02:28:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1618122506; x=1649658506; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WPqT2rdAevYmQxqfinYFjjtoO19TlVzPnQtPtcAtiZM=; b=U2/0grjaOfPUYmCFuy7/eEL3mG/LOhruYMxLPjTlTx+QRKtxy3KdVWF9 jXKd3JfUILFFvmDmNppZ8tXyU3ABxyiWclh+sZasqm4HlPl+e72FwnuHp Y87H2GRWHthYVrUmt9Oux12wgUL1SBN9RpQpvqL48TFyHz/iDHcSlRWPG 8vucDgGdMMTyhFXWpi3YhA8KR/1sTWLrKMDdpH1swBPoIpG+wS545b9Ms CAiekSGC0hAm//3VIQeV6RHMCHCQkCNerrYoYzOiJMiKFDhm3DwxGKIDV I+EBTFn8bghhSGp1pW3U294ehY9cxfMWPxlS6kW5nl4RjdDMskOAtDqN2 w==; IronPort-SDR: C/Wxzi2GAAEmowyRxc9zX2nEGRXijKqGCMqQCicXpEoPzDGhhmTaShUHnTOFC86r0Ogs4ajs2k cFCyUUsWJtyon87rX3z2IlF3Jj6G+C+E3AE8wPKjQ1rzM5+ZFh+fecpcv83pSE0+0vBydNHTgO qlFFaEHAbG8dwqNtizYbNP2kKOVNUNbZonJjAKxQsyfz9slnnPkm+8Pc6lbPIcPH4MwwvSs7hN LZpiTeQYGvhWqZ+H5hWDBBmv5StOOaq8yBvKZOv+fVr4GFi8QLdddoFKXsn7leK0BjRY9UpXQH Sy0= X-IronPort-AV: E=Sophos;i="5.82,213,1613404800"; d="scan'208";a="165243139" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 11 Apr 2021 14:28:04 +0800 IronPort-SDR: 1AygAaqfeIfkX47F3bbv2Uo1KkiOZs+R5caRG8Is+zQqthfuyIhK6zXmQ5EFH4U1mlZPqw2GOh WlOpl8viqpuYZA3oRpWQuEpt9eOel+hXeVXeIUu5tvbN/uymy+hq0uIB+LhfUAAThbDPqFFdwg FgmZBSW6z1OB8Qvneytx0dMuuzFuGdNGFp+TGV6gCurLdFWV+o6oWLwHmnNy790ciX26kJVd8w g0hoL59g2ApNOtePPAEEGaaYGml4ZSMlkFmYKHxjCl6EwqBXccIIagxstsK82MouwNtURzfLe+ 9bb0jFSB2zoUqqT93Ow29axc Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2021 23:09:01 -0700 IronPort-SDR: k4LiYqI3aXs7VMzlYynluVJULslQLtOqJChTMF0h9Sc3MYVHTfg+08iKCzJB0hLOn9VGNGEswW Rau5xy4S5LvzOGlRkC0gvhh7/Fp/PqtNgnpBiNFzoCdC1I0SHL1cg9irDnM86GT5etMJiTFM0h qw+IJx3ucAMgbfgA+rNzjgtthhPRmSQRAUAFGFPRqK/p31OyhAzR4AucAVDqSYcuQntU1z/CT9 /eogH7SzKJLs1/W1T1zyBSoQCUp4OnAvh9s8Lezku8y45ig6tmOWb3Jxk9Suv/U/U7J6fZ8Fxq m9w= WDCIronportException: Internal Received: from bxygm33.sdcorp.global.sandisk.com ([10.0.231.247]) by uls-op-cesaip02.wdc.com with ESMTP; 10 Apr 2021 23:27:50 -0700 From: Avri Altman To: "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, Bart Van Assche , yongmyung lee , Daejun Park , alim.akhtar@samsung.com, asutoshd@codeaurora.org, Zang Leigang , Avi Shchislowski , Bean Huo , cang@codeaurora.org, stanley.chu@mediatek.com, Avri Altman Subject: [PATCH v8 02/11] scsi: ufshpb: Add host control mode support to rsp_upiu Date: Sun, 11 Apr 2021 09:27:12 +0300 Message-Id: <20210411062721.10099-3-avri.altman@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210411062721.10099-1-avri.altman@wdc.com> References: <20210411062721.10099-1-avri.altman@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org In device control mode, the device may recommend the host to either activate or inactivate a region, and the host should follow. Meaning those are not actually recommendations, but more of instructions. On the contrary, in host control mode, the recommendation protocol is slightly changed: a) The device may only recommend the host to update a subregion of an already-active region. And, b) The device may *not* recommend to inactivate a region. Furthermore, in host control mode, the host may choose not to follow any of the device's recommendations. However, in case of a recommendation to update an active and clean subregion, it is better to follow those recommendation because otherwise the host has no other way to know that some internal relocation took place. Signed-off-by: Avri Altman Reviewed-by: Daejun Park --- drivers/scsi/ufs/ufshpb.c | 34 +++++++++++++++++++++++++++++++++- drivers/scsi/ufs/ufshpb.h | 2 ++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c index 5285a50b05dd..6111019ca31a 100644 --- a/drivers/scsi/ufs/ufshpb.c +++ b/drivers/scsi/ufs/ufshpb.c @@ -166,6 +166,8 @@ static void ufshpb_set_ppn_dirty(struct ufshpb_lu *hpb, int rgn_idx, else set_bit_len = cnt; + set_bit(RGN_FLAG_DIRTY, &rgn->rgn_flags); + if (rgn->rgn_state != HPB_RGN_INACTIVE && srgn->srgn_state == HPB_SRGN_VALID) bitmap_set(srgn->mctx->ppn_dirty, srgn_offset, set_bit_len); @@ -235,6 +237,11 @@ static bool ufshpb_test_ppn_dirty(struct ufshpb_lu *hpb, int rgn_idx, return false; } +static inline bool is_rgn_dirty(struct ufshpb_region *rgn) +{ + return test_bit(RGN_FLAG_DIRTY, &rgn->rgn_flags); +} + static int ufshpb_fill_ppn_from_page(struct ufshpb_lu *hpb, struct ufshpb_map_ctx *mctx, int pos, int len, u64 *ppn_buf) @@ -712,6 +719,7 @@ static void ufshpb_put_map_req(struct ufshpb_lu *hpb, static int ufshpb_clear_dirty_bitmap(struct ufshpb_lu *hpb, struct ufshpb_subregion *srgn) { + struct ufshpb_region *rgn; u32 num_entries = hpb->entries_per_srgn; if (!srgn->mctx) { @@ -725,6 +733,10 @@ static int ufshpb_clear_dirty_bitmap(struct ufshpb_lu *hpb, num_entries = hpb->last_srgn_entries; bitmap_zero(srgn->mctx->ppn_dirty, num_entries); + + rgn = hpb->rgn_tbl + srgn->rgn_idx; + clear_bit(RGN_FLAG_DIRTY, &rgn->rgn_flags); + return 0; } @@ -1244,6 +1256,18 @@ static void ufshpb_rsp_req_region_update(struct ufshpb_lu *hpb, srgn_i = be16_to_cpu(rsp_field->hpb_active_field[i].active_srgn); + rgn = hpb->rgn_tbl + rgn_i; + if (hpb->is_hcm && + (rgn->rgn_state != HPB_RGN_ACTIVE || is_rgn_dirty(rgn))) { + /* + * in host control mode, subregion activation + * recommendations are only allowed to active regions. + * Also, ignore recommendations for dirty regions - the + * host will make decisions concerning those by himself + */ + continue; + } + dev_dbg(&hpb->sdev_ufs_lu->sdev_dev, "activate(%d) region %d - %d\n", i, rgn_i, srgn_i); @@ -1251,7 +1275,6 @@ static void ufshpb_rsp_req_region_update(struct ufshpb_lu *hpb, ufshpb_update_active_info(hpb, rgn_i, srgn_i); spin_unlock(&hpb->rsp_list_lock); - rgn = hpb->rgn_tbl + rgn_i; srgn = rgn->srgn_tbl + srgn_i; /* blocking HPB_READ */ @@ -1262,6 +1285,14 @@ static void ufshpb_rsp_req_region_update(struct ufshpb_lu *hpb, hpb->stats.rb_active_cnt++; } + if (hpb->is_hcm) { + /* + * in host control mode the device is not allowed to inactivate + * regions + */ + goto out; + } + for (i = 0; i < rsp_field->inactive_rgn_cnt; i++) { rgn_i = be16_to_cpu(rsp_field->hpb_inactive_field[i]); dev_dbg(&hpb->sdev_ufs_lu->sdev_dev, @@ -1286,6 +1317,7 @@ static void ufshpb_rsp_req_region_update(struct ufshpb_lu *hpb, hpb->stats.rb_inactive_cnt++; } +out: dev_dbg(&hpb->sdev_ufs_lu->sdev_dev, "Noti: #ACT %u #INACT %u\n", rsp_field->active_rgn_cnt, rsp_field->inactive_rgn_cnt); diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h index 7df30340386a..032672114881 100644 --- a/drivers/scsi/ufs/ufshpb.h +++ b/drivers/scsi/ufs/ufshpb.h @@ -121,6 +121,8 @@ struct ufshpb_region { /* below information is used by lru */ struct list_head list_lru_rgn; + unsigned long rgn_flags; +#define RGN_FLAG_DIRTY 0 }; #define for_each_sub_region(rgn, i, srgn) \