From patchwork Wed Mar 17 09:12:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 403085 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp294580jai; Wed, 17 Mar 2021 02:14:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUW7PJKNB7+AbBSrbzrz8A+/oPwUleeL4sKUgu4Gfhx+KvNjC5wK7YFbD+TU0JI5s0AwdU X-Received: by 2002:a17:906:4801:: with SMTP id w1mr12565200ejq.475.1615972442971; Wed, 17 Mar 2021 02:14:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615972442; cv=none; d=google.com; s=arc-20160816; b=0psFYj7aYcku2ZroToLLhfHbnY6zBgt2fmC/b0lKLAJ/TDzK4fhJMWMgDq1sOrQUl5 oiKsG/0R6OmYnw6ghsZ6+7jagJcbltPiILOgucbXD+kmCnmdNrK2ZWnNeoXacm8EuhOy 9VLLQCT9qTEd9w3NBUr8iaNFQELUjAWJHk/OX320md5cuySoAxoIwAVc6SBWQjfm+0jP 4Zss3ruzt5QDNATTafNBNdhZm+uQHGfCnAfTaFxqe7I+McaauGO1LabdlbLdyOhGbJ18 TVq/rjlh1+UXKk5bJmLun0n9rggnYeJ87Dq0fuUKtHUyk2ycZS6xYU3YIjLahi5WHnr+ 2OSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mmVm22Z3SbJdFCwvYkYccZgvkOVfVFM6WIi4/sN6y+8=; b=Sk5VWeAF+T9HRV+fEbDK+hQHu5PuI5Nvb/VCzar9HsNQzNRF89RGeFOhy51tc4+P07 QfJsyQlgTJpWE+ilmrDQNhwdKS6Ul78jlzbOcLp3pITkGIGmCq2oQ/b/rVUZyrb3wAlY qdqPurPDwX5RNhwS6ue1SSkKLRbg88nJZwj070ZbYrXCO3UqZIRLZXkgL+PgzdngdxPg CRLsVlNSoWNFn9aSqBRinHHq/+Q8FCHVk7qylFOmj28K9mURiSqSDzrUSJDPJFsbUJn8 3mQEDLQ2Mqq4O8DgxUw7CITKLbOMCmXfP20khuu9Ewheqj7oBEwcWZLPDbCtBh+1vslA IhZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=a8vNEuCV; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t15si15461864edq.164.2021.03.17.02.14.02 for ; Wed, 17 Mar 2021 02:14:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=a8vNEuCV; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230266AbhCQJNf (ORCPT ); Wed, 17 Mar 2021 05:13:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230020AbhCQJNA (ORCPT ); Wed, 17 Mar 2021 05:13:00 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CA8AC061762 for ; Wed, 17 Mar 2021 02:12:51 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id r10-20020a05600c35cab029010c946c95easo831806wmq.4 for ; Wed, 17 Mar 2021 02:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mmVm22Z3SbJdFCwvYkYccZgvkOVfVFM6WIi4/sN6y+8=; b=a8vNEuCVQ+NCgglSdOUubA+3RisCfA1ki5nIjhK0BEddlRmSgWfN4sHriI2fdIdBuf 8Pth22d+tt8RMPzpAZgGELwc2SBNboK2J+nKe9KsqiWyQ4cA7PskHQm7w7o/JsxyWwVT 29vbkqQ8w1yQfAI6qmM5cbLoZvHf4PL21ialqbZEr4YwjN2AtvXQqShzQFugx7uhQqUM hJaaLDDaQ4Sx3IdKTqHHtOUwWq7Kx3oKDrmROilDu+Cf3gYXsjbJJ1/rxe5YPLvQS8Od +4CXHI4DRZ9GOdwFBK0H8+bw6MMhPyqS3DuHLRxlc5xfC6hxEzEt5AcLoqkg68mr3nq1 EyfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mmVm22Z3SbJdFCwvYkYccZgvkOVfVFM6WIi4/sN6y+8=; b=syvN6HGGW1REoQgzcvxHlU06+SDJP/pA6+u0Pac2LXBGyhlQ5B/qVng3UjRMEwmqf4 bWSEz3SGnBlvjis9hAwrh5MaiwO4R7WYdQzAcjiNjx2rZeGtph0UCEF3+hN1/JfwlRH+ 36cQxB3KZOEi5I6AIbWIrvS4fJ4d+cZkbj5HB+CwVWGFZBT+tjXmpKQUkUuxJGCObwIT ATkH2a07qllrWDUY8UBqvZyTW4RPYIFVL8xXKIXwQ4zd0Yi36fQ2kthYfuzz4dtp5vFh /IoDQVdwVW/6HmA2X1naZURqVUhBNX+yFK0jLAWIUvgNt818vNGiwYHYYbuZzLYlom83 E1lQ== X-Gm-Message-State: AOAM531Z7RcFA/BTW+p5JHYlDcgV1p6LsK9T6j8q4NdqTXIk5KUx7A3C sOSfCuZJq9XdE3vIGctS9ELqrw== X-Received: by 2002:a7b:cc85:: with SMTP id p5mr2759000wma.148.1615972369955; Wed, 17 Mar 2021 02:12:49 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id e18sm12695886wru.73.2021.03.17.02.12.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 02:12:49 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , Bas Vermeulen , Christoph Hellwig , Brian Macy , linux-scsi@vger.kernel.org Subject: [PATCH 10/36] scsi: initio: Fix a few kernel-doc misdemeanours Date: Wed, 17 Mar 2021 09:12:04 +0000 Message-Id: <20210317091230.2912389-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317091230.2912389-1-lee.jones@linaro.org> References: <20210317091230.2912389-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/initio.c:560: warning: Excess function parameter 'num_scbs' description in 'initio_init' drivers/scsi/initio.c:1899: warning: expecting prototype for int_initio_scsi_resel(). Prototype was for int_initio_resel() instead drivers/scsi/initio.c:2615: warning: expecting prototype for i91u_queuecommand(). Prototype was for i91u_queuecommand_lck() instead drivers/scsi/initio.c:2667: warning: Function parameter or member 'dev' not described in 'i91u_biosparam' drivers/scsi/initio.c:2667: warning: expecting prototype for i91u_biospararm(). Prototype was for i91u_biosparam() instead drivers/scsi/initio.c:2740: warning: Function parameter or member 'host_mem' not described in 'i91uSCBPost' drivers/scsi/initio.c:2740: warning: Function parameter or member 'cblk_mem' not described in 'i91uSCBPost' drivers/scsi/initio.c:2740: warning: Excess function parameter 'host' description in 'i91uSCBPost' drivers/scsi/initio.c:2740: warning: Excess function parameter 'cmnd' description in 'i91uSCBPost' Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Bas Vermeulen Cc: Christoph Hellwig Cc: Brian Macy Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/initio.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) -- 2.27.0 diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c index 926a7045c2e5c..9b75e19a9bab1 100644 --- a/drivers/scsi/initio.c +++ b/drivers/scsi/initio.c @@ -546,7 +546,6 @@ static int initio_reset_scsi(struct initio_host * host, int seconds) /** * initio_init - set up an InitIO host adapter * @host: InitIO host adapter - * @num_scbs: Number of SCBS * @bios_addr: BIOS address * * Set up the host adapter and devices according to the configuration @@ -1887,7 +1886,7 @@ static int int_initio_scsi_rst(struct initio_host * host) } /** - * int_initio_scsi_resel - Reselection occurred + * int_initio_resel - Reselection occurred * @host: InitIO host adapter * * A SCSI reselection event has been signalled and the interrupt @@ -2601,7 +2600,7 @@ static void initio_build_scb(struct initio_host * host, struct scsi_ctrl_blk * c } /** - * i91u_queuecommand - Queue a new command if possible + * i91u_queuecommand_lck - Queue a new command if possible * @cmd: SCSI command block from the mid layer * @done: Completion handler * @@ -2650,9 +2649,9 @@ static int i91u_bus_reset(struct scsi_cmnd * cmnd) } /** - * i91u_biospararm - return the "logical geometry + * i91u_biosparam - return the "logical geometry * @sdev: SCSI device - * @dev; Matching block device + * @dev: Matching block device * @capacity: Sector size of drive * @info_array: Return space for BIOS geometry * @@ -2727,10 +2726,8 @@ static void i91u_unmap_scb(struct pci_dev *pci_dev, struct scsi_cmnd *cmnd) } } -/** +/* * i91uSCBPost - SCSI callback - * @host: Pointer to host adapter control block. - * @cmnd: Pointer to SCSI control block. * * This is callback routine be called when tulip finish one * SCSI command.