diff mbox series

[2/7] pm80xx: Add sysfs attribute to track RAAE count

Message ID 20210224155802.13292-3-Viswas.G@microchip.com
State Superseded
Headers show
Series pm80xx updates | expand

Commit Message

Viswas G Feb. 24, 2021, 3:57 p.m. UTC
From: Vishakha Channapattan <vishakhavc@google.com>

A new sysfs variable 'ctl_raae_count' is being introduced that tells if
the controller is alive by indicating controller ticks. If on subsequent
run we see the ticks changing in RAAE count that indicates that
controller
is not dead.

Tested: Using 'ctl_raae_count' sysfs variable we can see ticks
incrementing
mvae14:~# cat  /sys/class/scsi_host/host*/ctl_raae_count
MSGUTCNT=0x00002245
MSGUTCNT=0x00002253
MSGUTCNT=0x0000225e

Signed-off-by: Vishakha Channapattan <vishakhavc@google.com>
Signed-off-by: Viswas G <Viswas.G@microchip.com>
Signed-off-by: Ruksar Devadi <Ruksar.devadi@microchip.com>
Signed-off-by: Ashokkumar N <Ashokkumar.N@microchip.com>
Signed-off-by: Radha Ramachandran <radha@google.com>
---
 drivers/scsi/pm8001/pm8001_ctl.c | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

Comments

Jinpu Wang March 4, 2021, 9:28 a.m. UTC | #1
On Wed, Feb 24, 2021 at 4:48 PM Viswas G <Viswas.G@microchip.com> wrote:
>

> From: Vishakha Channapattan <vishakhavc@google.com>

>

> A new sysfs variable 'ctl_raae_count' is being introduced that tells if

> the controller is alive by indicating controller ticks. If on subsequent

> run we see the ticks changing in RAAE count that indicates that

> controller

> is not dead.

>

> Tested: Using 'ctl_raae_count' sysfs variable we can see ticks

> incrementing

> mvae14:~# cat  /sys/class/scsi_host/host*/ctl_raae_count

> MSGUTCNT=0x00002245

> MSGUTCNT=0x00002253

> MSGUTCNT=0x0000225e

>

> Signed-off-by: Vishakha Channapattan <vishakhavc@google.com>

> Signed-off-by: Viswas G <Viswas.G@microchip.com>

> Signed-off-by: Ruksar Devadi <Ruksar.devadi@microchip.com>

> Signed-off-by: Ashokkumar N <Ashokkumar.N@microchip.com>

> Signed-off-by: Radha Ramachandran <radha@google.com>

> ---

>  drivers/scsi/pm8001/pm8001_ctl.c | 25 +++++++++++++++++++++++++

>  1 file changed, 25 insertions(+)

>

> diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c

> index 035969ed1c2e..d415bb12718c 100644

> --- a/drivers/scsi/pm8001/pm8001_ctl.c

> +++ b/drivers/scsi/pm8001/pm8001_ctl.c

> @@ -919,6 +919,30 @@ static ssize_t ctl_mpi_state_show(struct device *cdev,

>  }

>  static DEVICE_ATTR_RO(ctl_mpi_state);

>

> +/**

> + * ctl_raae_count_show - controller raae count check

> + * @cdev: pointer to embedded class device

> + * @buf: the buffer returned

> + *

> + * A sysfs 'read-only' shost attribute.

> + */

> +

> +static ssize_t ctl_raae_count_show(struct device *cdev,

> +               struct device_attribute *attr, char *buf)

> +{

> +       struct Scsi_Host *shost = class_to_shost(cdev);

> +       struct sas_ha_struct *sha = SHOST_TO_SAS_HA(shost);

> +       struct pm8001_hba_info *pm8001_ha = sha->lldd_ha;

> +       unsigned int raaecnt = 0;

> +       int c;

> +

> +       pm8001_dbg(pm8001_ha, IOCTL, "%s\n", __func__);

> +       raaecnt = pm8001_mr32(pm8001_ha->general_stat_tbl_addr, 12);

> +       c = sprintf(buf, "MSGUTCNT=0x%08x\n", raaecnt);

> +       return c;

> +}

> +static DEVICE_ATTR_RO(ctl_raae_count);

New file should use  sysfs_emit instead of sprintf.
> +

>  struct device_attribute *pm8001_host_attrs[] = {

>         &dev_attr_interface_rev,

>         &dev_attr_controller_fatal_error,

> @@ -943,6 +967,7 @@ struct device_attribute *pm8001_host_attrs[] = {

>         &dev_attr_ila_version,

>         &dev_attr_inc_fw_ver,

>         &dev_attr_ctl_mpi_state,

> +       &dev_attr_ctl_raae_count,

>         NULL,

>  };

>

> --

> 2.16.3

>
diff mbox series

Patch

diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c
index 035969ed1c2e..d415bb12718c 100644
--- a/drivers/scsi/pm8001/pm8001_ctl.c
+++ b/drivers/scsi/pm8001/pm8001_ctl.c
@@ -919,6 +919,30 @@  static ssize_t ctl_mpi_state_show(struct device *cdev,
 }
 static DEVICE_ATTR_RO(ctl_mpi_state);
 
+/**
+ * ctl_raae_count_show - controller raae count check
+ * @cdev: pointer to embedded class device
+ * @buf: the buffer returned
+ *
+ * A sysfs 'read-only' shost attribute.
+ */
+
+static ssize_t ctl_raae_count_show(struct device *cdev,
+		struct device_attribute *attr, char *buf)
+{
+	struct Scsi_Host *shost = class_to_shost(cdev);
+	struct sas_ha_struct *sha = SHOST_TO_SAS_HA(shost);
+	struct pm8001_hba_info *pm8001_ha = sha->lldd_ha;
+	unsigned int raaecnt = 0;
+	int c;
+
+	pm8001_dbg(pm8001_ha, IOCTL, "%s\n", __func__);
+	raaecnt = pm8001_mr32(pm8001_ha->general_stat_tbl_addr, 12);
+	c = sprintf(buf, "MSGUTCNT=0x%08x\n", raaecnt);
+	return c;
+}
+static DEVICE_ATTR_RO(ctl_raae_count);
+
 struct device_attribute *pm8001_host_attrs[] = {
 	&dev_attr_interface_rev,
 	&dev_attr_controller_fatal_error,
@@ -943,6 +967,7 @@  struct device_attribute *pm8001_host_attrs[] = {
 	&dev_attr_ila_version,
 	&dev_attr_inc_fw_ver,
 	&dev_attr_ctl_mpi_state,
+	&dev_attr_ctl_raae_count,
 	NULL,
 };