| Message ID | 20201002040518.1224-1-shipujin.t@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] scsi: ufs: Use memset to initialize variable in ufshcd_crypto_keyslot_program | expand |
On Fri, Oct 02, 2020 at 12:05:17PM +0800, Pujin Shi wrote: > Clang warns: > > drivers/scsi/ufs/ufshcd-crypto.c:62:8: warning: missing braces around initializer [-Wmissing-braces] > union ufs_crypto_cfg_entry cfg = { 0 }; > ^ > Which version of clang? I don't see the warning with clang 10.0.1 (or with gcc 10.2.0). > Signed-off-by: Pujin Shi <shipujin.t@gmail.com> > --- > drivers/scsi/ufs/ufshcd-crypto.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/ufs/ufshcd-crypto.c b/drivers/scsi/ufs/ufshcd-crypto.c > index d2edbd960ebf..8fca2a40c517 100644 > --- a/drivers/scsi/ufs/ufshcd-crypto.c > +++ b/drivers/scsi/ufs/ufshcd-crypto.c > @@ -59,9 +59,11 @@ static int ufshcd_crypto_keyslot_program(struct blk_keyslot_manager *ksm, > u8 data_unit_mask = key->crypto_cfg.data_unit_size / 512; > int i; > int cap_idx = -1; > - union ufs_crypto_cfg_entry cfg = { 0 }; > + union ufs_crypto_cfg_entry cfg; > int err; > > + memset(&cfg, 0, sizeof(cfg)); > + How about an empty initializer? union ufs_crypto_cfg_entry cfg = {}; Same comments on your other patch. - Eric
diff --git a/drivers/scsi/ufs/ufshcd-crypto.c b/drivers/scsi/ufs/ufshcd-crypto.c index d2edbd960ebf..8fca2a40c517 100644 --- a/drivers/scsi/ufs/ufshcd-crypto.c +++ b/drivers/scsi/ufs/ufshcd-crypto.c @@ -59,9 +59,11 @@ static int ufshcd_crypto_keyslot_program(struct blk_keyslot_manager *ksm, u8 data_unit_mask = key->crypto_cfg.data_unit_size / 512; int i; int cap_idx = -1; - union ufs_crypto_cfg_entry cfg = { 0 }; + union ufs_crypto_cfg_entry cfg; int err; + memset(&cfg, 0, sizeof(cfg)); + BUILD_BUG_ON(UFS_CRYPTO_KEY_SIZE_INVALID != 0); for (i = 0; i < hba->crypto_capabilities.num_crypto_cap; i++) { if (ccap_array[i].algorithm_id == alg->ufs_alg &&
Clang warns: drivers/scsi/ufs/ufshcd-crypto.c:62:8: warning: missing braces around initializer [-Wmissing-braces] union ufs_crypto_cfg_entry cfg = { 0 }; ^ Signed-off-by: Pujin Shi <shipujin.t@gmail.com> --- drivers/scsi/ufs/ufshcd-crypto.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)