From patchwork Tue Aug 25 06:43:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javed Hasan X-Patchwork-Id: 257856 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79CF2C433DF for ; Tue, 25 Aug 2020 06:46:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4230D2076C for ; Tue, 25 Aug 2020 06:46:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="ZqdBHpMN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729111AbgHYGqX (ORCPT ); Tue, 25 Aug 2020 02:46:23 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:30138 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729076AbgHYGqW (ORCPT ); Tue, 25 Aug 2020 02:46:22 -0400 Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07P6Tf2x009543 for ; Mon, 24 Aug 2020 23:46:20 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0220; bh=9Y7Wv+xeqa2nfgu1J5GLuS0mWA8JsRJdCUugvFul97U=; b=ZqdBHpMNOwqaR0ghqULrWf62yi9817pb5HahsaEhOmczezkUvqfcSK3YxA042T0m8hH+ OORqRxrBY9VLotMAKtYTayWnwIx9mMWBdCOnPVsRIktdXLxjprSx7wDV3rmnG+df49vg Rqj/7ZP9oBi/75FEX99pBha9+hLE9BIIIp7RCDvJxMGeJtrcxFUG8NFuD773jWo88CW1 Y4gL+JTvvOPKXSmRQHbW+ZpmLJlACAX2KooORMczaZCxRR3OStFUIEnqDKmg23bMrvfS 7OFvC6Sjo8qcXGXCsSD5iw1bhXYk8/vQzSE0MAxWJO4ekeeY0pwzO5+vLgqnIJl32bA+ gA== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 3332vmtc3d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Mon, 24 Aug 2020 23:46:20 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 24 Aug 2020 23:46:19 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 24 Aug 2020 23:46:19 -0700 Received: from dut1171.mv.qlogic.com (unknown [10.112.88.18]) by maili.marvell.com (Postfix) with ESMTP id 1DDF03F703F; Mon, 24 Aug 2020 23:46:19 -0700 (PDT) Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id 07P6kIFq016442; Mon, 24 Aug 2020 23:46:18 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id 07P6kIcT016433; Mon, 24 Aug 2020 23:46:18 -0700 From: Javed Hasan To: CC: , , Subject: [PATCH 5/8] qedf: Return SUCCESS if stale rport in encounteredon eh_abort. Date: Mon, 24 Aug 2020 23:43:51 -0700 Message-ID: <20200825064354.16361-6-jhasan@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20200825064354.16361-1-jhasan@marvell.com> References: <20200825064354.16361-1-jhasan@marvell.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-08-24_12:2020-08-24,2020-08-24 signatures=0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org From: Saurav Kashyap -If SUCCESS is not return, it can get escalated. Hence, return SUCCESS similar to other conditions. Signed-off-by: Saurav Kashyap Signed-off-by: Javed Hasan --- drivers/scsi/qedf/qedf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index bf1b755..50af70a 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -704,7 +704,7 @@ static int qedf_eh_abort(struct scsi_cmnd *sc_cmd) rdata = fcport->rdata; if (!rdata || !kref_get_unless_zero(&rdata->kref)) { QEDF_ERR(&qedf->dbg_ctx, "stale rport, sc_cmd=%p\n", sc_cmd); - rc = 1; + rc = SUCCESS; goto out; }