From patchwork Tue Jul 21 16:41:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 246936 Delivered-To: patch@linaro.org Received: by 2002:a54:2c11:0:0:0:0:0 with SMTP id g17csp2712991ecp; Tue, 21 Jul 2020 09:44:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzohdR6cXN8EyUIx2zFjn4HswkwO7IPRNvHga1bj+F7ywOBQTBAsOT8vZqfx5Z4/Tgp2QdQ X-Received: by 2002:a17:906:b16:: with SMTP id u22mr25564325ejg.53.1595349895668; Tue, 21 Jul 2020 09:44:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595349895; cv=none; d=google.com; s=arc-20160816; b=MKaCeT145WclINbo5DHHGKR6M/SiYopURjufddNZJFNYKJKzW6e5sinvu6Rb5sVOUk vtWxsdKHee1uR15Xc4DuNNWwj/ZGAWfMqqgsKquh9RQtdVT6PqS1cWTYv/YsU6qZJ6cs RiL6RX5vgWN+TgGuQ7rO6dyqFxBVFsAiscacQuJhbLzIFGRIL2jqD40VNeNxGZtmT/U+ CufxzZqY6Zo9B4R3Mj60qIQMvWPW5mCfcjYvd8njkEFXZF9m84zNDgTPAI3ENUp0XbmU iwEIXSgIwfYa+eOFFYhpTU6QRRGFIhw056lJrmNoPcZkteLYtLh5DwC9jhpGttNb2WgG 8aHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=QQB8TJQzsYjUZBwJPjslVDnhdOA5qUDUD1fBX7WXUPw=; b=eEWq9mIZsN7ZcxY+BIO/YH+AaTYZ1BkSiSK8q+QfqdtuXx02OHXmc4/rWFhuk5dTzx m747r2d+4ipHEwDVq/vQlmAnc6X2mSDfyoSh+oQWrnmzk/Y/GCE9MGHQMD1VhgrJnyOI +/knJ/a+YghS0A3iR57Oh1qrTkHsWtsjkDoRsKeJpWMeqhS2sbzk6y3hd7KktKXPeLrj ALl/N0VbvapNe9GmNrimL2TsUbQfCyPPoRj6CNXbjUxhiFabnCdHwAMgon31NbiHpxix CdzC8q7x1dPWgxPZvZSJG+zjyyZvAxsw4YOgDRMsfsKm/2l3t5GaKrZwKopK4t9hM22/ kROw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=s6AauQ8n; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ni7si12494282ejb.725.2020.07.21.09.44.55 for ; Tue, 21 Jul 2020 09:44:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=s6AauQ8n; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730392AbgGUQmA (ORCPT ); Tue, 21 Jul 2020 12:42:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730341AbgGUQl5 (ORCPT ); Tue, 21 Jul 2020 12:41:57 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80ED7C0619DB for ; Tue, 21 Jul 2020 09:41:57 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id f7so21869084wrw.1 for ; Tue, 21 Jul 2020 09:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QQB8TJQzsYjUZBwJPjslVDnhdOA5qUDUD1fBX7WXUPw=; b=s6AauQ8n56Hd4FuksA+gkR8KcO9HBr/y6WUo10QyX3zvi4KAoo8+pZGmdak7ERDzuV 99OYlw2c0rBlQcpHR5AP7iL5o0uYUuAffpzjEfw7am78q86szC6f5DAuBHh4UWEVjoaO hSAA3xaX/ctyBuWRAMXgf97VJQ9wjV5RUV+B5njvjm5ttZorOXk4ij2gxsK5T8JReCsW twGHiGASNEmU9FKGC5yO3ToaNDbFNWjGipKnR3HXaUrMrP395Z+Zit3sOPKYSMfpO8Wo 3Jzy0Z+UVwiIFRyAyq5TfgPoW+nAPdnV3CLV27XK5GtLjCYXHJHegxTAkNfRibTaN0Pv B86g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QQB8TJQzsYjUZBwJPjslVDnhdOA5qUDUD1fBX7WXUPw=; b=lTbdxu+YPS0dRvSJnQSuXT/aIvS+Im7oW3llyvMK1tF8jGyswtL3TJkb0MRN7HVdt6 JEyExDuXBq3CIbr7nRU3rJyu/1HstvIvB3uXwmP6Dvr17ji515l/WDCG3pLzzGQXrl35 +a7ESJI5yQJxD85vQs7FBmLQhdtrrOhOqhymw9CShw+MDj3M+kBb5JKAgIevBC5PcsYG 5eSM9TpJu/UGiy0L3ZrFx3MZvi+neDvqVQnaFduS8/JA7H25NF3zCXkmsbeIv4DlfMa6 ucD069hTwLFyafV0D6qjqBUIiaP2NOeXeFnZVJ5EzPELdofRERmcxVtMJ8Y2idTvRLGB SQQA== X-Gm-Message-State: AOAM533nsZdC8W6OSWX7UozvZ1Y0UcoeqYiY2aFMPmY6hMt8yChwXQgl vTNEzMeS9tc1FB0c0pGsAkRCVA== X-Received: by 2002:adf:97c1:: with SMTP id t1mr1257176wrb.294.1595349716252; Tue, 21 Jul 2020 09:41:56 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id m4sm3933524wmi.48.2020.07.21.09.41.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2020 09:41:55 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Adaptec OEM Raid Solutions , "PMC-Sierra, Inc" Subject: [PATCH 03/40] scsi: aacraid: sa: Add descriptions for missing parameters Date: Tue, 21 Jul 2020 17:41:11 +0100 Message-Id: <20200721164148.2617584-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200721164148.2617584-1-lee.jones@linaro.org> References: <20200721164148.2617584-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Also clean-up some white space issues while we're here. Fixes the following W=1 kernel build warning(s): drivers/scsi/aacraid/sa.c:147: warning: Function parameter or member 'p2' not described in 'sa_sync_cmd' drivers/scsi/aacraid/sa.c:147: warning: Function parameter or member 'p3' not described in 'sa_sync_cmd' drivers/scsi/aacraid/sa.c:147: warning: Function parameter or member 'p4' not described in 'sa_sync_cmd' drivers/scsi/aacraid/sa.c:147: warning: Function parameter or member 'p5' not described in 'sa_sync_cmd' drivers/scsi/aacraid/sa.c:147: warning: Function parameter or member 'p6' not described in 'sa_sync_cmd' drivers/scsi/aacraid/sa.c:147: warning: Function parameter or member 'r1' not described in 'sa_sync_cmd' drivers/scsi/aacraid/sa.c:147: warning: Function parameter or member 'r2' not described in 'sa_sync_cmd' drivers/scsi/aacraid/sa.c:147: warning: Function parameter or member 'r3' not described in 'sa_sync_cmd' drivers/scsi/aacraid/sa.c:147: warning: Function parameter or member 'r4' not described in 'sa_sync_cmd' drivers/scsi/aacraid/sa.c:290: warning: Function parameter or member 'dev' not described in 'aac_sa_ioremap' Cc: Adaptec OEM Raid Solutions Cc: "PMC-Sierra, Inc" Signed-off-by: Lee Jones --- drivers/scsi/aacraid/sa.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) -- 2.25.1 diff --git a/drivers/scsi/aacraid/sa.c b/drivers/scsi/aacraid/sa.c index aa5d7638cade2..c9a1dad2f5636 100644 --- a/drivers/scsi/aacraid/sa.c +++ b/drivers/scsi/aacraid/sa.c @@ -135,13 +135,21 @@ static void aac_sa_notify_adapter(struct aac_dev *dev, u32 event) * @dev: Adapter * @command: Command to execute * @p1: first parameter + * @p2: second parameter + * @p3: third parameter + * @p4: forth parameter + * @p5: fifth parameter + * @p6: sixth parameter * @ret: adapter status + * @r1: first return value + * @r2: second return value + * @r3: third return value + * @r4: forth return value * - * This routine will send a synchronous command to the adapter and wait + * This routine will send a synchronous command to the adapter and wait * for its completion. */ - -static int sa_sync_cmd(struct aac_dev *dev, u32 command, +static int sa_sync_cmd(struct aac_dev *dev, u32 command, u32 p1, u32 p2, u32 p3, u32 p4, u32 p5, u32 p6, u32 *ret, u32 *r1, u32 *r2, u32 *r3, u32 *r4) { @@ -283,6 +291,7 @@ static int aac_sa_check_health(struct aac_dev *dev) /** * aac_sa_ioremap + * @dev: device to ioremap * @size: mapping resize request * */ @@ -300,8 +309,8 @@ static int aac_sa_ioremap(struct aac_dev * dev, u32 size) * aac_sa_init - initialize an ARM based AAC card * @dev: device to configure * - * Allocate and set up resources for the ARM based AAC variants. The - * device_interface in the commregion will be allocated and linked + * Allocate and set up resources for the ARM based AAC variants. The + * device_interface in the commregion will be allocated and linked * to the comm region. */