From patchwork Tue Jul 21 16:41:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 246927 Delivered-To: patch@linaro.org Received: by 2002:a54:2c11:0:0:0:0:0 with SMTP id g17csp2712642ecp; Tue, 21 Jul 2020 09:44:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz6dIkH6WTtNGoQ/3rRT3FMDdhPOqxpyUcSVYVSbFC/QfRRdbd+NS2gnHcYkjICwrIlYwCK X-Received: by 2002:a05:6402:1d35:: with SMTP id dh21mr27650997edb.186.1595349863222; Tue, 21 Jul 2020 09:44:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595349863; cv=none; d=google.com; s=arc-20160816; b=nq8r82P/Mrn5R5gNusWJrYzpvLm11cBw4TilUA2ElB/7dKi8h5lWoMTey9CDyfnADh zcYv11M6i3Aw73/AYFHl/SerdHhIeRmwWh3IC0Wsscwgpfa373iisnJ0lF5ig3kYcuFO ujJPAe9AbeqoPt7SaPHUaVR2yUKfURNNSIXknf+FdUry7KGLRJYdWyX6OXp55PuwQJk9 pJ6MEcFokn0Kw17ky7+p96GDcqKRrdZjaNGMPDdllmp8JKhsp6ytje++fE7HG16/z6IS VdqHRmUhKgz9W/LuiHRKRpL1jq+Cdih0PBBuIPK53P8+Cxkee+GXfhN3VothDpGkY7iV timw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/DfSYRPuRwDcPXXqc0SkXKNuKhOq3WxfJnslE6gkykI=; b=bcEaloqg6q5Osquofs2AWs230J+R9FLLl8zXhrsND2mqEJpDwDNxgqgiq7/SHGQHn7 KiaOoB2nDFfSuGQyRqj7e0mJaIFhkHTNH0s8J/trsb0+J85XrIna8J689UcizMaPr9M7 g5RTOzeKZ9boB3m51JiCoPlPGBsK12/KqGCfPjI/CpNphIJ7HtdKT+EksyIeJRaRPJbB CRCgXe7FxrTGXgGpn9qY4ntesQ585lhzJVpuuTvZ7o4mPLSMvHADmriwWreazK4k93By 37AuDVnUit9YC1t/glKujx83sbv078lPXOqrSnzZShixzE+FlfK5XodBCZ2uM9XdbmCw msuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OobXBbuj; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k10si14060252ejr.155.2020.07.21.09.44.23 for ; Tue, 21 Jul 2020 09:44:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OobXBbuj; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730311AbgGUQoT (ORCPT ); Tue, 21 Jul 2020 12:44:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730663AbgGUQmZ (ORCPT ); Tue, 21 Jul 2020 12:42:25 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5141DC0619DA for ; Tue, 21 Jul 2020 09:42:25 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id f18so3544924wml.3 for ; Tue, 21 Jul 2020 09:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/DfSYRPuRwDcPXXqc0SkXKNuKhOq3WxfJnslE6gkykI=; b=OobXBbuj8BXy7mxmqZ9lX3C6YZTdndsi68EQRxDPxDSwvzxVt94A1vr9qebthKSX1E BSkIMCjgIQ6E6GmrSI09RyBhj1JSIZ/hBcjTF79Sc5FY5DjB7JmuHTqPmliMEs15EPqu oQmSniWokczz+cHa6qzQWZNx3zxSwq6kKvgTv5WGCC02AvUm7R4/J7jpiJ8LYNBrt9jQ EKyXMgmeSAGjBa5g9d1vvyqa8lF+2334CXDSHWnN/YyCNFnxnVjan8hn1ezjAV7WngP+ fX2D6NI4rvxEim8PZUjsFVI8kBUttfPPpK4M5RIQ87JxJoNLgQH7xFiJY9HhNVwXEP7Y /6zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/DfSYRPuRwDcPXXqc0SkXKNuKhOq3WxfJnslE6gkykI=; b=RGyuls5MlnFRMW5gqR2uwKThHLVow80mhFOEzwk1LpbMYYGzc6I3KisIv9Y4Cav6Zz lhXCafSIlV49dPmCd/StFmZa3+qK9GtqtsxyrOrC4yKVxseUkNL0Hn0+qvjimYSNSTmC mByysqVN2E8pellHcqVsyv9h655i6lWwR5cXAs7f8pL3wYv3XEMMDgZS89pCXcekHhFg xSRWGIlQqOc9svyCOUGjttdsaCpNXvMfW94otgyvQ+ovJwjcYugRlUhCV7IZOPeAlXo6 aqPMLEMq9vHtoJgmaYdP3IoeQqymZiWoRweVsKZD2E5kcEgBdxOutH8X/cSjCyDYR7xV 49zw== X-Gm-Message-State: AOAM530so2RCK+dMdLrBaMm69mvj2Thj3GdtEp669GImXMkCNKFsDuSY tspjOQGLmofQxY6HUUy/c7+dcR2cVeM= X-Received: by 2002:a05:600c:204d:: with SMTP id p13mr4778452wmg.88.1595349744035; Tue, 21 Jul 2020 09:42:24 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id m4sm3933524wmi.48.2020.07.21.09.42.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2020 09:42:23 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@qlogic.com Subject: [PATCH 19/40] scsi: qla4xxx: ql4_nx: Move 'qla4_82xx_reg_tbl' to the only place its used Date: Tue, 21 Jul 2020 17:41:27 +0100 Message-Id: <20200721164148.2617584-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200721164148.2617584-1-lee.jones@linaro.org> References: <20200721164148.2617584-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/scsi/qla4xxx/ql4_def.h:43, from drivers/scsi/qla4xxx/ql4_mbx.c:9: drivers/scsi/qla4xxx/ql4_nx.h:602:23: warning: ‘qla4_82xx_reg_tbl’ defined but not used [-Wunused-const-variable=] 602 | static const uint32_t qla4_82xx_reg_tbl[] = { | ^~~~~~~~~~~~~~~~~ [...] NB: Lots of these Cc: QLogic-Storage-Upstream@qlogic.com Signed-off-by: Lee Jones --- drivers/scsi/qla4xxx/ql4_nx.h | 17 ----------------- drivers/scsi/qla4xxx/ql4_os.c | 17 +++++++++++++++++ 2 files changed, 17 insertions(+), 17 deletions(-) -- 2.25.1 diff --git a/drivers/scsi/qla4xxx/ql4_nx.h b/drivers/scsi/qla4xxx/ql4_nx.h index 98fe78613eb7b..b7a6e7f169ca9 100644 --- a/drivers/scsi/qla4xxx/ql4_nx.h +++ b/drivers/scsi/qla4xxx/ql4_nx.h @@ -599,23 +599,6 @@ enum qla_regs { QLA8XXX_CRB_TEMP_STATE, }; -static const uint32_t qla4_82xx_reg_tbl[] = { - QLA82XX_PEG_HALT_STATUS1, - QLA82XX_PEG_HALT_STATUS2, - QLA82XX_PEG_ALIVE_COUNTER, - QLA82XX_CRB_DRV_ACTIVE, - QLA82XX_CRB_DEV_STATE, - QLA82XX_CRB_DRV_STATE, - QLA82XX_CRB_DRV_SCRATCH, - QLA82XX_CRB_DEV_PART_INFO, - QLA82XX_CRB_DRV_IDC_VERSION, - QLA82XX_FW_VERSION_MAJOR, - QLA82XX_FW_VERSION_MINOR, - QLA82XX_FW_VERSION_SUB, - CRB_CMDPEG_STATE, - CRB_TEMP_STATE, -}; - /* Every driver should use these Device State */ #define QLA8XXX_DEV_COLD 1 #define QLA8XXX_DEV_INITIALIZING 2 diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 27064c602dc70..2572f7aef8f88 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -188,6 +188,23 @@ static int qla4xxx_sysfs_ddb_logout_sid(struct iscsi_cls_session *cls_sess); static struct qla4_8xxx_legacy_intr_set legacy_intr[] = QLA82XX_LEGACY_INTR_CONFIG; +static const uint32_t qla4_82xx_reg_tbl[] = { + QLA82XX_PEG_HALT_STATUS1, + QLA82XX_PEG_HALT_STATUS2, + QLA82XX_PEG_ALIVE_COUNTER, + QLA82XX_CRB_DRV_ACTIVE, + QLA82XX_CRB_DEV_STATE, + QLA82XX_CRB_DRV_STATE, + QLA82XX_CRB_DRV_SCRATCH, + QLA82XX_CRB_DEV_PART_INFO, + QLA82XX_CRB_DRV_IDC_VERSION, + QLA82XX_FW_VERSION_MAJOR, + QLA82XX_FW_VERSION_MINOR, + QLA82XX_FW_VERSION_SUB, + CRB_CMDPEG_STATE, + CRB_TEMP_STATE, +}; + static const uint32_t qla4_83xx_reg_tbl[] = { QLA83XX_PEG_HALT_STATUS1, QLA83XX_PEG_HALT_STATUS2,