From patchwork Mon Jul 13 07:59:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235350 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp2617432ilg; Mon, 13 Jul 2020 01:01:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5Q28GNNo0hLDKaJsj2pGKJLkBM8MHaBrVRh911npSwHKzxQSBcTxtFpUMbWKCqcD9BQV0 X-Received: by 2002:a17:906:1e85:: with SMTP id e5mr64150463ejj.76.1594627266384; Mon, 13 Jul 2020 01:01:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594627266; cv=none; d=google.com; s=arc-20160816; b=DhvujRYov0Rxx1agtCveOIrZAnvmL7zmY17rPVbHH+FYbpDCgVaDcC0YdMkA1lW7Dq cNdtW4uE1fjpk2dKh3Q6ab5rTuRXhKB158Ip9EsC58Ogccd+6fIWFr+WaIRSTniDKSa0 YoNlurxjmWBAKUueENXWGzLHtUCKvqHZPURv+sVYZkhCLhNTDrMr8B4KYS93biDzqkYU llnIH+GbdyfA2t8RCDg2sQlbN3ScJoAq/pxZGGPhymQNvd4ujI/baw/eBA0R2oVr/LQn OOa0DjO+SXof73CfJN0xZ7kfqeICPGtGHk5YooA35dSQXiJzk8L47hCjM3OuyNy/lbkh tQNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9ZgkQ7bdc1wuAXRYHhS8n4ys9/FLwMulTL97bGrK6Pg=; b=GjvlIbyesrRheyPLvjkVYJRmvrCK1vd7Cc9JGbTIygnNNVMe59L7Qj+UpWz62EwyK8 1VjfHnlMJUTGh7K+NeTxSpcYcUR5ZnoXrZVm8Chu3k99v+AxGT2jpF/lc62Se+0lgKnr 6zw2nPoBlEiq6Vg6C5uDVQNUlo1ZPxVtyeyaQD5d48KtawHNBKolrM5kSIXrxBCNia5v xYGvP+hlLdM5TYCYpmsW3WABLMBTtkFWUoWK+hGKONbu/jLdDCO+KNeWfayz3KPM9Pfl QxNiJlQSbffP96cToP3sE7EQwq1ffT1Xop3WweWAnokR9O3ef6CiOll+Fyfn4Jh9MQrG cymA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=baJtv+z+; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d26si9235704edz.108.2020.07.13.01.01.06 for ; Mon, 13 Jul 2020 01:01:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=baJtv+z+; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729543AbgGMIBF (ORCPT ); Mon, 13 Jul 2020 04:01:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729353AbgGMIA3 (ORCPT ); Mon, 13 Jul 2020 04:00:29 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAD78C08C5DB for ; Mon, 13 Jul 2020 01:00:28 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id a6so14743700wrm.4 for ; Mon, 13 Jul 2020 01:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9ZgkQ7bdc1wuAXRYHhS8n4ys9/FLwMulTL97bGrK6Pg=; b=baJtv+z+i4BdwY1fkELNipK3Dnb5fnGWphS0Xgl7xgPQoanLW/l0N/wuHE0Ktb2aC8 oZG/F0tbD7fS7sCeVK6xguclTpNWCxHyxsh/29qRaCm9jld5xT4LT3B4riMznNeH7+q9 VWEN0Arkpaw8BzFJ01UWbsK19U67y4UkEkcvByynvlIKeUuQaRC49nKAHicBCCTkaa2b NT7zn2rMDd5xXHZVLzMJjji4yQSvW03xcLrfm/WV5q3Rs4V4eoyvBPRhrUGl/Ju/FNhF VCFPOda9DRUnL7uqPv/r9binxhL1Dt1CBLVgtho/8Ce/yI+ZRNNpbkcGTf7QEdE/J8Ms IKzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9ZgkQ7bdc1wuAXRYHhS8n4ys9/FLwMulTL97bGrK6Pg=; b=e7QUAf8Wtv2eS2GofkiVLMd9WvsPYZ+IWq5gqIZ8l8iPeJlQr4wL+yPgaGod2lJ5RT m9ZklYc1++opJAXmNdfPjdBYmikVHZxZQgY/r6a3Xi5KyyBURJTqI+CtFH7HUNAA5MvX KAk3WonVvpeSrjH5wSrNzRHyMvB9MqZuoTJIaYxgAi/E/g2ov+tB1OFWOqBrFkmHREvQ /43ADBHPmzjec0WrtwM9WKR4ot64t2tuVRQHF6xcfmLj91637HI18XgcYr52I9JLHxub iKTXpu8jQeK9vP99EmzSjNLlfaaVN700JMEMKQdGsOKYzsWk9/Rqk1q8a8+d9cZOenK5 N1QQ== X-Gm-Message-State: AOAM532YtjBwBPTkSlnSWe+n5iZosM7vC47y62qcMiz33UpW+fY0XjPg oS7xvYov9GS/t16BGJPLTX2fRw== X-Received: by 2002:a5d:6288:: with SMTP id k8mr76209953wru.373.1594627227678; Mon, 13 Jul 2020 01:00:27 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.6]) by smtp.gmail.com with ESMTPSA id 33sm24383549wri.16.2020.07.13.01.00.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 01:00:27 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Subbu Seetharaman , Ketan Mukadam , Jitendra Bhivare , linux-drivers@broadcom.com Subject: [PATCH v2 18/24] scsi: be2iscsi: be_main: Fix misdocumentation of 'pcontext' Date: Mon, 13 Jul 2020 08:59:55 +0100 Message-Id: <20200713080001.128044-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200713080001.128044-1-lee.jones@linaro.org> References: <20200713080001.128044-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Also demote unintentional kerneldoc header. Fixes the following W=1 kernel build warning(s): drivers/scsi/be2iscsi/be_main.c:986: warning: Function parameter or member 'pcontext' not described in 'alloc_wrb_handle' drivers/scsi/be2iscsi/be_main.c:986: warning: Excess function parameter 'pwrb_context' description in 'alloc_wrb_handle' drivers/scsi/be2iscsi/be_main.c:1409: warning: Function parameter or member 'beiscsi_conn' not described in 'beiscsi_complete_pdu' drivers/scsi/be2iscsi/be_main.c:1409: warning: Function parameter or member 'phdr' not described in 'beiscsi_complete_pdu' drivers/scsi/be2iscsi/be_main.c:1409: warning: Function parameter or member 'pdata' not described in 'beiscsi_complete_pdu' drivers/scsi/be2iscsi/be_main.c:1409: warning: Function parameter or member 'dlen' not described in 'beiscsi_complete_pdu' Cc: Subbu Seetharaman Cc: Ketan Mukadam Cc: Jitendra Bhivare Cc: linux-drivers@broadcom.com Signed-off-by: Lee Jones --- drivers/scsi/be2iscsi/be_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.1 diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 9b81cfbbc5c53..8dc2e0824ad78 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -977,7 +977,7 @@ beiscsi_get_wrb_handle(struct hwi_wrb_context *pwrb_context, * alloc_wrb_handle - To allocate a wrb handle * @phba: The hba pointer * @cid: The cid to use for allocation - * @pwrb_context: ptr to ptr to wrb context + * @pcontext: ptr to ptr to wrb context * * This happens under session_lock until submission to chip */ @@ -1394,7 +1394,7 @@ static void hwi_complete_cmd(struct beiscsi_conn *beiscsi_conn, spin_unlock_bh(&session->back_lock); } -/** +/* * ASYNC PDUs include * a. Unsolicited NOP-In (target initiated NOP-In) * b. ASYNC Messages