From patchwork Mon Jul 13 07:46:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235324 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp2611385ilg; Mon, 13 Jul 2020 00:48:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRV6qA9FN2EMkTKtHYAwO6f1od9NYZODxOapEq6wX7s2UvjZkQ/ksoKeP9hvSLf2Sbo3BJ X-Received: by 2002:a17:906:6b8d:: with SMTP id l13mr71986752ejr.136.1594626503164; Mon, 13 Jul 2020 00:48:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594626503; cv=none; d=google.com; s=arc-20160816; b=IqW3kwUa1b/Q7csrrY5SGei8E+AmUw9uxhR9/T18OBPHG8BZAmVlf3RZhMTKEACpBI nhAhEUPtP//UCQ5O2YKlQqwaJ5aNf9u+riEB8Z4+4q3N2CYN9RSAY+gGcezHVEI9merH px3HHvBXPjrrteSbQsqbtgwNUwmunj7ebiLLLDgdFh5B/MA41lUU6C8LZoGJaMBz0jn4 Jjbb8jGmEBRETO4+nFenyquSmXrxvyjXloUQG6S3A/bnnSuvoyIx8D7lMaqNdnUfXLUA mRMpjClNaDghIqxq2AFWNTLbZGpfVoiDXzFg8dkFWozApsmAVYEbIaM6yFbrOg0Ie99z G06Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rsv1890EAaVy29cSOpHY+htSuPNyhdWUNl+08rJAqiI=; b=Z3eMxZolN78e+eAKG/DalcKMccT3jtwBlSeO7/hmErdZkdHpPFcRoZt/XTTqDzMPqI Y6sQyaLzbztZt4lY7+rJFvMpfgHMcwT77JNOjwvnFMs8DriLLFEe+MA/891U3GUzbtKD PGQq4MVG5fi2LDJ6Wm++7qPI2RPf05GdIOJfqlsk/RAJEPImLxzyU75dYb/LoVwiHD9Q 3S8qqDFZKMFJk8knOoSN9SzOsnEkhkg9GiwMRZpEpg9JVlSdVpSDiJL36pzrpm3H8Qc/ f8bsnkjtNit10cxZ254tUPIg5l5rtcnmF/rl4yG+KIAK9O4HUsNOcUk88liZRugiPDMP CiMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ntBIcsLk; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l4si9513464edi.316.2020.07.13.00.48.22 for ; Mon, 13 Jul 2020 00:48:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ntBIcsLk; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729584AbgGMHsT (ORCPT ); Mon, 13 Jul 2020 03:48:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729249AbgGMHrH (ORCPT ); Mon, 13 Jul 2020 03:47:07 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D840C08C5DF for ; Mon, 13 Jul 2020 00:47:07 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id z15so14648574wrl.8 for ; Mon, 13 Jul 2020 00:47:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rsv1890EAaVy29cSOpHY+htSuPNyhdWUNl+08rJAqiI=; b=ntBIcsLkqlyxYanzlfC2o1xlo6Ee7AL4sI/5CvVsDBQG26dGWUk4Q40RjQJ7gs5anB rxovhh6wJ9o+YYM+zaze8u60YveI9FzLur/49aOY4Bi7mDHnEJHPqadeTji0qiBM8DMx 5O2jYjgUcgXCCKdXvVh7grHzr6kGvWLOlcNwoRoPNkdzOEcckh7/RjDSi5RE5v4IpJGM mW6yxKma4yTybwzHNJ6bvxKQK5Jq5lzVA0hYJQJ+2gYzeCXuDvm9Pjrlrh45B6ZUVMnr icpuurgf/2KXjBDKjL1R+EXbjy6dyE+fUGGSeNRlXsZgo6xLEPXQ8fF3qxFNaw6lxk5c DOqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rsv1890EAaVy29cSOpHY+htSuPNyhdWUNl+08rJAqiI=; b=g/n4Y/WEhsycRU3eJcYg3uIfewKLqlTMCBA0K8btVG8IswNqYpDQOYgxzN9MKpBoY4 NXmTypPEEvfrotpcbkZN8ccRbdFHdcN2XQlf/mE7JGRbS3FJt7i9HuJczr6Jp5YJRAnC BM+rkd3Xt6T3tq/uwXjwo0BQvfufm6zBE1EW47E+udmTOQuODz3lTICUCR/mut+dvU3P 2ZwTT51sAp8XRVGovwTrBmnNHcj3873xKqo2VSjMOKR4Cc39msyxrT0VgJr3a9ahN8tK w+5WUPHz6ceGI08b/5uugnvum0B+H+pnk/LUhr/BLfmIxmvID9F+9cfrw6EEcmumsF6S 9tCw== X-Gm-Message-State: AOAM530kL0LqChd6H/NKuwjMxlm4k7ZGk3r6yDYLKKVJVB1wkVhixYM6 6FECUGIkaU1EHRz/N4zIZJA2e60cgFQ= X-Received: by 2002:adf:dc90:: with SMTP id r16mr79169289wrj.264.1594626425952; Mon, 13 Jul 2020 00:47:05 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.6]) by smtp.gmail.com with ESMTPSA id k11sm25142488wrd.23.2020.07.13.00.47.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 00:47:05 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@qlogic.com, Prakash Gollapudi Subject: [PATCH v2 17/29] scsi: bnx2fc: bnx2fc_tgt: Demote obvious misuse of kerneldoc to standard comment blocks Date: Mon, 13 Jul 2020 08:46:33 +0100 Message-Id: <20200713074645.126138-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200713074645.126138-1-lee.jones@linaro.org> References: <20200713074645.126138-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org No attempt has been made to document either of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/scsi/bnx2fc/bnx2fc_tgt.c:442: warning: Function parameter or member 'lport' not described in 'bnx2fc_rport_event_handler' drivers/scsi/bnx2fc/bnx2fc_tgt.c:442: warning: Function parameter or member 'rdata' not described in 'bnx2fc_rport_event_handler' drivers/scsi/bnx2fc/bnx2fc_tgt.c:442: warning: Function parameter or member 'event' not described in 'bnx2fc_rport_event_handler' drivers/scsi/bnx2fc/bnx2fc_tgt.c:665: warning: Function parameter or member 'hba' not described in 'bnx2fc_alloc_session_resc' drivers/scsi/bnx2fc/bnx2fc_tgt.c:665: warning: Function parameter or member 'tgt' not described in 'bnx2fc_alloc_session_resc' Cc: QLogic-Storage-Upstream@qlogic.com Cc: Prakash Gollapudi Signed-off-by: Lee Jones --- drivers/scsi/bnx2fc/bnx2fc_tgt.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) -- 2.25.1 diff --git a/drivers/scsi/bnx2fc/bnx2fc_tgt.c b/drivers/scsi/bnx2fc/bnx2fc_tgt.c index 50384b4a817c8..a3e2a38aabf2f 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_tgt.c +++ b/drivers/scsi/bnx2fc/bnx2fc_tgt.c @@ -431,7 +431,7 @@ static int bnx2fc_init_tgt(struct bnx2fc_rport *tgt, return 0; } -/** +/* * This event_callback is called after successful completion of libfc * initiated target login. bnx2fc can proceed with initiating the session * establishment. @@ -656,9 +656,8 @@ static void bnx2fc_free_conn_id(struct bnx2fc_hba *hba, u32 conn_id) spin_unlock_bh(&hba->hba_lock); } -/** - *bnx2fc_alloc_session_resc - Allocate qp resources for the session - * +/* + * bnx2fc_alloc_session_resc - Allocate qp resources for the session */ static int bnx2fc_alloc_session_resc(struct bnx2fc_hba *hba, struct bnx2fc_rport *tgt)