From patchwork Wed Jul 8 12:02:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235073 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp369985ilg; Wed, 8 Jul 2020 05:03:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoVRZxC6slXxNZZfdtfTUP3PBHZbKi05YJu5bR2w+Qv0krGb0anWSSYXInLSj9UCTxHQOA X-Received: by 2002:a50:fa07:: with SMTP id b7mr64868073edq.298.1594209785127; Wed, 08 Jul 2020 05:03:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594209785; cv=none; d=google.com; s=arc-20160816; b=PdbvBrkrY3lIHV6mFdxkVZcMvk7HAXOtLpR8+MNp7iYnyqRJed1WxRIA9sZ0ynJ4Pf H2HzZ9w5MG84+O2zXzqTG0Z8HIx0PNkNxnmv8dJbaDYGVlxsB3xBTSqaC4WHIPMI/nIH cgT+rSTd0bD7m/4EOTK5p8eGzMVxSrlHbSrAmjGyNQZpQaa3TMPIViv4UUE0ty6EbQHG hMgsy2K7M5086MKaqapO8OAr/qdTILq6CwY9Ni9GQH5yqbj9VwiPEPaIekmp5X+V6I6R 4ghNtYfLDXi2VSqsyZeRepvlvJtMMJAuIbUad2vf0ktsbJ8Ki+Ym3kx7Bvi7ZuChuD// vYig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EfL+TnTwzrxBs3OWsbVJ1u2HNp81yr5D58y8jJwfHCg=; b=TKaxjUkrYii3ecFxeDs8MtPahxuvcN+pj56lpMJA1WLV7hDL0uiXe2czcepXBVKIOb vW8N9BoyGch8L5rIlDBY5PeZxYFvgOpMr2h+u4M4z6K0VrTYIIJuzgM5ZMMUp5TlVz7W MgqgMBrssQFE/0TAaGg+9vEmNv0HvadaquwmD45RURuh+OKV9WPvSMrZ02EmXvhJdQp4 OsDKvnjtXAswm72Rygu4NGWGL1joZwXxEBYtyo2c3dxAKS7YHAGptG5eUlG0j5DqlKHm fBTkEtPV6EMg9v7vRIKSip1aIczJqZJ6pi6+TvGn82DPCqkGL8MRzI620HCCLk27PBS6 oedw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="V7YTg/Nu"; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k13si16033178eji.354.2020.07.08.05.03.04 for ; Wed, 08 Jul 2020 05:03:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="V7YTg/Nu"; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728765AbgGHMDD (ORCPT ); Wed, 8 Jul 2020 08:03:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729186AbgGHMDC (ORCPT ); Wed, 8 Jul 2020 08:03:02 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE32BC08C5DC for ; Wed, 8 Jul 2020 05:03:01 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id b6so48661608wrs.11 for ; Wed, 08 Jul 2020 05:03:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EfL+TnTwzrxBs3OWsbVJ1u2HNp81yr5D58y8jJwfHCg=; b=V7YTg/NuT1ipSiphL7EvNRuTDaXv8eq0KaXXKKSKjl/mC+jCiU36KNbNpr6xipISRd qWZWOid3XF/HdL7CtyOkvOVNsRM4xkEX+fjQAovODTP/W0CIuJkkHlFIFykYxRI9Qvo2 qE8RJ0nwah9EwAlJFf+GPBkJRk63xtzmgOt4P6iT0iahUYwp1gIlsl3MCWmaGO79N5bN y1DSQnGFHBZLQ2sIPBPi+E2ieP2vvs1eA/maPioucGFRuBDhYQtQrlppYxc8xu68qIFj L6IHtoeUfefWuAax+TghGhwH9LCZf0l5eps2R/cZBZljKcjvX9KvozXCeIy4iILmYgId Awwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EfL+TnTwzrxBs3OWsbVJ1u2HNp81yr5D58y8jJwfHCg=; b=ttdWFeYFyowELllEhCsPZPhIc59onOzglgcrRsmt2mfV2UTdsXCmJO/N5GKUT2RNcG odaNWsjId2YaGkiloN511ZfIJpPeCzV5iacgx/cezH7ej0Iaf5TJ6a8BBcPt9ENFbcjm dzrxgRcQYuTx/WI+Th9BXVq1EozetwUJSRj2QNn+hsulfG88ROQYJUw1ydaZSmDwPg3h QX5xXGH4KS62pCUvRrLqZXNVbUjgoNbn9DKUftZwwoGywFyvStSFy3fbDzwo3SNl9tj2 udhIHSrrORjF/J7a0Q0EFQ8UOf3L77XqR5ciE5tj6LTVhImyOcC5wHlJ5z7XYg4HuGN5 rdDA== X-Gm-Message-State: AOAM5339/Ew6yc/W322ama1sLbCdR2ZC1lHIGHBFZrHDg2aTJzt3zJdn phywiXUyzAKaOuEtf5PkOO9Jdg== X-Received: by 2002:a5d:5549:: with SMTP id g9mr61834625wrw.419.1594209780204; Wed, 08 Jul 2020 05:03:00 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:59 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Adaptec OEM Raid Solutions , "PMC-Sierra, Inc" Subject: [PATCH 24/30] scsi: aacraid: linit: Provide suggested curly braces around empty body of if() Date: Wed, 8 Jul 2020 13:02:15 +0100 Message-Id: <20200708120221.3386672-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/aacraid/linit.c: In function ‘aac_biosparm’: drivers/scsi/aacraid/linit.c:368:41: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] 368 | param->heads, param->sectors, num)); | ^ Cc: Adaptec OEM Raid Solutions Cc: "PMC-Sierra, Inc" Signed-off-by: Lee Jones --- drivers/scsi/aacraid/linit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index a308e86a97f19..734dd6e67246d 100644 --- a/drivers/scsi/aacraid/linit.c +++ b/drivers/scsi/aacraid/linit.c @@ -363,9 +363,10 @@ static int aac_biosparm(struct scsi_device *sdev, struct block_device *bdev, param->cylinders = cap_to_cyls(capacity, param->heads * param->sectors); if (num < 4 && end_sec == param->sectors) { - if (param->cylinders != saved_cylinders) + if (param->cylinders != saved_cylinders) { dprintk((KERN_DEBUG "Adopting geometry: heads=%d, sectors=%d from partition table %d.\n", param->heads, param->sectors, num)); + } } else if (end_head > 0 || end_sec > 0) { dprintk((KERN_DEBUG "Strange geometry: heads=%d, sectors=%d in partition table %d.\n", end_head + 1, end_sec, num));