From patchwork Wed Jul 8 12:02:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235083 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp370784ilg; Wed, 8 Jul 2020 05:03:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxnTrKrfF37HZfAvfxF+rRFXe7514qtv1XqlDJ80aS5De1jrL0GQOFdVyVe7U8G20Fc0xVj X-Received: by 2002:a17:906:40d6:: with SMTP id a22mr53227088ejk.133.1594209832733; Wed, 08 Jul 2020 05:03:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594209832; cv=none; d=google.com; s=arc-20160816; b=vhheVOMuIgESlKciyIoT48A9LIVfnpaRvvzXTzLqshWW4C/u02tT89y8PsgoiP3l0x TUtJ1y0nLUOU7SYcOxgFvazDa3nMRJgEG7ZdvjDsAMrtsacY0z0dd5GW+2c+WawfPvoV OZilbtYu0Uzlv7J6BbavZT3lP9Rn25glhS6a1PJvUHUMrUS5dqJPllVPgLp9Ve8xs9Jj bwNWHgnntmAeoTBmm92yMGyysCV/dLiA5XD3NOPpLIRiKVVnuVr1qVAn7RlIqUCXnRRe fw/kfrj8o6zd8IuPkVzcM3PD7pbcqd+0NLdwBZCZdQ9hwGlAu/CwlIpOaGEf2C0ujqEJ MvTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rsv1890EAaVy29cSOpHY+htSuPNyhdWUNl+08rJAqiI=; b=ZO/7dFBCcqUQuBwWRYikvw6fwBHUGlNDOlqi5gWvKHVZ9i3onrj6VuLTPqsdpNvy6m v6HYEPjXmSZ+NY4IvDyLTt1DOnq5i2iLEA6dx52ufQVsaX3yAJPpKYaLBYju+OrsdU7H NHSSGl/BP1aPZBKo7JeYTkAB+ZzrGwtTYdBV4eLRS48Xv+cQZuNOFQlar+00Kz0qYMbg P3iTVNDFLV1nxpwSQKX4tqoxydtRg9s5X93iUXwGrjaEhtc4cpNJLPeahE3lgJj9o3Gm jNTvI9C6b94KyWaAqvdXbLuG3QrWGIQgfpSQQ5Sc5xONbr/vdcQ1qk2cdUjo5Fyc06E0 guxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vRrcLJ4v; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k21si12141416edx.64.2020.07.08.05.03.52 for ; Wed, 08 Jul 2020 05:03:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vRrcLJ4v; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729231AbgGHMDt (ORCPT ); Wed, 8 Jul 2020 08:03:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729141AbgGHMCx (ORCPT ); Wed, 8 Jul 2020 08:02:53 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98D50C08C5DC for ; Wed, 8 Jul 2020 05:02:52 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id j4so46265135wrp.10 for ; Wed, 08 Jul 2020 05:02:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rsv1890EAaVy29cSOpHY+htSuPNyhdWUNl+08rJAqiI=; b=vRrcLJ4vDQL45XkegDFjkvZZg7i76UXflllyN2qZnOq226OkdOjiHe3dbctK+ciSBn gWt/7Pwpd0ep+S4IlbWVMRNd/jxynHNsYOvFF4YJzUTxJ4WRNxA+9Xx+Hga8fCD8h3Kq NjUMJjub0ouBPz11A0fIgcXp8KkYeU0hakOhnTw2D9YgxvZx9AjdDri3FolrNPkWD89E WQUqQpZ1EfyUTEBnP5Xc43TgLsqRxFxs6LmMtoHTj4gDY7oCFlPP7UeQ1vB/MgbnZwnA 62ZNMumMK3DF40ZarEwdRS0gFNj3ETrfBbl55wKEp2PSrEmF76zgNslRZPhokRoIaQps hGPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rsv1890EAaVy29cSOpHY+htSuPNyhdWUNl+08rJAqiI=; b=QObieNg0Nfr68IcCGZ8PgrPgojOhOS7DoNNg4/TwTk2ca6PNr+E9VkTPqFp8Lqtvg6 ViOYNCoDzYl90RrtNi9i9n/YFL9whcx0vxP3YT58MXalPu0MdkyChO3mO5eBaz2i7wFR DnCd/T5YAuaTxf3rYOM9nyRKbRz5tJQUXVMxp76ghs5N61qLJ20UIlHGoEv3iVGe6zJI GZAb/667dnN8OFLiaVc2DITWu4826Z+h4OFUZhFxPWYn8cVPZRIq/2i8yqgaAQNOC9v8 BZ0ANz84sUuaGGZNaTiNy7vSmBYQe+CGgskpigGsb6w0n1kO7iL8Cu1WSGut7ra+C72j a8Mw== X-Gm-Message-State: AOAM531Gdvzyh31xNwVORBye1K1SbaLwdWKf4+9aOBN3XkS1+le7hOqb B1cJ///nr/5y2BqLkAp98GGJKg== X-Received: by 2002:adf:e948:: with SMTP id m8mr59728702wrn.398.1594209771378; Wed, 08 Jul 2020 05:02:51 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:50 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@qlogic.com, Prakash Gollapudi Subject: [PATCH 18/30] scsi: bnx2fc: bnx2fc_tgt: Demote obvious misuse of kerneldoc to standard comment blocks Date: Wed, 8 Jul 2020 13:02:09 +0100 Message-Id: <20200708120221.3386672-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org No attempt has been made to document either of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/scsi/bnx2fc/bnx2fc_tgt.c:442: warning: Function parameter or member 'lport' not described in 'bnx2fc_rport_event_handler' drivers/scsi/bnx2fc/bnx2fc_tgt.c:442: warning: Function parameter or member 'rdata' not described in 'bnx2fc_rport_event_handler' drivers/scsi/bnx2fc/bnx2fc_tgt.c:442: warning: Function parameter or member 'event' not described in 'bnx2fc_rport_event_handler' drivers/scsi/bnx2fc/bnx2fc_tgt.c:665: warning: Function parameter or member 'hba' not described in 'bnx2fc_alloc_session_resc' drivers/scsi/bnx2fc/bnx2fc_tgt.c:665: warning: Function parameter or member 'tgt' not described in 'bnx2fc_alloc_session_resc' Cc: QLogic-Storage-Upstream@qlogic.com Cc: Prakash Gollapudi Signed-off-by: Lee Jones --- drivers/scsi/bnx2fc/bnx2fc_tgt.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) -- 2.25.1 diff --git a/drivers/scsi/bnx2fc/bnx2fc_tgt.c b/drivers/scsi/bnx2fc/bnx2fc_tgt.c index 50384b4a817c8..a3e2a38aabf2f 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_tgt.c +++ b/drivers/scsi/bnx2fc/bnx2fc_tgt.c @@ -431,7 +431,7 @@ static int bnx2fc_init_tgt(struct bnx2fc_rport *tgt, return 0; } -/** +/* * This event_callback is called after successful completion of libfc * initiated target login. bnx2fc can proceed with initiating the session * establishment. @@ -656,9 +656,8 @@ static void bnx2fc_free_conn_id(struct bnx2fc_hba *hba, u32 conn_id) spin_unlock_bh(&hba->hba_lock); } -/** - *bnx2fc_alloc_session_resc - Allocate qp resources for the session - * +/* + * bnx2fc_alloc_session_resc - Allocate qp resources for the session */ static int bnx2fc_alloc_session_resc(struct bnx2fc_hba *hba, struct bnx2fc_rport *tgt)