diff mbox series

[v2,3/4] ufs: core: Remove len parameter from ufshcd_set_active_icc_lvl

Message ID 1667399353-10228-4-git-send-email-Arthur.Simchaev@wdc.com
State Superseded
Headers show
Series ufs: core: Always read the descriptors with max length | expand

Commit Message

Arthur Simchaev Nov. 2, 2022, 2:29 p.m. UTC
len argument is not used anymore in ufshcd_set_active_icc_lvl function.

Signed-off-by: Arthur Simchaev <Arthur.Simchaev@wdc.com>
---
 drivers/ufs/core/ufshcd.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Bean Huo Nov. 14, 2022, 12:19 p.m. UTC | #1
Arthur,

On 02.11.22 3:29 PM, Arthur Simchaev wrote:
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index aa46292..9cc3abd 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -7386,7 +7386,7 @@ static u32 ufshcd_get_max_icc_level(int sup_curr_uA, u32 start_scan,
>    * Returns calculated ICC level
>    */
>   static u32 ufshcd_find_max_sup_active_icc_level(struct ufs_hba *hba,
> -						const u8 *desc_buf, int len)
> +						const u8 *desc_buf)


'len' description of 'ufshcd_find_max_sup_active_icc_level()' should be 
removed as well.

Kind regards,

Bean
Arthur Simchaev Nov. 15, 2022, 12:49 p.m. UTC | #2
> 
> 
> 'len' description of 'ufshcd_find_max_sup_active_icc_level()' should be
> removed as well.
> 
> Kind regards,
> 
> Bean
Done.

Regards
Arthur
diff mbox series

Patch

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index aa46292..9cc3abd 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -7386,7 +7386,7 @@  static u32 ufshcd_get_max_icc_level(int sup_curr_uA, u32 start_scan,
  * Returns calculated ICC level
  */
 static u32 ufshcd_find_max_sup_active_icc_level(struct ufs_hba *hba,
-						const u8 *desc_buf, int len)
+						const u8 *desc_buf)
 {
 	u32 icc_level = 0;
 
@@ -7444,8 +7444,7 @@  static void ufshcd_set_active_icc_lvl(struct ufs_hba *hba)
 		goto out;
 	}
 
-	icc_level = ufshcd_find_max_sup_active_icc_level(hba, desc_buf,
-							 QUERY_DESC_MAX_SIZE);
+	icc_level = ufshcd_find_max_sup_active_icc_level(hba, desc_buf);
 	dev_dbg(hba->dev, "%s: setting icc_level 0x%x", __func__, icc_level);
 
 	ret = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_WRITE_ATTR,