From patchwork Tue Aug 17 13:43:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 498118 Delivered-To: patch@linaro.org Received: by 2002:a02:6f15:0:0:0:0:0 with SMTP id x21csp1120782jab; Tue, 17 Aug 2021 06:48:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJL8qFAkiDHk4vvp1/pylSWSheXI4EpIjQGiM9dA5E8zXeS9yiS5iXn4f4AW0yXwIgDhmR X-Received: by 2002:a5e:8e4c:: with SMTP id r12mr2950016ioo.73.1629208110855; Tue, 17 Aug 2021 06:48:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629208110; cv=none; d=google.com; s=arc-20160816; b=vX7EHn6f5qWKS0252cRkWXXPF80pnWOXkv6lOZUKBUKCZWao8pwM8DbQmpxoQfWtPI OO8vNRONg/5vUrbJXelQhbCDelOXavr4MRQT1BHUspeO+GOWkL66Dy4mi5XlvfMmbPTD 67T67tO2AUNpegWR3xeUSkHLIfJQRmzXse6MZZTeC5qO6WmVUCMPgxt9y/d4c0XFdV5N JSfJQvX85dk9i2dvFRcYydpwZeAtFG3DCEYa6UDHED9Na72Lf66t7ooJjI8iwH9k29ds hdauzy9aAk1fezPpYHTyNcQDlgu1lOuq9pTiUaZDShftD/3H4r/hJbkkEjEtaV+o0G11 jmVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=1SIElB1lZa/0yyqikRyXXWJLFfss8PLtkknKgC4dCGY=; b=Z9sv3wpuVbVoEX4+2FG3InzPO4mOz5bxvV6QbtUTL8E/kU1AcE4in/oJUSZ138DwHM To+XGN05WAzHFov5er2FPKrE+Y2Hr2/fl/PIWLN6mGkCysBufRzCdvYUv48pEQG4QlJf QDXes+YYro0/VwRHjGdoRMbKNiWhmiBvFX3trCzbv+NwjWneV4AOkxV1QVNouduOey+J zUX/73HckRPFZdbCK/8ar7STVkG7z1yYeOUdEhsqEX5Su2set6xZFYLIAXZMtIfA108v f1DCVIxzt5LkHboBY3AxDtyBHIrSF/QL8tS9MudmawLVX973rW6lGlYzoCFD2wE7b/hk iN0A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w5si2192421ilh.8.2021.08.17.06.48.30 for ; Tue, 17 Aug 2021 06:48:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240081AbhHQNtD (ORCPT ); Tue, 17 Aug 2021 09:49:03 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3656 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235092AbhHQNtC (ORCPT ); Tue, 17 Aug 2021 09:49:02 -0400 Received: from fraeml741-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Gpsm96vDYz6BGWC; Tue, 17 Aug 2021 21:47:37 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml741-chm.china.huawei.com (10.206.15.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Tue, 17 Aug 2021 15:48:27 +0200 Received: from localhost.localdomain (10.69.192.58) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Tue, 17 Aug 2021 14:48:23 +0100 From: John Garry To: , , , , , CC: , , , , , , , , "John Garry" Subject: [PATCH] scsi: ibmvfc: Stop using scsi_cmnd.tag Date: Tue, 17 Aug 2021 21:43:37 +0800 Message-ID: <1629207817-211936-1-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 2.8.1 MIME-Version: 1.0 X-Originating-IP: [10.69.192.58] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Use scsi_cmd_to_rq(scsi_cmnd)->tag in preference to scsi_cmnd.tag. Signed-off-by: John Garry --- This patch was missed in a series to remove scsi_cmnd.tag, which caused a build error on Martin's SCSI staging tree: https://lore.kernel.org/linux-scsi/yq14kbppa42.fsf@ca-mkp.ca.oracle.com/T/#mb47909f38f35837686734369600051b278d124af I note that scsi_cmnd.tag is/was an unsigned char, and I could not find anywhere in the driver which limits scsi_host.can_queue to 255, so using scsi_cmnd.tag looks odd to me. -- 2.17.1 Reviewed-by: Bart Van Assche diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c index 7fa5e64e38c3..ba7150cb226a 100644 --- a/drivers/scsi/ibmvscsi/ibmvfc.c +++ b/drivers/scsi/ibmvscsi/ibmvfc.c @@ -1956,7 +1956,7 @@ static int ibmvfc_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *cmnd) memcpy(iu->cdb, cmnd->cmnd, cmnd->cmd_len); if (cmnd->flags & SCMD_TAGGED) { - vfc_cmd->task_tag = cpu_to_be64(cmnd->tag); + vfc_cmd->task_tag = cpu_to_be64(scsi_cmd_to_rq(cmnd)->tag); iu->pri_task_attr = IBMVFC_SIMPLE_TASK; }