From patchwork Tue Jan 26 11:04:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 370618 Delivered-To: patch@linaro.org Received: by 2002:a02:a60d:0:0:0:0:0 with SMTP id c13csp4909574jam; Tue, 26 Jan 2021 04:14:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJz8NHVI/mIKH+6NTTqwMVwLT7w+0gjdq84LqMVE4Fju1YEjfB7mhZ1pKa8B7EADMnoaa2/A X-Received: by 2002:a05:6402:254b:: with SMTP id l11mr4293341edb.202.1611663242838; Tue, 26 Jan 2021 04:14:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611663242; cv=none; d=google.com; s=arc-20160816; b=TA2MFoaFAw91b65TmyyV3i0CmHkBuJ4rJjS7aYzkezJhA8xBtbkDeMuDusNPsbrVxP YBAFRXmk7YWjsr8dNA8EiIpwk1iB8zIDOfd1yzAStofwgZVM1YBHnRLJzt7yIL3jEvTj tUucoat6WmQKjV1N+yqhYvi0ZFgVIJ49EBA/YQ7qG+IHDJTjJczGKwqmpnuZyv2UHyqZ n26NfHiBIOVit8oJkr3egMI4/gbnV3HTobAkM/4UJnvDVhtQmh5NzD2gcep4arhxOAqk at4FMu0J0kzV9DSWrL1Fxgy+idz6mvAL1X2dj2wFwNfPV0t+veY4M/KBf2gdgVXzSnrv 2AFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=yDIi6u7px+yQuANa1R5mB0O4fbbZHthViMNGx59LxYM=; b=rIIzO/Mypby/wa1TxGZet13X3uvGpFxMv9t4ohx7FdYA+Dbqv/DRW5GuvQ3KtgXsrV M2HtnljSWsdt0zo5VEqgXtLf7deTf+3gWL9Bab8ySuvdVSo9758qQIqc71cbQSdIN2SP YDPoW06skOirkAUWy1/b52nUa+oiNRgQQUNrXES45/RfnB9Va+qoTjLH/asMVhE+KA6P AoUT8djw5QO61NREhSOYlQuLnk9S2REV5EZDuC0r9fBPkCfb29aC7hPIYB2YNRhHcGkL GFMrstTuOnrgigDFQF5ITfAL5nTB1PpR3ieH79Z14TxtwhA+rsN2UdlTRifyQ8DZd6qz mh3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a73si8889453edf.23.2021.01.26.04.14.02 for ; Tue, 26 Jan 2021 04:14:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405096AbhAZMNR (ORCPT ); Tue, 26 Jan 2021 07:13:17 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:11881 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404904AbhAZLJS (ORCPT ); Tue, 26 Jan 2021 06:09:18 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4DQ3pw2Y5sz7Zpw; Tue, 26 Jan 2021 19:07:20 +0800 (CST) Received: from localhost.localdomain (10.69.192.58) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.498.0; Tue, 26 Jan 2021 19:08:24 +0800 From: John Garry To: , CC: , , , John Garry Subject: [PATCH 1/5] scsi: hisi_sas: Remove deferred probe check in hisi_sas_v2_probe() Date: Tue, 26 Jan 2021 19:04:24 +0800 Message-ID: <1611659068-131975-2-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1611659068-131975-1-git-send-email-john.garry@huawei.com> References: <1611659068-131975-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.69.192.58] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org The platform_get_irq() check for -EPROBE_DEFER was to ensure that all the steps to add the SCSI host are not done and then only to realise that the probe needs to be deferred. However, since there is now an earlier check for this in hisi_sas_interrupt_preinit(), this check is superfluous and may be removed. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 12 ------------ 1 file changed, 12 deletions(-) -- 2.26.2 diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c index 502ad3e4f7cd..46f60fc2a069 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c @@ -3627,18 +3627,6 @@ static const struct hisi_sas_hw hisi_sas_v2_hw = { static int hisi_sas_v2_probe(struct platform_device *pdev) { - /* - * Check if we should defer the probe before we probe the - * upper layer, as it's hard to defer later on. - */ - int ret = platform_get_irq(pdev, 0); - - if (ret < 0) { - if (ret != -EPROBE_DEFER) - dev_err(&pdev->dev, "cannot obtain irq\n"); - return ret; - } - return hisi_sas_probe(pdev, &hisi_sas_v2_hw); }