diff mbox series

[V5,3/3] scsi: ufs: Print host regs in IRQ handler when AH8 error happens

Message ID 1606897475-16907-4-git-send-email-cang@codeaurora.org
State New
Headers show
Series [V5,1/3] scsi: ufs: Serialize eh_work with system PM events and async scan | expand

Commit Message

Can Guo Dec. 2, 2020, 8:24 a.m. UTC 
When AH8 error happens, all the regs and states are dumped in err handler.
Sometime we need to look into host regs right after AH8 error happens,
which is before leaving the IRQ handler.

Reviewed-by: Bao D. Nguyen <nguyenb@codeaurora.org>
Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
Reviewed-by: Hongwu Su<hongwus@codeaurora.org>
Signed-off-by: Can Guo <cang@codeaurora.org>
---
 drivers/scsi/ufs/ufshcd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Stanley Chu Dec. 2, 2020, 9 a.m. UTC | #1 
On Wed, 2020-12-02 at 00:24 -0800, Can Guo wrote:
> When AH8 error happens, all the regs and states are dumped in err handler.

> Sometime we need to look into host regs right after AH8 error happens,

> which is before leaving the IRQ handler.

> 

> Reviewed-by: Bao D. Nguyen <nguyenb@codeaurora.org>

> Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>

> Reviewed-by: Hongwu Su<hongwus@codeaurora.org>

> Signed-off-by: Can Guo <cang@codeaurora.org>


Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
diff mbox series

Patch

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index fa90e15..94405e4 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -6057,7 +6057,8 @@  static irqreturn_t ufshcd_check_errors(struct ufs_hba *hba)
 		hba->saved_uic_err |= hba->uic_error;
 
 		/* dump controller state before resetting */
-		if ((hba->saved_err & (INT_FATAL_ERRORS)) ||
+		if ((hba->saved_err &
+		     (INT_FATAL_ERRORS | UFSHCD_UIC_HIBERN8_MASK)) ||
 		    (hba->saved_uic_err &&
 		     (hba->saved_uic_err != UFSHCD_UIC_PA_GENERIC_ERROR))) {
 			dev_err(hba->dev, "%s: saved_err 0x%x saved_uic_err 0x%x\n",