From patchwork Sat Aug 27 16:59:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 74862 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp898117qga; Sat, 27 Aug 2016 10:00:40 -0700 (PDT) X-Received: by 10.98.84.65 with SMTP id i62mr16573373pfb.72.1472317240633; Sat, 27 Aug 2016 10:00:40 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n11si28247637pfk.264.2016.08.27.10.00.40 for ; Sat, 27 Aug 2016 10:00:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-scsi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-scsi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754145AbcH0RAi (ORCPT ); Sat, 27 Aug 2016 13:00:38 -0400 Received: from mail-pf0-f182.google.com ([209.85.192.182]:36349 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752054AbcH0RAh (ORCPT ); Sat, 27 Aug 2016 13:00:37 -0400 Received: by mail-pf0-f182.google.com with SMTP id h186so38132995pfg.3 for ; Sat, 27 Aug 2016 10:00:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=pRrM/4Zfnv+Hw53+uGOcVH1yv0a8Np3PRm/n4dqvZp8=; b=C0111FuK9ChTsEYksh0D8DUyb5LK+EdbdFFcarlRjLvNoqjHNeR1U8xNjewXjvD8OR VnzztwBhjF8ySJyuKVQxlDr81I4RgGYwVMFsM2MbVPhei2lYsoMlJTqmKKbLE+7FpWow O2ob6XKq8diIHmR3CIrIFTZgO4eaC4eMl0Dp0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=pRrM/4Zfnv+Hw53+uGOcVH1yv0a8Np3PRm/n4dqvZp8=; b=ggPvTqJT1zpGtFdAzK/hKD8/VZuaZHGQbceMuQ7oOy2+bUBlgl82hVDKlX2YB+pU/p HWlYEa//gDnYKbN4UnFelHjSkqRwlDldDKnrTferM5PNPp7cWwxCy3Y9/7b02Vl+Kp2O Jop6w/SK4Z3ROzSJLPJw6OdB70eP9HjEThrSY02bQDWaJPxm5Yzxp47PKjk83bJMKfXv vqjdXhxBZS/XTaKC37GeMrPXNyC+XQty11CmWNKPgJyyCDjBv64TLU8EJgFih7RMDdEy HKLnaLNthR0YJ81gNCURKChHoF7VtvDtNQBtpCDLmMTOcAQRs8ctrK2dNYWN6w+SuZ7C FzRg== X-Gm-Message-State: AE9vXwOsoT4j/+RXkHX/MK1qA3OHiMH/BNcM62T0YaZ1s2kga44dwVW7fYzLyQ/Fs4fMA12W X-Received: by 10.98.103.214 with SMTP id t83mr16895170pfj.158.1472317237102; Sat, 27 Aug 2016 10:00:37 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.142]) by smtp.gmail.com with ESMTPSA id c82sm37373698pfb.72.2016.08.27.10.00.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 27 Aug 2016 10:00:36 -0700 (PDT) From: Baoyou Xie To: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@linaro.org, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] scsi: move function declarationes to scsi_priv.h Date: Sun, 28 Aug 2016 00:59:57 +0800 Message-Id: <1472317197-7865-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org We get 2 warnings about global functions without a declaration in the scsi driver when building with W=1: drivers/scsi/scsi_lib.c:467:6: warning: no previous prototype for 'scsi_requeue_run_queue' [-Wmissing-prototypes] drivers/scsi/scsi_lib.c:2609:6: warning: no previous prototype for 'scsi_evt_thread' [-Wmissing-prototypes] in fact, both functiones are declared in drivers/scsi/scsi_scan.c but need to move the declarationes into scsi_priv.h. Signed-off-by: Baoyou Xie --- drivers/scsi/scsi_priv.h | 2 ++ drivers/scsi/scsi_scan.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/scsi/scsi_priv.h b/drivers/scsi/scsi_priv.h index 57a4b99..ff3cde3 100644 --- a/drivers/scsi/scsi_priv.h +++ b/drivers/scsi/scsi_priv.h @@ -85,12 +85,14 @@ extern void scsi_device_unbusy(struct scsi_device *sdev); extern void scsi_queue_insert(struct scsi_cmnd *cmd, int reason); extern void scsi_io_completion(struct scsi_cmnd *, unsigned int); extern void scsi_run_host_queues(struct Scsi_Host *shost); +extern void scsi_requeue_run_queue(struct work_struct *work); extern struct request_queue *scsi_alloc_queue(struct scsi_device *sdev); extern struct request_queue *scsi_mq_alloc_queue(struct scsi_device *sdev); extern int scsi_mq_setup_tags(struct Scsi_Host *shost); extern void scsi_mq_destroy_tags(struct Scsi_Host *shost); extern int scsi_init_queue(void); extern void scsi_exit_queue(void); +extern void scsi_evt_thread(struct work_struct *work); struct request_queue; struct request; extern struct kmem_cache *scsi_sdb_cache; diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index e0a78f5..212e98d 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -217,8 +217,6 @@ static struct scsi_device *scsi_alloc_sdev(struct scsi_target *starget, struct scsi_device *sdev; int display_failure_msg = 1, ret; struct Scsi_Host *shost = dev_to_shost(starget->dev.parent); - extern void scsi_evt_thread(struct work_struct *work); - extern void scsi_requeue_run_queue(struct work_struct *work); sdev = kzalloc(sizeof(*sdev) + shost->transportt->device_size, GFP_ATOMIC);