[01/36] target: Handle MI_REPORT_SUPPORTED_OPERATION_CODES

Microsoft Windows checks for MI_REPORT_SUPPORTED_OPERATION_CODES. Let's
handle this MAINTENANCE_IN command and report supported commands.

Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
---
 drivers/target/target_core_alua.c | 66 +++++++++++++++++++++++++++++++
 drivers/target/target_core_alua.h |  2 +
 drivers/target/target_core_spc.c  | 14 ++++++-
 3 files changed, 80 insertions(+), 2 deletions(-)

Hi Thinh,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 90557fa89d3e99286506593fd5180f699c41b152]

url:    https://github.com/intel-lab-lkp/linux/commits/Thinh-Nguyen/usb-gadget-f_tcm-Enhance-UASP-driver/20220707-074014
base:   90557fa89d3e99286506593fd5180f699c41b152
config: i386-randconfig-a002
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 66ae1d60bb278793fd651cece264699d522bab84)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/9a7c7d74b2c2d3c8524342cb0278ab8b77714bad
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Thinh-Nguyen/usb-gadget-f_tcm-Enhance-UASP-driver/20220707-074014
        git checkout 9a7c7d74b2c2d3c8524342cb0278ab8b77714bad
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/target/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/target/target_core_alua.c:274:6: warning: variable 'buf' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
           if (cdb[2] != 1) {
               ^~~~~~~~~~~
   drivers/target/target_core_alua.c:323:2: note: uninitialized use occurs here
           buf[1] = supported;
           ^~~
   drivers/target/target_core_alua.c:274:2: note: remove the 'if' if its condition is always false
           if (cdb[2] != 1) {
           ^~~~~~~~~~~~~~~~~~
   drivers/target/target_core_alua.c:271:20: note: initialize the variable 'buf' to silence this warning
           unsigned char *buf;
                             ^
                              = NULL
   1 warning generated.


vim +274 drivers/target/target_core_alua.c

   261	
   262	/*
   263	 * REPORT_SUPPORTED_OPERATION_CODES
   264	 *
   265	 * See spc4r17 section 6.27
   266	 */
   267	sense_reason_t
   268	target_emulate_report_supported_opcodes(struct se_cmd *cmd)
   269	{
   270		unsigned char *cdb = cmd->t_task_cdb;
   271		unsigned char *buf;
   272		u8 supported = 0;
   273	
 > 274		if (cdb[2] != 1) {
   275			pr_warn("Invalid command format %d\n", cdb[2]);
   276			goto out;
   277		}
   278	
   279		buf = transport_kmap_data_sg(cmd);
   280		if (!buf)
   281			return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
   282	
   283		switch (cdb[3]) {
   284		case INQUIRY:
   285		case MODE_SENSE:
   286		case MODE_SENSE_10:
   287		case READ_CAPACITY:
   288		case SERVICE_ACTION_IN_16:
   289		case REPORT_LUNS:
   290		case REQUEST_SENSE:
   291		case SYNCHRONIZE_CACHE:
   292		case REZERO_UNIT:
   293		case SEEK_6:
   294		case SEEK_10:
   295		case TEST_UNIT_READY:
   296		case SEND_DIAGNOSTIC:
   297		case MAINTENANCE_IN:
   298		case READ_6:
   299		case READ_10:
   300		case READ_16:
   301		case WRITE_6:
   302		case WRITE_10:
   303		case WRITE_16:
   304		case VERIFY_16:
   305		case MODE_SELECT:
   306		case MODE_SELECT_10:
   307		case START_STOP:
   308		case SECURITY_PROTOCOL_IN:
   309		case SECURITY_PROTOCOL_OUT:
   310			supported = 3;
   311			break;
   312		case ATA_12:
   313		case ATA_16:
   314		case VERIFY:
   315		case ZBC_IN:
   316		case ZBC_OUT:
   317		default:
   318			break;
   319		}
   320	
   321		transport_kunmap_data_sg(cmd);
   322	out:
   323		buf[1] = supported;
   324		target_complete_cmd(cmd, SAM_STAT_GOOD);
   325		return 0;
   326	}
   327