mbox series

[v2,0/3] Stop calling request_irq() with invalid IRQs

Message ID ef3823c1-ee4a-5e9a-0a56-85f401ffa9dd@omprussia.ru
Headers show
Series Stop calling request_irq() with invalid IRQs | expand

Message

Sergey Shtylyov March 29, 2021, 8:15 p.m. UTC 
Here are 3 patches against the 'fixes' branch of Martin Petersen's 'scsi.git' repo,
2 of them were previously posted separately, the 3rd is a new addition.

The affected drivers call platform_get_irq() but ignore its result -- they blithely
pass the negative error codes to request_irq() which expects *unsinged* IRQ #s. Stop
doing that by checking what platfrom_get_irq() returns.

[1/3: scsi: jazz_esp: add IRQ check
[2/3] scsi: sun3x_esp: fix IRQ check
[3/3] scsi: sni_53c710: fix IRQ check

Comments

Sergey Shtylyov March 30, 2021, 5:07 p.m. UTC | #1 
On 3/29/21 11:15 PM, Sergey Shtylyov wrote:

> Here are 3 patches against the 'fixes' branch of Martin Petersen's 'scsi.git' repo,
> 2 of them were previously posted separately, the 3rd is a new addition.
> 
> The affected drivers call platform_get_irq() but ignore its result -- they blithely
> pass the negative error codes to request_irq() which expects *unsinged* IRQ #s. Stop
> doing that by checking what platfrom_get_irq() returns.
> 
> [1/3: scsi: jazz_esp: add IRQ check
> [2/3] scsi: sun3x_esp: fix IRQ check
> [3/3] scsi: sni_53c710: fix IRQ check
 
   Oops, the above 2 patches got misnamed. I'll recast and repost...

MBR, Sergey